[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Keywords|release-notes-needed| Text to go in the||This adds support for the release notes||CAS Single Logout feature. ||Single logout means that ||the user gets logged out ||not only from the CAS ||Server, but also from all ||visited CAS client ||applications when logging ||out in one of them or after ||reaching a timeout. The CAS ||server has to be set up for ||single logout for this to ||take effect, otherwise ||behaviour will remain ||unchanged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druartchanged: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Severity|enhancement |new feature --- Comment #36 from Katrin Fischer --- We have tested with older versions and it should work, but it can also be considered a new feature - grey area, I'd say. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #35 from Nick Clemens --- Hmm...should this be considered for backport - I like the idea of fixing CAS issues, but don't like futzing with Auth code :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #34 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Mason Jameschanged: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #33 from Chris Cormack--- It could be, but really it's just trying to complete the CAS spec you could equally consider it a Bugfix :) Might be nicer for the release notes to say new feature though -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #32 from Jonathan Druart--- Should this considered as a new feature (instead of enhancement)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #31 from Katrin Fischer--- Sorry for missing the last 2 and thx for fixing them! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #25 from Kyle M Hall--- Created attachment 72359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72359=edit Bug 19160: Move duplicated code to its own private subroutine Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #29 from Kyle M Hall--- Created attachment 72363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72363=edit Bug 19160: Remove tab characters causing qa script to fail Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #30 from Kyle M Hall--- Created attachment 72364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72364=edit Bug 19160: Add POD Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #26 from Kyle M Hall--- Created attachment 72360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72360=edit Bug 19160: Move the code from controller to C4::Auth_with_cas Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hallchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #27 from Kyle M Hall--- Created attachment 72361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72361=edit Bug 19160: Isolate CAS code into its own module Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #28 from Kyle M Hall--- Created attachment 72362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72362=edit Bug 19160: (follow-up) Fix problems introduced by renaming logout_required to logout_if_required Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hallchanged: What|Removed |Added Attachment #71831|0 |1 is obsolete|| Attachment #71832|0 |1 is obsolete|| Attachment #71833|0 |1 is obsolete|| Attachment #71834|0 |1 is obsolete|| Attachment #71835|0 |1 is obsolete|| --- Comment #24 from Kyle M Hall --- Created attachment 72358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72358=edit Bug 19160: CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #23 from Katrin Fischer--- We found some small issues in testing as side effects of the rewrite, fixed in a follow-up. Kyle, could you take another look? Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Attachment #70408|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #22 from Katrin Fischer--- Created attachment 71835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71835=edit Bug 19160: (follow-up) Fix problems introduced by renaming logout_required to logout_if_required Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Attachment #70442|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 71834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71834=edit Bug 19160: Isolate CAS code into its own module Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Attachment #71829|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 71831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71831=edit Bug 19160: CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Attachment #70441|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 71833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71833=edit Bug 19160: Move the code from controller to C4::Auth_with_cas Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Attachment #71830|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 71832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71832=edit Bug 19160: Move duplicated code to its own private subroutine Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Attachment #70440|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 71830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71830=edit Bug 19160: Move duplicated code to its own private subroutine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #16 from Katrin Fischer--- Created attachment 71829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71829=edit Bug 19160: CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #15 from Katrin Fischer--- Found a small issue. The last patch renamed the routine logout_required to logout_if_required, but misses to change the import: C4/Auth.pm:import C4::Auth_with_cas qw(check_api_auth_cas checkpw_cas login_cas logout_cas login_cas_url logout_required); We'll fix locally and continue testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #14 from Katrin Fischer--- Some first feedback: We successfully tested the patches on our 16.11.x branch, but want to run some more tests. So far it's looking good! We will try to sign off before end of January. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Chris Cormackchanged: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #13 from Chris Cormack --- Looks good to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |In Discussion --- Comment #12 from Jonathan Druart --- This is what I had in mind. The first 2 patches just move code, the last one may be problematic if I missed something in the logic. In discussion. Please obsolete these patches if you prefer another QAer opinion or switch back to NSO if you agree with testing them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #9 from Jonathan Druart--- Created attachment 70440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70440=edit Bug 19160: Move duplicated code to its own private subroutine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #11 from Jonathan Druart--- Created attachment 70442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70442=edit Bug 19160: Isolate CAS code into its own module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #10 from Jonathan Druart--- Created attachment 70441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70441=edit Bug 19160: Move the code from controller to C4::Auth_with_cas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Comment #8 is|1 |0 private|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #7 from Jonathan Druart--- (In reply to Jonathan Druart from comment #5) > 3. I guess it is just my undestanding of CAS that is bad but why do we call > get_session then delete it? > Is cas_ticket == sessionID? And of course it's not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #6 from Chris Cormack--- (In reply to Jonathan Druart from comment #5) > > Another one: from the pod of CGI::Session->find : > "Experimental feature. > Note: find() is meant to be convenient, not necessarily efficient. It's best > suited in cron scripts." Yes, but it is still a lot faster than opening every session and checking them all by hand. It's only called when a user logs out of another application other than Koha, and only by the CAS server, never by the user. So it is essentially a background process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- I am not going to test this patch, but I would like to make sure the changes make sense. 1. I do not understand the code in opac-user.pl, why is it here? It sounds like it will be better at its place in C4::Auth. 2. You should move out get_session the code you copy/pasted from there 3. I guess it is just my undestanding of CAS that is bad but why do we call get_session then delete it? Is cas_ticket == sessionID? Side note: it will not work if SessionStorage=memcached (but we should remove that), CGI::Session::Driver::memcached->traverse does nothing. Another one: from the pod of CGI::Session->find : "Experimental feature. Note: find() is meant to be convenient, not necessarily efficient. It's best suited in cron scripts." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hallchanged: What|Removed |Added Attachment #66306|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 70408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70408=edit Bug 19160 CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hallchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #3 from Katrin Fischer--- We have since used these patches successfully in production for several months, at first as a backport to 3.22, now in 16.11. No issues so far. The CAS logout will only happen if the CAS server is set up to sent a logout request. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Attachment #66285|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 66306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66306=edit [SIGNED OFF] Bug 19160 CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Chris Cormackchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #1 from Chris Cormack--- Created attachment 66285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66285=edit Bug 19160 CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19160] CAS Single Log Out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischerchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ch...@bigballofwax.co.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/