[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30356 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30356 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #11 from Agnes Rivers-Moore --- There are still confusing hold messages in the OPAC. I know this bug is closed. Adding this as information for others who may come across a similar situation: Test: logged into your account on Koha, search the catalogue for a title, forgetting that you already have a hold on it, and then try to place a hold on that title, the message that comes up is: "There are no items that can be placed on hold." No indication why not. This exists in versions up to 20.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #9 from Marcel de Rooy --- Looks good to me. (We could still improve on holds :) Note that imo we do not need the multi_hold param in opac-reserve. If you have one title, 'none of these titles' is still true. And on the other hand, if you have two titles, we actually do not need the top level none_available message at all. We still see multiple lines with There are no items that can be placed on hold. No big deal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooy changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooy changed: What|Removed |Added Attachment #74802|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 75059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75059&action=edit Bug 19171: Attempt to make "no holds possible" messages less confusing At the moment, when no holds are possible, the OPAC reads something like: Sorry, none of these items can be placed on hold. No items available. This is confusing to the patrons, because the records have items, but they are not showing. The record also may have available items, they are just not permitted to place holds on them. Changes: - Only display the first message, when somoene tried unsuccessfully to place holds on multiple records. - Change first message to: Sorry, none of these titles can be placed on hold. - Change the second message to read: No items available to be placed on hold. - Remove around Sorry for better translatability. To test: - Try to place a hold on single record, where no hold is possible. - Try to place a hold on a single record, where a hold is possible. - Try to place holds on multiple records where no hold is possible. - Try to place holds on multiple records where at least one hold is possible. Verify the screen messages make sense in all cases. Signed-off-by: Owen Leonard Fixed stray during signoff. Signed-off-by: Marcel de Rooy For consistency with staff, I renamed multi_holds to multi_hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Owen Leonard changed: What|Removed |Added Attachment #74710|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 74802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74802&action=edit Bug 19171: Attempt to make "no holds possible" messages less confusing At the moment, when no holds are possible, the OPAC reads something like: Sorry, none of these items can be placed on hold. No items available. This is confusing to the patrons, because the records have items, but they are not showing. The record also may have available items, they are just not permitted to place holds on them. Changes: - Only display the first message, when somoene tried unsuccessfully to place holds on multiple records. - Change first message to: Sorry, none of these titles can be placed on hold. - Change the second message to read: No items available to be placed on hold. - Remove around Sorry for better translatability. To test: - Try to place a hold on single record, where no hold is possible. - Try to place a hold on a single record, where a hold is possible. - Try to place holds on multiple records where no hold is possible. - Try to place holds on multiple records where at least one hold is possible. Verify the screen messages make sense in all cases. https://bugs.koha-community.org/show_bug.cgi?id=14716 Fixed stray during signoff. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 --- Comment #6 from Katrin Fischer --- (In reply to M. Tompsett from comment #5) > Comment on attachment 74710 [details] [review] > Bug 19171: Attempt to make "no holds possible" messages less confusing > > Review of attachment 74710 [details] [review]: > - > > Failed QA for the excess tag, but it would be nice to get an answer the the > question too. > > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt > @@ +22,4 @@ > > > > [% IF ( message ) %] > > > > +Sorry, you cannot place holds. > > I believe you forgot to remove the too. True. > > @@ +174,4 @@ > > You > > have already requested this title. > > [% ELSE %] > > [% UNLESS ( > > bibitemloo.bib_available ) %] > > + > class="alert">There are no items that can be placed on hold. > > If you changed items to titles above, why not here? Because this one actually talks about items - the one above only appears now when you try to place a hold on multiple records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 --- Comment #5 from M. Tompsett --- Comment on attachment 74710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74710 Bug 19171: Attempt to make "no holds possible" messages less confusing Review of attachment 74710: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19171&attachment=74710) - Failed QA for the excess tag, but it would be nice to get an answer the the question too. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ +22,4 @@ > > [% IF ( message ) %] > > +Sorry, you cannot place holds. I believe you forgot to remove the too. @@ +174,4 @@ > You have > already requested this title. > [% ELSE %] > [% UNLESS ( > bibitemloo.bib_available ) %] > +There > are no items that can be placed on hold. If you changed items to titles above, why not here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer changed: What|Removed |Added Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de CC||oleon...@myacpl.org --- Comment #4 from Katrin Fischer --- This is an attempt to make the screen messages less confusing when it's not possible to place a hold. Might work well already or just be a starting point for discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 --- Comment #3 from Katrin Fischer --- Created attachment 74710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74710&action=edit Bug 19171: Attempt to make "no holds possible" messages less confusing At the moment, when no holds are possible, the OPAC reads something like: Sorry, none of these items can be placed on hold. No items available. This is confusing to the patrons, because the records have items, but they are not showing. The record also may have available items, they are just not permitted to place holds on them. Changes: - Only display the first message, when somoene tried unsuccessfully to place holds on multiple records. - Change first message to: Sorry, none of these titles can be placed on hold. - Change the second message to read: No items available to be placed on hold. - Remove around Sorry for better translatability. To test: - Try to place a hold on single record, where no hold is possible. - Try to place a hold on a single record, where a hold is possible. - Try to place holds on multiple records where no hold is possible. - Try to place holds on multiple records where at least one hold is possible. Verify the screen messages make sense in all cases. https://bugs.koha-community.org/show_bug.cgi?id=14716 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 --- Comment #2 from Katrin Fischer --- Just got antoher report on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer changed: What|Removed |Added Severity|minor |normal --- Comment #1 from Katrin Fischer --- Upping severity as we have another library reporting this issue and it's confusing patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer changed: What|Removed |Added Summary|Confusing message "no items |Confusing message "no items |available" on the holds |available" when placing a |page|hold in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
