[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Tomás Cohen Arazi changed: What|Removed |Added Summary|Problem with plugins and|Help plugin authors output |encodings |headers correctly Text to go in the||The current plugin writing release notes||practice is to craft the ||response header in the ||controller methods. This ||patchset adds new helper ||methods for plugin authors ||to use when dealing with ||output on their plugins. ||This way the end-user ||experience is better, and ||the plugin author's tasks ||easier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #12 from Katrin Fischer --- Hi Tomas, can you submit a pull request to the kitchen sink plugin to make this easy to test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Katrin Fischer changed: What|Removed |Added Attachment #73348|0 |1 is obsolete|| Attachment #73349|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 73512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73512&action=edit Bug 19223: Unit tests for output and output_html methods Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #14 from Katrin Fischer --- Created attachment 73513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73513&action=edit Bug 19223: Add methods to correctly handle plugin-generated output This patch introduces two methods to be used by plugin authors: ->output ->output_html They are basically wrappers for the helper methods from C4::Output (output_html_with_http_headers and output_with_http_headers). Plugin authors can use them, or keep the current flexibility of handling the headers themselves in their code. The KitchenSink plugin should be updated to highlight this. To test: - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: The methods are not implemented - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass, and they are meaningful - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #15 from Kyle M Hall --- https://github.com/bywatersolutions/koha-plugin-kitchen-sink/commit/b975bb9b8fa981c3c10d3829d8bc3388fb79864a -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Kyle M Hall changed: What|Removed |Added Attachment #73512|0 |1 is obsolete|| Attachment #73513|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 73589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73589&action=edit Bug 19223: Unit tests for output and output_html methods Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #17 from Kyle M Hall --- Created attachment 73590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73590&action=edit Bug 19223: Add methods to correctly handle plugin-generated output This patch introduces two methods to be used by plugin authors: ->output ->output_html They are basically wrappers for the helper methods from C4::Output (output_html_with_http_headers and output_with_http_headers). Plugin authors can use them, or keep the current flexibility of handling the headers themselves in their code. The KitchenSink plugin should be updated to highlight this. To test: - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: The methods are not implemented - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass, and they are meaningful - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
