[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Signed Off  |RESOLVED

--- Comment #9 from Jonathan Druart  
---
Fixed already by bug 19596.

*** This bug has been marked as a duplicate of bug 19596 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67625|0   |1
is obsolete||

--- Comment #8 from Lari Taskula  ---
Created attachment 67839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67839=edit
Bug 19293: Prevent error when receiving shipment with order with deleted biblio

This patch checks if the biblio exists when receiving a shipment, and
will skip the order if the biblio does not exist.

To test:
1) Find or create a basket
2) Add TWO items to it
3) Find the record for one item in a separate tab, delete the record
4) Notice the order in the basket for that item now says 'deleted
bibliographic
record'
5) close the basket and receive the shipment
6) After entering an invoice number and clicking next, you'll see the
error:
Can't call method "subscriptions" on an undefined value at
/home/vagrant/kohaclone/acqui/parcel.pl line 245.
7) Apply the patch and go back to the basket to receive the shipment
8) Put in an invoice number and click next
9) This should now work as expected, skipping the deleted biblio, and
the other item should show as ready to receive

Sponsored-by: Catalyst IT

Patch applies and works as described when test plan is followed.

Signed-off-by: Dilan Johnpullé 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

--- Comment #7 from Aleisha Amohia  ---
(In reply to Lari Taskula from comment #3)
> Comment on attachment 67070 [details] [review]
> Bug 19293: Prevent error when receiving shipment with order with deleted
> biblio
> 
> Review of attachment 67070 [details] [review]:
> -
> 
> Test plan works, just some small thoughts for the patch. Also I noticed test
> plan was dropped from the commit message after the sign-off.
> 
> ::: acqui/parcel.pl
> @@ +225,4 @@
> >  for (my $i = 0 ; $i < $countpendings ; $i++) {
> >  my $order = $pendingorders->[$i];
> >  
> > +unless( !defined $order->{biblionumber} ){ # if this biblio has 
> > been deleted and the orderline hasn't been cancelled
> 
> if ( defined $order->{biblionumber} ) {
> 
> Or perhaps even
> next unless defined $order->{biblionumber};
> to avoid having to fix indendation of 80+ lines below.

There we go, changed the line to 
if ( defined $order->{biblionumber} ) {

and put test plan back in commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #67624|0   |1
is obsolete||

--- Comment #6 from Aleisha Amohia  ---
Created attachment 67625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67625=edit
[SIGNED-OFF] Bug 19293: Prevent error when receiving shipment with order with
deleted biblio

This patch checks if the biblio exists when receiving a shipment, and
will skip the order if the biblio does not exist.

To test:
1) Find or create a basket
2) Add TWO items to it
3) Find the record for one item in a separate tab, delete the record
4) Notice the order in the basket for that item now says 'deleted
bibliographic
record'
5) close the basket and receive the shipment
6) After entering an invoice number and clicking next, you'll see the
error:
Can't call method "subscriptions" on an undefined value at
/home/vagrant/kohaclone/acqui/parcel.pl line 245.
7) Apply the patch and go back to the basket to receive the shipment
8) Put in an invoice number and click next
9) This should now work as expected, skipping the deleted biblio, and
the other item should show as ready to receive

Sponsored-by: Catalyst IT

Patch applies and works as described when test plan is followed.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #67127|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 67624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67624=edit
[SIGNED-OFF] Bug 19293: Prevent error when receiving shipment with order with
deleted biblio

This patch checks if the biblio exists when receiving a shipment, and
will skip the order if the biblio does not exist.

To test:
1) Find or create a basket
2) Add TWO items to it
3) Find the record for one item in a separate tab, delete the record
4) Notice the order in the basket for that item now says 'deleted
bibliographic
record'
5) close the basket and receive the shipment
6) After entering an invoice number and clicking next, you'll see the
error:
Can't call method "subscriptions" on an undefined value at
/home/vagrant/kohaclone/acqui/parcel.pl line 245.
7) Apply the patch and go back to the basket to receive the shipment
8) Put in an invoice number and click next
9) This should now work as expected, skipping the deleted biblio, and
the other item should show as ready to receive

Sponsored-by: Catalyst IT

Patch applies and works as described when test plan is followed.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@jns.fi

--- Comment #4 from Lari Taskula  ---
(In reply to Lari Taskula from comment #3)
> Comment on attachment 67070 [details] [review]
> to avoid having to fix indendation of 80+ lines below.
40+ lines, sorry :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

--- Comment #3 from Lari Taskula  ---
Comment on attachment 67070
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67070
Bug 19293: Prevent error when receiving shipment with order with deleted biblio

Review of attachment 67070:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19293=67070)
-

Test plan works, just some small thoughts for the patch. Also I noticed test
plan was dropped from the commit message after the sign-off.

::: acqui/parcel.pl
@@ +225,4 @@
>  for (my $i = 0 ; $i < $countpendings ; $i++) {
>  my $order = $pendingorders->[$i];
>  
> +unless( !defined $order->{biblionumber} ){ # if this biblio has been 
> deleted and the orderline hasn't been cancelled

if ( defined $order->{biblionumber} ) {

Or perhaps even
next unless defined $order->{biblionumber};
to avoid having to fix indendation of 80+ lines below.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #67070|0   |1
is obsolete||

--- Comment #2 from Dilan Johnpullé  ---
Created attachment 67127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67127=edit
Bug 19293: Prevent error when receiving shipment with order with deleted biblio

Patch applies and works as described when test plan is followed.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

--- Comment #1 from Aleisha Amohia  ---
Created attachment 67070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67070=edit
Bug 19293: Prevent error when receiving shipment with order with deleted biblio

This patch checks if the biblio exists when receiving a shipment, and
will skip the order if the biblio does not exist.

To test:
1) Find or create a basket
2) Add TWO items to it
3) Find the record for one item in a separate tab, delete the record
4) Notice the order in the basket for that item now says 'deleted bibliographic
record'
5) close the basket and receive the shipment
6) After entering an invoice number and clicking next, you'll see the
error:
Can't call method "subscriptions" on an undefined value at
/home/vagrant/kohaclone/acqui/parcel.pl line 245.
7) Apply the patch and go back to the basket to receive the shipment
8) Put in an invoice number and click next
9) This should now work as expected, skipping the deleted biblio, and
the other item should show as ready to receive

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/