[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Owen Leonard changed: What|Removed |Added Attachment #67386|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 68080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68080&action=edit Bug 19356: Move staff client cart JavaScript to the footer This patch modifies the staff client cart template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality. Signed-off-by: Aleisha Amohia Correction for QA: Removed contditional around footer JS (from copy-paste) because it will always be true. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #3 from Nick Clemens --- Why the conditional for footerjs? If we are setting it statically why not just always include the js in footer? If I understand the variable is to prvent doc-head-close / intranet-bottom.inc from adding more js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Aleisha Amohia changed: What|Removed |Added Attachment #67278|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 67386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67386&action=edit [SIGNED-OFF] Bug 19356: Move staff client cart JavaScript to the footer This patch modifies the staff client cart template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 --- Comment #1 from Owen Leonard --- Created attachment 67278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67278&action=edit Bug 19356: Move staff client cart JavaScript to the footer This patch modifies the staff client cart template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
