[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS --- Depends on Bug 17797 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Pushed to Master|Pushed to Stable --- Comment #13 from Nick Clemens --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 --- Comment #11 from Marcel de Rooy --- (In reply to Josef Moravec from comment #10) > Signed-off-by: Josef Moravec Thx Josef. Welcome in the QA team ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Josef Moravec changed: What|Removed |Added Attachment #68157|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 69624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69624&action=edit Bug 19439: Remove eval with exit statements from opac/unapi The script contains some error responses that get lost when using them in an eval statement. (Since exit should not be used within an eval construction.) The eval is removed now. Test plan: [1] Before applying this patch, you could look at the current responses from unapi for the calls in the next steps. Apply the patch now. [2] Call http(s)://[your-server]/cgi-bin/koha/unapi with only a format parameter. Check if you have a 400 status response. (In Firefox, look at Network tab of Developer Tools.) Note: Have to admit (reluctantly) that MS Edge shows the status code in the browser rightaway in contrast with Firefox. [3] Call unapi with a format=marcxml&id=999 The wrong id parameter should trigger a 404 response. [4] Call unapi with format=marcxml&id=koha:biblionumber:[notexist] where notexist is a biblionumber that not exists. This should trigger again a 404 response. [5] Call unapi with format=marcxmlx&id=koha:biblionumber:[exist] where exist should be a good biblionumber. The wrong format should trigger a 406 response. [6] Bonus: The 500 response can be tested by manipulating a XSLT file. Create invalid xml in the file for marcxml (identity.xsl in intranet xslt folder). Call unapi with format=marcxml&id=koha:biblionumber:[exist]. You should get a 500 response and have warnings in your logfile. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Josef Moravec changed: What|Removed |Added Attachment #69623|0 |1 is obsolete|| --- Comment #10 from Josef Moravec --- Created attachment 69625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69625&action=edit Bug 19439: (Follow-up) Remove four spaces from lines 133-149 Speaks for itself. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Josef Moravec changed: What|Removed |Added Attachment #68158|0 |1 is obsolete|| --- Comment #8 from Josef Moravec --- Created attachment 69623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69623&action=edit Bug 19439: (Follow-up) Remove four spaces from lines 133-149 Speaks for itself. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Jonathan Druart changed: What|Removed |Added Severity|enhancement |major --- Comment #7 from Jonathan Druart --- Yes, but too late for 17.11.00 now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Marcel de Rooy changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Marcel de Rooy --- Jonathan: Would you consider this one as a bugfix too ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Signed Off --- Comment #5 from Katrin Fischer --- Learned something new about what Koha can do - nice! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Katrin Fischer changed: What|Removed |Added Attachment #67872|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 68157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68157&action=edit Bug 19439: Remove eval with exit statements from opac/unapi The script contains some error responses that get lost when using them in an eval statement. (Since exit should not be used within an eval construction.) The eval is removed now. Test plan: [1] Before applying this patch, you could look at the current responses from unapi for the calls in the next steps. Apply the patch now. [2] Call http(s)://[your-server]/cgi-bin/koha/unapi with only a format parameter. Check if you have a 400 status response. (In Firefox, look at Network tab of Developer Tools.) Note: Have to admit (reluctantly) that MS Edge shows the status code in the browser rightaway in contrast with Firefox. [3] Call unapi with a format=marcxml&id=999 The wrong id parameter should trigger a 404 response. [4] Call unapi with format=marcxml&id=koha:biblionumber:[notexist] where notexist is a biblionumber that not exists. This should trigger again a 404 response. [5] Call unapi with format=marcxmlx&id=koha:biblionumber:[exist] where exist should be a good biblionumber. The wrong format should trigger a 406 response. [6] Bonus: The 500 response can be tested by manipulating a XSLT file. Create invalid xml in the file for marcxml (identity.xsl in intranet xslt folder). Call unapi with format=marcxml&id=koha:biblionumber:[exist]. You should get a 500 response and have warnings in your logfile. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Katrin Fischer changed: What|Removed |Added Attachment #67873|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 68158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68158&action=edit Bug 19439: (Follow-up) Remove four spaces from lines 133-149 Speaks for itself. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Marcel de Rooy changed: What|Removed |Added Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Marcel de Rooy changed: What|Removed |Added Depends on||17797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 [Bug 17797] Add XSLT_Handler in opac/unapi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |trivial Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl Keywords||Academy Component|OPAC|Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 --- Comment #2 from Marcel de Rooy --- Created attachment 67873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67873&action=edit Bug 19439: (Follow-up) Remove four spaces from lines 133-149 Speaks for itself. No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 --- Comment #1 from Marcel de Rooy --- Created attachment 67872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67872&action=edit Bug 19439: Remove eval with exit statements from opac/unapi The script contains some error responses that get lost when using them in an eval statement. (Since exit should not be used within an eval construction.) The eval is removed now. Test plan: [1] Before applying this patch, you could look at the current responses from unapi for the calls in the next steps. Apply the patch now. [2] Call http(s)://[your-server]/cgi-bin/koha/unapi with only a format parameter. Check if you have a 400 status response. (In Firefox, look at Network tab of Developer Tools.) Note: Have to admit (reluctantly) that MS Edge shows the status code in the browser rightaway in contrast with Firefox. [3] Call unapi with a format=marcxml&id=999 The wrong id parameter should trigger a 404 response. [4] Call unapi with format=marcxml&id=koha:biblionumber:[notexist] where notexist is a biblionumber that not exists. This should trigger again a 404 response. [5] Call unapi with format=marcxmlx&id=koha:biblionumber:[exist] where exist should be a good biblionumber. The wrong format should trigger a 406 response. [6] Bonus: The 500 response can be tested by manipulating a XSLT file. Create invalid xml in the file for marcxml (identity.xsl in intranet xslt folder). Call unapi with format=marcxml&id=koha:biblionumber:[exist]. You should get a 500 response and have warnings in your logfile. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Marcel de Rooy changed: What|Removed |Added Summary|Some error response from|Some error responses from |unapi get lost in eval |opac/unapi get lost in eval -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
