[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #890 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #889) > Today is Pass QA Day! What do I need to do to satisfy the QA team? As promised, I am going to pass QA now on this patch set. See former comments. We did not receive any visible responses from QA team or others that stepped in to help, so that should be a positive sign also: no problems encountered. The diligent work of David Nind still counts as a signoff. The attention of Katrin, Victor and myself counts for a QA stamp. Fridolin: go ahead now and don't wait too long ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Keywords||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #889 from Aleisha Amohia --- Today is Pass QA Day! What do I need to do to satisfy the QA team? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #888 from Marcel de Rooy --- Final comment for now. Aleisha has done a really amazing job in keeping this development alive from 2017 onwards. It is a very brave effort on itself to insert this feature into Koha's circulation core; we know that the existing code with all its holds preferences and policies is a minefield. What I saw, looks good and connects with Koha coding practices within the last 5 years. An important step that still needs to be made, is REST API support on follow-up reports. As to functionality, a lot of things have been said and can be said. But this provides us a good base to build and improve further. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #887 from Marcel de Rooy --- Still posting two observations from a functional view without any need to address them here btw. Functionally, it is a bit confusing that the recall overdue fine amount is so close in the interface to the number of recalls allowed, due date interval, etc. Because it is actually a fine that will not be placed on the person doing the recall but on the patron that loaned the book (and might be in another patron category). So when you enable recalls for a category and you want to have a non-regular overdue fine, you should fill all recall fines on the other categories as well. Maybe something for documentation ? Another functional remark is that the recalls feature currently does not support policies like we have for holds (e.g. you cannot place recalls on items of another branch etc.). Certainly not meant as a blocker at this moment. But I feel that the need to refine circulation rules at that level will be felt soon by multiple branch libraries. You cannot really introduce recalls for one branch now, since the members of that branch can place recalls on books of the other branches. This may need further thought on follow-up reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #886 from Aleisha Amohia --- Thanks Marcel, I appreciate you helping me get this over the line. If there are bits I can look at, let me know, I have a bit of capacity at the moment. Pass QA on Friday 11 sounds like a great plan to me. Any additional QA team help in between would be awesome! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #885 from Marcel de Rooy --- I hope to finish up tomorrow which actually does not mean that I could QA this huge patch set just on my own [impossible; see earlier comments], but I have spent a considerable amount of time on it and my time is limited too. It looks quite good to me considering elapsed time etc. And yes, there is a serious overlap with holds and code doing similar things. But thinking about that, the alternative of injecting this into holds might be even worse. So I would welcome the other people that stepped forward to help, to especially test things in the coming week. (David or Katrin, feel free to switch to Signed Off.) Based on their findings, I would propose to pass QA on Friday 11. And let Fridolin push it soon after that. Allowing all to find the remaining bugs ;) What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #884 from Marcel de Rooy --- Created attachment 131330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131330=edit Bug 19532: (QA follow-up) Add the cron jobs to the cron files Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #883 from Aleisha Amohia --- It's looking good Marcel! Thanks for your help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130643|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130642|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #882 from Marcel de Rooy --- Aleisha: Note that I added an extra patch in the beginning too to extract DBIx stuff out of a regular patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #131260|0 |1 is obsolete|| --- Comment #881 from Marcel de Rooy --- Created attachment 131282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131282=edit Bug 19532: (QA follow-up) Move as_list to iterator based loop Adjusting both new cron jobs. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131257|0 |1
is obsolete||
--- Comment #880 from Marcel de Rooy ---
Created attachment 131281
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131281=edit
Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber
The fines cron job uses Getoverdues to pass issue info to CalcFine.
It took me a while to realize that the overdue hash does not contain
a biblionumber. When testing CalcFine, we pass an item hash that
does include one.
So what happened? $item->{biblionumber} is undefined when it comes from
Getoverdues and no recall overdue fine is calculated, only a regular one.
Simple fix (without any impact): Add a biblionumber to Getoverdues.
Signed-off-by: Marcel de Rooy
Tested with fines.pl: recall fine applied now.
Ran some Circulation and Overdues unit tests.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #131193|0 |1 is obsolete|| --- Comment #879 from Marcel de Rooy --- Created attachment 131280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131280=edit Bug 19532: (QA follow-up) Fix few Koha::Recalls->search occurrences Due to the wantarray change, we should fix this call in list context. We should either use an iterator now or append as_list. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #131160|0 |1 is obsolete|| --- Comment #878 from Marcel de Rooy --- Created attachment 131279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131279=edit Bug 19532: (follow-up) Fix for wantarray change and title-string Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #131159|0 |1 is obsolete|| --- Comment #877 from Marcel de Rooy --- Created attachment 131278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131278=edit Bug 19532: (QA follow-up) Fixing unit tests (Trivial:) Number of tests in Koha/Item.t Added a $patron object to resolve warnings like: * Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?) at t/db_dependent/Koha/Patron.t line 1064. Fixed CanItemBeReserved call in Holds.t, number of tests adjusted Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #131158|0 |1 is obsolete|| --- Comment #876 from Marcel de Rooy --- Created attachment 131277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131277=edit Bug 19532: (follow-up) Fixes along recall workflow Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #131157|0 |1 is obsolete|| --- Comment #875 from Marcel de Rooy --- Created attachment 131276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131276=edit Bug 19532: (QA follow-up) Enable XSLT statuses translation Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #131156|0 |1 is obsolete|| --- Comment #874 from Marcel de Rooy --- Created attachment 131275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131275=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130653|0 |1 is obsolete|| --- Comment #873 from Marcel de Rooy --- Created attachment 131274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131274=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130652|0 |1 is obsolete|| --- Comment #872 from Marcel de Rooy --- Created attachment 131273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131273=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130651|0 |1 is obsolete|| --- Comment #871 from Marcel de Rooy --- Created attachment 131272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131272=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130650|0 |1 is obsolete|| --- Comment #870 from Marcel de Rooy --- Created attachment 131271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131271=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130649|0 |1 is obsolete|| --- Comment #869 from Marcel de Rooy --- Created attachment 131270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131270=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130648|0 |1 is obsolete|| --- Comment #868 from Marcel de Rooy --- Created attachment 131269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131269=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130647|0 |1 is obsolete|| --- Comment #867 from Marcel de Rooy --- Created attachment 131268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131268=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130646|0 |1 is obsolete|| --- Comment #866 from Marcel de Rooy --- Created attachment 131267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131267=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130645|0 |1 is obsolete|| --- Comment #865 from Marcel de Rooy --- Created attachment 131266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131266=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130644|0 |1 is obsolete|| --- Comment #864 from Marcel de Rooy --- Created attachment 131265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131265=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #863 from Marcel de Rooy --- Created attachment 131264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131264=edit Bug 19532: [DBIx] Schema change for Recalls Separated from the "Recalls-objects-and-tests" patch Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #862 from Marcel de Rooy --- Created attachment 131263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131263=edit Bug 19532: [DBIx] Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #861 from Marcel de Rooy --- Created attachment 131262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131262=edit Bug 19532: [DBIx] Updated schema files Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #130641|0 |1 is obsolete|| --- Comment #860 from Marcel de Rooy --- Created attachment 131261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131261=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #859 from Marcel de Rooy --- Created attachment 131260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131260=edit Bug 19532: (QA follow-up) Move as_list to iterator based loop Adjusting both new cron jobs. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #858 from Marcel de Rooy --- TODO We need to add two new cronjobs to the cron files (debian side and example file somewhere in etc folder) misc/cronjobs/recalls/expire_recalls.pl misc/cronjobs/recalls/overdue_recalls.pl They both do a recalls search. If one has not activated recalls, no records are found. Early exit. All fine. Note the following: "check if item has been recalled. recall should have been marked Overdue by cronjob, so only look at overdue recalls" => So we need to run overdue_recalls BEFORE fines (CalcFine) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #857 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #856)
> Created attachment 131257 [details] [review]
> Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber
>
> The fines cron job uses Getoverdues to pass issue info to CalcFine.
> It took me a while to realize that the overdue hash does not contain
> a biblionumber. When testing CalcFine, we pass an item hash that
> does include one.
>
> So what happened? $item->{biblionumber} is undefined when it comes from
> Getoverdues and no recall overdue fine is calculated, only a regular one.
>
> Simple fix (without any impact): Add a biblionumber to Getoverdues.
>
> Signed-off-by: Marcel de Rooy
> Tested with fines.pl: recall fine applied now.
> Ran some Circulation and Overdues unit tests.
This was a serious bug! The fines cron job would never ever calculate the
correct recalls fine when you relied on Getoverdues without biblionumber..
I didnt see any reference to testing this process in the large test plan btw ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #856 from Marcel de Rooy ---
Created attachment 131257
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131257=edit
Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber
The fines cron job uses Getoverdues to pass issue info to CalcFine.
It took me a while to realize that the overdue hash does not contain
a biblionumber. When testing CalcFine, we pass an item hash that
does include one.
So what happened? $item->{biblionumber} is undefined when it comes from
Getoverdues and no recall overdue fine is calculated, only a regular one.
Simple fix (without any impact): Add a biblionumber to Getoverdues.
Signed-off-by: Marcel de Rooy
Tested with fines.pl: recall fine applied now.
Ran some Circulation and Overdues unit tests.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #855 from Marcel de Rooy ---
I remember to have posted this before, but these lines show me that Recalls
does not support itemtype notforloan:
+ return 0 if ( $self->notforloan != 0 );
OR +my @items = Koha::Items->search({ biblionumber => $self->biblionumber,
itemlost => 0, withdrawn => 0, notforloan => 0 })->as_list;
OR +[% IF (
item.notforloan ) %]
The only check for notforloan in the new code is made only on the item, not on
the itemtype.
Dont think that we need to fix it here now. No blocker.
I am wondering btw: If we can only recall something checked out, when would
notforloan come into play actually? Seems to be an edge case like item was
checked out, notforloan was activated after that, etc.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #854 from Marcel de Rooy --- Same remark for: FAIL C4/Overdues.pm FAIL pod coverage POD is missing for 'GetWdayFromItemnumber' and FAIL C4/XSLT.pm FAIL pod coverage POD is missing for get_xsl_filename POD is missing for get_xslt_sysprefs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #853 from Marcel de Rooy --- FAIL C4/Circulation.pm FAIL pod coverage POD is missing for AddOfflineOperation POD is missing for CheckValidBarcode POD is missing for DeleteOfflineOperation POD is missing for GetOfflineOperation POD is missing for GetOfflineOperations POD is missing for GetRenewCount POD is missing for GetTopIssues POD is missing for ProcessOfflineIssue POD is missing for ProcessOfflineOperation POD is missing for ProcessOfflinePayment POD is missing for ProcessOfflineReturn POD is missing for ReturnLostItem POD is missing for TooMany POD is missing for checkHighHolds C4::Circulation has a Pod::Coverage rating of 0.702127659574468 The following are uncovered: AddOfflineOperation, CheckValidBarcode, DeleteOfflineOperation, GetOfflineOperation, GetOfflineOperations, GetRenewCount, GetTopIssues, ProcessOfflineIssue, ProcessOfflineOperation, ProcessOfflinePayment, ProcessOfflineReturn, ReturnLostItem, TooMany, checkHighHolds This can be safely ignored: we dont add subs here, just some changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #852 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #851)
> In conclusion: We dont wanna die here, but as for ReturnClaims we could send
> a code to the template allowing to return something meaningful to the user?
> Obsoleting the last patch now. Correct me when I am wrong.
And looking in context, I indeed see stuff like:
elsif ( $code eq 'WrongTransfer' ) {
;# FIXME... anything to do here?
}
elsif ( $code eq 'WrongTransferItem' ) {
;# FIXME... anything to do here?
}
So lets just leave as-is now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #131213|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #851 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #850)
> Not unfinished business, I was just copying the similar code above, but I
> have removed in latest follow-up.
Are you really really sure about that :) ?
Look here, read the else comment too !
elsif ( $code eq 'ReturnClaims' ) {
$template->param( ReturnClaims => $messages->{ReturnClaims} );
-} elsif ( $code eq 'RecallFound' ) {
-;
-} elsif ( $code eq 'RecallNeedsTransfer' ) {
-;
-} elsif ( $code eq 'TransferredRecall' ) {
-;
} else {
die "Unknown error code $code";# note we need all the (empty)
elsif's above, or we die.
# This forces the issue of staying in sync w/ Circulation.pm
In conclusion: We dont wanna die here, but as for ReturnClaims we could send a
code to the template allowing to return something meaningful to the user?
Obsoleting the last patch now. Correct me when I am wrong.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #850 from Aleisha Amohia ---
Cool I will ignore that warning about KohaPlugins then.
(In reply to Marcel de Rooy from comment #848)
> From code glancing:
> Unfinished business?
>
> +} elsif ( $code eq 'RecallFound' ) {
> +;
> +} elsif ( $code eq 'RecallNeedsTransfer' ) {
> +;
> +} elsif ( $code eq 'TransferredRecall' ) {
> +;
Not unfinished business, I was just copying the similar code above, but I have
removed in latest follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #849 from Aleisha Amohia --- Created attachment 131213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131213=edit Bug 19532: (follow-up) Removing unnecessary code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #848 from Marcel de Rooy ---
From code glancing:
Unfinished business?
+} elsif ( $code eq 'RecallFound' ) {
+;
+} elsif ( $code eq 'RecallNeedsTransfer' ) {
+;
+} elsif ( $code eq 'TransferredRecall' ) {
+;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #847 from Marcel de Rooy --- Saw this warning in QA tools: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/KohaPlugins.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206. SAME for koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt The reload aborted on Template plugins I have seen incidentally on a few other reports, where we did spend quite some time to resolve it to no avail. Eventually they were ignored. This report does not do anything with the KohaPlugins template plugin. So I think we can discard it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #846 from Marcel de Rooy --- Created attachment 131193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131193=edit Bug 19532: (QA follow-up) Fix few Koha::Recalls->search occurrences Due to the wantarray change, we should fix this call in list context. We should either use an iterator now or append as_list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #845 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #844) > (In reply to Marcel de Rooy from comment #835) > > Still applied on current master (more or less: minor conflicts) > > commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103 > > > > Will be spending some time on it now and next week, and hoping that the > > other volunteers will be able to do so too.. > > Have fixed the merge conflict and the failing tests and qa tests mentioned > above. Thx for doing that quickly. Resuming here now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #844 from Aleisha Amohia --- (In reply to Marcel de Rooy from comment #835) > Still applied on current master (more or less: minor conflicts) > commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103 > > Will be spending some time on it now and next week, and hoping that the > other volunteers will be able to do so too.. Have fixed the merge conflict and the failing tests and qa tests mentioned above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #843 from Aleisha Amohia --- Created attachment 131160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131160=edit Bug 19532: (follow-up) Fix for wantarray change and title-string -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #131108|0 |1 is obsolete|| --- Comment #842 from Aleisha Amohia --- Created attachment 131159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131159=edit Bug 19532: (QA follow-up) Fixing unit tests (Trivial:) Number of tests in Koha/Item.t Added a $patron object to resolve warnings like: * Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?) at t/db_dependent/Koha/Patron.t line 1064. Fixed CanItemBeReserved call in Holds.t, number of tests adjusted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #130656|0 |1 is obsolete|| --- Comment #841 from Aleisha Amohia --- Created attachment 131158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131158=edit Bug 19532: (follow-up) Fixes along recall workflow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #130655|0 |1 is obsolete|| --- Comment #840 from Aleisha Amohia --- Created attachment 131157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131157=edit Bug 19532: (QA follow-up) Enable XSLT statuses translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #130654|0 |1 is obsolete|| --- Comment #839 from Aleisha Amohia --- Created attachment 131156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131156=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #838 from Marcel de Rooy --- Created attachment 131108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131108=edit Bug 19532: (QA follow-up) Fixing unit tests (Trivial:) Number of tests in Koha/Item.t Added a $patron object to resolve warnings like: * Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?) at t/db_dependent/Koha/Patron.t line 1064. Fixed CanItemBeReserved call in Holds.t, number of tests adjusted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #837 from Marcel de Rooy --- QA tools is quite happy, here are two items: TODO koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt * forbidden pattern: Don't use the title-string class for sorting (bug 27934) (line 39) TODO koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt * forbidden pattern: Don't use the title-string class for sorting (bug 27934) (line 760) See the referenced bug for pointers to resolve it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #836 from Marcel de Rooy ---
Some intermediate observations. Will continue next week.
TODO FAIL t/db_dependent/Circulation/CalcFine.t
* The method Koha::Recalls->item_level_recall is not covered by tests!
=> Error in sub CalcFine (Overdues.pm)
=> This is related to the recent wantarray change in Koha: you do no longer
receive individual results, but a result set
TODO t/db_dependent/Koha/Biblio.t
# Failed test 'Recalls tests'
=> Related to the wantarray thing again
Example: # got: 'Koha::Recalls=HASH(0x55e97949bf68)'#
expected: '3'
TODO t/db_dependent/Circulation.t
# Subtest: CanBookBeRenewed tests # Looks like you planned 97 tests but ran
24.
The method Koha::Recalls->item_level_recall is not covered by tests!
Trace begun at /usr/share/koha/Koha/Objects.pm line 572
Koha::Objects::AUTOLOAD('Koha::Recalls=HASH(0x5566928b68a0)') called at
/usr/share/koha/C4/Overdues.pm line 267
C4::Overdues::CalcFine('HASH(0x556692872ac0)', 'v1HCIX_4rK', 'u4RykAzG',
'DateTime=HASH(0x5566928c98a0)', 'DateTime=HASH(0x556692855198)') called at
t/db_dependent/Circulation.t line 700
=> Looks like the same problem: wantarray trouble again
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #835 from Marcel de Rooy --- Still applied on current master (more or less: minor conflicts) commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103 Will be spending some time on it now and next week, and hoping that the other volunteers will be able to do so too.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #834 from Aleisha Amohia --- Created attachment 130656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130656=edit Bug 19532: (follow-up) Fixes along recall workflow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129319|0 |1 is obsolete|| --- Comment #833 from Aleisha Amohia --- Created attachment 130655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130655=edit Bug 19532: (QA follow-up) Enable XSLT statuses translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129318|0 |1 is obsolete|| --- Comment #832 from Aleisha Amohia --- Created attachment 130654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130654=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129317|0 |1 is obsolete|| --- Comment #831 from Aleisha Amohia --- Created attachment 130653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130653=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129316|0 |1 is obsolete|| --- Comment #830 from Aleisha Amohia --- Created attachment 130652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130652=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129315|0 |1 is obsolete|| --- Comment #829 from Aleisha Amohia --- Created attachment 130651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130651=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129314|0 |1 is obsolete|| --- Comment #828 from Aleisha Amohia --- Created attachment 130650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130650=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129313|0 |1 is obsolete|| --- Comment #827 from Aleisha Amohia --- Created attachment 130649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130649=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129312|0 |1 is obsolete|| --- Comment #826 from Aleisha Amohia --- Created attachment 130648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130648=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129311|0 |1 is obsolete|| --- Comment #825 from Aleisha Amohia --- Created attachment 130647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130647=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129310|0 |1 is obsolete|| --- Comment #824 from Aleisha Amohia --- Created attachment 130646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130646=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129309|0 |1 is obsolete|| --- Comment #823 from Aleisha Amohia --- Created attachment 130645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130645=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129308|0 |1 is obsolete|| --- Comment #822 from Aleisha Amohia --- Created attachment 130644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130644=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129307|0 |1 is obsolete|| --- Comment #821 from Aleisha Amohia --- Created attachment 130643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130643=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129306|0 |1 is obsolete|| --- Comment #820 from Aleisha Amohia --- Created attachment 130642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130642=edit Bug 19532: Updated schema files Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129305|0 |1 is obsolete|| --- Comment #819 from Aleisha Amohia --- Created attachment 130641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130641=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #818 from Katrin Fischer --- I understand the difficulties of splitting it up now, so totally ok working with the rebased patch set. Thx Marcel and Aleisha for clearing things up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #817 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #816) > I see. In the email chain we had discussed reformatting but clearly there > was some misunderstanding. > > I had started rewriting things before Christmas but it was proving to be > very difficult to split the patches out into different 'stages' of > development. > > My preference would be to rebase what is on here and bring it up to main, as > long as the QA team is happy to coordinate in getting it through. > > Should I do that then? Yes please check my latest rebase (Jan 11). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #816 from Aleisha Amohia --- I see. In the email chain we had discussed reformatting but clearly there was some misunderstanding. I had started rewriting things before Christmas but it was proving to be very difficult to split the patches out into different 'stages' of development. My preference would be to rebase what is on here and bring it up to main, as long as the QA team is happy to coordinate in getting it through. Should I do that then? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #815 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #814) > I am talking about the current patchset. My understanding was that as the > patches currently are, they are too big and daunting to effectively test and > QA. Thanks for your quick response! We seem to have some kind of misunderstanding here. Note that I do not oppose your breaking it up but it will take you time once again. In view of the patch history I wrote earlier in comment783: "Note that I am not asking you to split it up now." So I was thinking about handling the current set and especially stressing that we would appreciate future submissions in another form. See also comment785. "We do need some coordination to get a patch of this size in." Comment789: "So we had consensus about proceeding on recalls in its current form in view of time elapsed shortly after release." So perhaps you understand now the track that I was on? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #814 from Aleisha Amohia --- I am talking about the current patchset. My understanding was that as the patches currently are, they are too big and daunting to effectively test and QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #813 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #812) > I started rewriting before Christmas but couldn't get it sorted in time. > Will try to pick up again this week or next. Trying to work out the best way > to split everything out. Thanks for responding. In order to prevent misunderstandings, are you talking about the current patches or development on top of this patch set? If you are talking about the current set, it would be useless for us to work further on it when you will be rewriting it. Please confirm! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #812 from Aleisha Amohia --- I started rewriting before Christmas but couldn't get it sorted in time. Will try to pick up again this week or next. Trying to work out the best way to split everything out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #811 from Fridolin Somers --- Sure, I'm in. At first look code looks pretty mature. I'll listen to QA team. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #810 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #809) > (In reply to Marcel de Rooy from comment #808) > > I rebased what we had. Didnt check yet. > > > > Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set > > this month? Would be handy to plan our actions now. > > +1 > > Time is sparse, but I'll try to make it work. Thanks Katrin. And the others? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #809 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #808) > I rebased what we had. Didnt check yet. > > Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set > this month? Would be handy to plan our actions now. +1 Time is sparse, but I'll try to make it work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #808 from Marcel de Rooy --- I rebased what we had. Didnt check yet. Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set this month? Would be handy to plan our actions now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #807 from Marcel de Rooy --- Created attachment 129319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129319=edit Bug 19532: (QA follow-up) Enable XSLT statuses translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126580|0 |1 is obsolete|| --- Comment #806 from Marcel de Rooy --- Created attachment 129318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129318=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126579|0 |1 is obsolete|| --- Comment #805 from Marcel de Rooy --- Created attachment 129317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129317=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126578|0 |1 is obsolete|| --- Comment #804 from Marcel de Rooy --- Created attachment 129316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129316=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126577|0 |1 is obsolete|| --- Comment #803 from Marcel de Rooy --- Created attachment 129315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129315=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126576|0 |1 is obsolete|| --- Comment #802 from Marcel de Rooy --- Created attachment 129314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129314=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126575|0 |1 is obsolete|| --- Comment #801 from Marcel de Rooy --- Created attachment 129313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129313=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126574|0 |1 is obsolete|| --- Comment #800 from Marcel de Rooy --- Created attachment 129312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129312=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126573|0 |1 is obsolete|| --- Comment #799 from Marcel de Rooy --- Created attachment 129311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129311=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126572|0 |1 is obsolete|| --- Comment #798 from Marcel de Rooy --- Created attachment 129310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129310=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What|Removed |Added Attachment #126571|0 |1 is obsolete|| --- Comment #797 from Marcel de Rooy --- Created attachment 129309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129309=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
