[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

--- Comment #11 from Fridolin SOMERS  ---
(In reply to Mason James from comment #10)
> (In reply to Mason James from comment #9)
> > (In reply to Jonathan Druart from comment #7)
> > > Pushed to master for 17.11, thanks to everybody involved!
> > 
> > Fridolin, can we get this backported to 17.05.x please :)
> 
> fyi: it seems this patch can be skipped for 16.11.x

Thanks for pointing this.
Pushed to 17.05.x for v17.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

--- Comment #10 from Mason James  ---
(In reply to Mason James from comment #9)
> (In reply to Jonathan Druart from comment #7)
> > Pushed to master for 17.11, thanks to everybody involved!
> 
> Fridolin, can we get this backported to 17.05.x please :)

fyi: it seems this patch can be skipped for 16.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Mason James  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m, m...@kohaaloha.com

--- Comment #9 from Mason James  ---
(In reply to Jonathan Druart from comment #7)
> Pushed to master for 17.11, thanks to everybody involved!

Fridolin, can we get this backported to 17.05.x please :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Jonathan Druart  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #8 from Jonathan Druart  
---
*** Bug 19293 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69242|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 69328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69328=edit
Bug 19596 - Don't try to get hold or items count for non-existent biblios

Patch applies and works as expected.

Signed-off-by: Dilan Johnpullé 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #69047|0   |1
is obsolete||

--- Comment #5 from Dilan Johnpullé  ---
Created attachment 69242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69242=edit
Bug 19596 - Don't try to get hold or items count for non-existent biblios

Patch applies and works as expected.
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

--- Comment #4 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #2)
> Reading the changes, there is this line 2 lines before:
> my $cnt_subscriptions = $biblio->subscriptions->count;
> I guess it will explode as well

Good call, I was debugging from 17.05 - the first patch without the added line
will be needed there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Nick Clemens  changed:

   What|Removed |Added

  Attachment #69043|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 69047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69047=edit
Bug 19596 - Don't try to get hold or items count for non-existent biblios

To test:
1 - Create some orders
2 - Delete the bibs (or NULL biblionumber from DB)
3 - Try to recieve some orders
4 - Internal server error
5 - Apply patch
6 - Things should work


Current status: Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
Reading the changes, there is this line 2 lines before:
my $cnt_subscriptions = $biblio->subscriptions->count;
I guess it will explode as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Nick Clemens  changed:

   What|Removed |Added

   Severity|normal  |major
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 Depends on||18256, 17631


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631
[Bug 17631] Koha::Biblio - Remove GetHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256
[Bug 18256] Koha::Biblio - Remove GetItemsCount
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

--- Comment #1 from Nick Clemens  ---
Created attachment 69043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69043=edit
Bug 19596 - Don't try to get hold or items count for non-existent biblios

To test:
1 - Create some orders
2 - Delete the bibs (or NULL biblionumber from DB)
3 - Try to recieve some orders
4 - Internal server error
5 - Apply patch
6 - Things should work

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/