[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Blocks||22904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22904 [Bug 22904] Untranslatable strings in members-menu.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Blocks||21813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 [Bug 21813] In-page JavaScript causes error on patron entry page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Fridolin SOMERS changed: What|Removed |Added Blocks||20805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 [Bug 20805] Update child to adult patron process broken on several patron-related pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #29 from Owen Leonard --- (In reply to Jonathan Druart from comment #27) > I have found a problem: > circ/circulation.pl, search for a patron, I get: "ReferenceError: $ is not > defined" Should have been fixed by Bug 20221, "Fix for JavaScript error during checkout patron search." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Blocks||20498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 [Bug 20498] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #28 from Jonathan Druart --- Something else: code has been moved to members-menu.js but this file is not used anywhere. The regression I found is: Edit a patron and open the form in the header [+] => It does not display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Jonathan Druart changed: What|Removed |Added Keywords|Academy |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Blocks||20221 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 [Bug 20221] Fix for JavaScript error during checkout or holds patron search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20220 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20220 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #27 from Jonathan Druart --- I have found a problem: circ/circulation.pl, search for a patron, I get: "ReferenceError: $ is not defined" circulation.tt includes circ-patron-search-results.inc which has JS inside (bug jQuery is not loaded yet) Please provide a follow-up here as soon as you can. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #26 from Jonathan Druart --- Last two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #25 from Jonathan Druart --- Created attachment 71677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71677&action=edit Bug 19641: (follow-up) Update circulation.tt too Fix bad merge conflict with bug 18403 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #24 from Jonathan Druart --- Created attachment 71676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71676&action=edit Bug 19641: (follow-up) Move patron templates to the footer Fix bad merge conflict with bug 12904 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #22 from Jonathan Druart --- Same for the brief view: Before: https://screenshots.firefox.com/62t0wbESsXjcuKaO/pro.kohadev.org After: https://screenshots.firefox.com/oAnGeNsYW9s3qvTv/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #21 from Jonathan Druart --- Before: https://screenshots.firefox.com/aiunxdJJDVm8KUyk/pro.kohadev.org After: https://screenshots.firefox.com/hNHmyPk4g8VNpj0C/pro.kohadev.org Why is it better? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #20 from Josef Moravec --- Created attachment 71292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71292&action=edit Bug 19641: (Follow-up) Fix update child menu option This follow-up corrects handling of clicks on the "Update child" menu option when the patron is an adult. Previously the click handler was conditionally added via template markup. This patch modifies it to use the data-tooltip attribute as an indicator that the option is disabled. To test, apply the patch and clear your browser cache if necessary. - Open an adult patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The menu item should be disabled, and should show a tooltip. - Clicking the menu item should do nothing. - Open a child patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The patron should be updated to an adult category. Signed-off-by: Josef Moravec https://bugs.koha-community.org/show_bug.cgi?id=19682 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #19 from Josef Moravec --- Created attachment 71291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71291&action=edit Bug 19641: (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett Signed-off-by: Josef Moravec https://bugs.koha-community.org/show_bug.cgi?id=19682 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #18 from Josef Moravec --- Created attachment 71290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71290&action=edit Bug 19641: (Follow-up) Update circulation.tt too This patch makes the same JS-to-footer changes to circulation.tt. Inclusion of this template in this bug is necessary because it includes members-toolbar.inc. To test, apply the patch and clear your browser cache if necessary. - Enter a patron card for checkout - Test any JavaScript-driven actions on the checkout page, for instance: - Select all/clear all controls - Datepicker/timepickers - Datatable sorting, columns configuration - Renewals, check-ins - Patron message interactions, print slip, and other toolbar actions - Checkout exports - Search to hold - Tab loading: Restrictions, Holds, Clubs Signed-off-by: Zoe Bennett Signed-off-by: Josef Moravec https://bugs.koha-community.org/show_bug.cgi?id=19682 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec changed: What|Removed |Added Attachment #70724|0 |1 is obsolete|| Attachment #70725|0 |1 is obsolete|| Attachment #70726|0 |1 is obsolete|| Attachment #70953|0 |1 is obsolete|| --- Comment #17 from Josef Moravec --- Created attachment 71289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71289&action=edit Bug 19641: Move patron templates to the footer This patch modifies the staff client patron module templates so that JavaScript is included in the footer instead of the header. This patch touches a lot of files because the changes are all interdependent, affecting a couple of module-wide include files. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Patrons -> Patrons home, patron search results -> Manage pending modification requests -> Patron detail page -> Edit patron -> Set guarantor -> Fines -> Account, Pay fines, Create manual invoice, Create manual credit -> Print receipts for different kinds of charges -> Routing lists -> Circulation history -> Holds history -> Notices -> Statistics -> Files -> Purchase suggestions -> Discharges -> Housebound -> Set permissions -> Change password -> Print summary, slips, and overdues -> Update child to adult patron type Patron toolbar and patron search bar operations should work correctly on all pages. This patch also updates the template for searching the Norwegian national patron database, but it has NOT been tested. Signed-off-by: Claire Gravely Signed-off-by: Zoe Bennett Signed-off-by: Josef Moravec https://bugs.koha-community.org/show_bug.cgi?id=19682 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #16 from Owen Leonard --- Created attachment 70953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70953&action=edit Bug 19641: Follow-up - Fix update child menu option This follow-up corrects handling of clicks on the "Update child" menu option when the patron is an adult. Previously the click handler was conditionally added via template markup. This patch modifies it to use the data-tooltip attribute as an indicator that the option is disabled. To test, apply the patch and clear your browser cache if necessary. - Open an adult patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The menu item should be disabled, and should show a tooltip. - Clicking the menu item should do nothing. - Open a child patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The patron should be updated to an adult category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Josef Moravec --- Sorry, one more thing: When a patron has adult category, the "Update child to adult patron" looks disabled, but you can click on it, you get a dialog asking you if you want to update the child, and if you click OK, there is internal server error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett changed: What|Removed |Added Attachment #70723|0 |1 is obsolete|| --- Comment #14 from Zoe Bennett --- Created attachment 70726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70726&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett Signed-off-by: Your Full Name Signed-off-by: Your Full Name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett changed: What|Removed |Added Attachment #70428|0 |1 is obsolete|| --- Comment #12 from Zoe Bennett --- Created attachment 70724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70724&action=edit Bug 19641: Move patron templates to the footer This patch modifies the staff client patron module templates so that JavaScript is included in the footer instead of the header. This patch touches a lot of files because the changes are all interdependent, affecting a couple of module-wide include files. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Patrons -> Patrons home, patron search results -> Manage pending modification requests -> Patron detail page -> Edit patron -> Set guarantor -> Fines -> Account, Pay fines, Create manual invoice, Create manual credit -> Print receipts for different kinds of charges -> Routing lists -> Circulation history -> Holds history -> Notices -> Statistics -> Files -> Purchase suggestions -> Discharges -> Housebound -> Set permissions -> Change password -> Print summary, slips, and overdues -> Update child to adult patron type Patron toolbar and patron search bar operations should work correctly on all pages. This patch also updates the template for searching the Norwegian national patron database, but it has NOT been tested. Signed-off-by: Claire Gravely Signed-off-by: Your Full Name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett changed: What|Removed |Added Attachment #70429|0 |1 is obsolete|| --- Comment #13 from Zoe Bennett --- Created attachment 70725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70725&action=edit Bug 19641 (Follow-up) Update circulation.tt too This patch makes the same JS-to-footer changes to circulation.tt. Inclusion of this template in this bug is necessary because it includes members-toolbar.inc. To test, apply the patch and clear your browser cache if necessary. - Enter a patron card for checkout - Test any JavaScript-driven actions on the checkout page, for instance: - Select all/clear all controls - Datepicker/timepickers - Datatable sorting, columns configuration - Renewals, check-ins - Patron message interactions, print slip, and other toolbar actions - Checkout exports - Search to hold - Tab loading: Restrictions, Holds, Clubs Signed-off-by: Your Full Name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett changed: What|Removed |Added Attachment #70720|0 |1 is obsolete|| --- Comment #11 from Zoe Bennett --- Created attachment 70723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70723&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett Signed-off-by: Your Full Name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett changed: What|Removed |Added Attachment #70433|0 |1 is obsolete|| --- Comment #10 from Zoe Bennett --- Created attachment 70720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70720&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Blocks||19982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Bug 19641 depends on bug 19603, which changed state. Bug 19603 Summary: Move admin templates JavaScript to the footer: Patrons and circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #9 from Owen Leonard --- Created attachment 70433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70433&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Blocks||19954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #8 from Owen Leonard --- Created attachment 70429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70429&action=edit Bug 19641 (Follow-up) Update circulation.tt too This patch makes the same JS-to-footer changes to circulation.tt. Inclusion of this template in this bug is necessary because it includes members-toolbar.inc. To test, apply the patch and clear your browser cache if necessary. - Enter a patron card for checkout - Test any JavaScript-driven actions on the checkout page, for instance: - Select all/clear all controls - Datepicker/timepickers - Datatable sorting, columns configuration - Renewals, check-ins - Patron message interactions, print slip, and other toolbar actions - Checkout exports - Search to hold - Tab loading: Restrictions, Holds, Clubs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Attachment #69415|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 70428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70428&action=edit Bug 19641: Move patron templates to the footer This patch modifies the staff client patron module templates so that JavaScript is included in the footer instead of the header. This patch touches a lot of files because the changes are all interdependent, affecting a couple of module-wide include files. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Patrons -> Patrons home, patron search results -> Manage pending modification requests -> Patron detail page -> Edit patron -> Set guarantor -> Fines -> Account, Pay fines, Create manual invoice, Create manual credit -> Print receipts for different kinds of charges -> Routing lists -> Circulation history -> Holds history -> Notices -> Statistics -> Files -> Purchase suggestions -> Discharges -> Housebound -> Set permissions -> Change password -> Print summary, slips, and overdues -> Update child to adult patron type Patron toolbar and patron search bar operations should work correctly on all pages. This patch also updates the template for searching the Norwegian national patron database, but it has NOT been tested. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Depends on||19921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 [Bug 19921] Error when updating child to adult patron on system with only one adult patron category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #6 from Owen Leonard --- (In reply to Josef Moravec from comment #4) > Few buttons in patron toolbar on checkouts screen does not work - > circulation.tt is not part of this patch and so does not include > members-menu.js. I think you will fix this bug 19728, true? I've marked 19728 as a duplicate of this bug and will submit a follow-up that includes circulation.tt and circulation_batch_checkouts.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #5 from Owen Leonard --- *** Bug 19728 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com Status|Signed Off |Failed QA --- Comment #4 from Josef Moravec --- Hi Owen, looks good, but few thinks: So, if I want to update child to adult, and have more patron categories for adults, than I should see the form for choosing one of them, but I get blank page... Also the javascript function confirm_updatechild is defined twice: in members-menu.js and update-child.tt. Few buttons in patron toolbar on checkouts screen does not work - circulation.tt is not part of this patch and so does not include members-menu.js. I think you will fix this bug 19728, true? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- One of the dependencies is not in the QA queue yet, moving to BLOCKED for now, please move back once dependencies have been sorted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Bug 19641 depends on bug 19594, which changed state. Bug 19594 Summary: Move admin templates JavaScript to the footer: MARC-related https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Depends on||19594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 [Bug 19594] Move admin templates JavaScript to the footer: MARC-related -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Summary|Move patron templates to|Move patron templates |the footer |JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
