[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772
Bug 19772 depends on bug 17698, which changed state.

Bug 17698 Summary: Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|14224   |17698

--- Comment #8 from Katrin Fischer  ---
(In reply to Aleisha Amohia from comment #7)
> (In reply to Katrin Fischer from comment #6)
> > Could there be a case where a library wants to activate the feature, but use
> > it without email? We have some cases like the suggestions emails where you
> > just delete the notice in that case. Maybe we could just adapt the text a
> > little and remove the error/warning? Making the options dependent seems more
> > hassle.
> 
> I'm still working on the patch for Bug 17698 where the checkout notes will
> be shown on the staff dashboard, similar to how patron modifications are
> shown. I could add a patch to this bug that depends on 17698 where, if no
> notice is defined, it will not try to send an email and instead just show
> the note on the staff dashboard? hope that makes sense.

Yep, makes sense to me! I have taken a look on bug 17698 and it looks
promising. Linking both reports now.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
[Bug 14224] patron notes about item shown at check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
[Bug 17698] Make patron notes show up on staff dashboard
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

--- Comment #7 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #6)
> Could there be a case where a library wants to activate the feature, but use
> it without email? We have some cases like the suggestions emails where you
> just delete the notice in that case. Maybe we could just adapt the text a
> little and remove the error/warning? Making the options dependent seems more
> hassle.

I'm still working on the patch for Bug 17698 where the checkout notes will be
shown on the staff dashboard, similar to how patron modifications are shown. I
could add a patch to this bug that depends on 17698 where, if no notice is
defined, it will not try to send an email and instead just show the note on the
staff dashboard? hope that makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

--- Comment #6 from Katrin Fischer  ---
Could there be a case where a library wants to activate the feature, but use it
without email? We have some cases like the suggestions emails where you just
delete the notice in that case. Maybe we could just adapt the text a little and
remove the error/warning? Making the options dependent seems more hassle.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

--- Comment #5 from Aleisha Amohia  ---
Hi Jonathan,

Sorry I think I'm understanding the problem now. I'll make a fix where the
Checkout Notes feature can't be enabled unless the library also has a
CHECKOUT_NOTE notice configured. Patch to come soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

Jonathan Druart  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED
   Severity|major   |normal

--- Comment #4 from Jonathan Druart  
---
Maybe we should disable the feature if the notice template is not configured.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED

--- Comment #3 from Jonathan Druart  
---
Aleisha, yes it is what I describe :)

The message says "everything is ok and sent" whereas the email has not been
sent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

Katrin Fischer  changed:

   What|Removed |Added

Summary|Wrong success message if|Wrong success message if
   |PATRON_NOTE is not defined  |CHECKOUT_NOTE is not
   ||defined
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/