subject:"\[Koha\-bugs\] \[Bug 19817\] Merge local and online documentations"

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=2326

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22687


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22687
[Bug 22687] Type in Koha::Manual breaks Portuguese links
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #113 from Martin Renvoize  ---
See bug 22687

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #112 from Martin Renvoize  ---
This should really be added as a new bug Humberto, otherwise it's extremely
easy for the maintenance team to miss it.

I'll split it off for you this time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #111 from Humberto Chula  ---
Created attachment 87238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87238=edit
Fix Portuguese manual link

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-03-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

aplicacoes.d...@cm-portimao.pt  changed:

   What|Removed |Added

 CC||aplicacoes.dmsi@cm-portimao
   ||.pt
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #110 from aplicacoes.d...@cm-portimao.pt 
 ---
Setting KohaManualBaseURL to https://koha-community.org/manual and 
using user interface language pt~PT, the help link is redirected (for example)
to https://koha-community.org/manual/18.11/pt_BZ/html/systempreferences.html
displaying an error page.

I guess its related with a typo on line 22 in the file Manual.pm 
22my @available_languages = qw( en ar cs es fr it pt_BZ tz zh_TW );

Tested replacing the value pt_BZ by pt_BR and the link now works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7920

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-10-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||Great strides have been
  release notes||taken to improve Koha's
   ||online documentation. This
   ||enhancement removes the
   ||outdated local help system
   ||from the software, opting
   ||instead to contextually
   ||link to the well maintained
   ||online manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-10-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||21481


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481
[Bug 21481] Translation tool still references to help templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-10-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21483


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21483
[Bug 21483] Translate script displays an error about missing "help" directory
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-09-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #109 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #108)
> Created attachment 78953 [details] [review]
> Bug 19817: (follow-up) Remove local help files + edit help feature
> 
> I have no idea what happened but RM did not rebase that one correctly
> before pushing it ;)

What happened = The RM goofed

Follow-up pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-09-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #108 from Jonathan Druart  
---
Created attachment 78953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78953=edit
Bug 19817: (follow-up) Remove local help files + edit help feature

I have no idea what happened but RM did not rebase that one correctly
before pushing it ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-09-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #107 from Martin Renvoize  ---
New feature, this will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-09-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #106 from Nick Clemens  ---
Awesome work all! 

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77798|0   |1
is obsolete||

--- Comment #102 from Katrin Fischer  ---
Created attachment 77948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77948=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #105 from Katrin Fischer  ---
Created attachment 77951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77951=edit
Bug 19817: (QA follow-up) Add German manual and fix system preference help
files

- German language manuals were added since this patch was started
- The structure of the manual was changed slightly, system
  preferences were moved into their own chapter

To test:
- Test help files display correctly for system preferences display correctly
  Note: Local use uses a different page than the other tabs
- Test German shows up as option in KohaManualLanguage and links
  correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77797|0   |1
is obsolete||

--- Comment #101 from Katrin Fischer  ---
Created attachment 77947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77947=edit
Bug 19817: Open the manual in a new window, not a popup

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77799|0   |1
is obsolete||

--- Comment #103 from Katrin Fischer  ---
Created attachment 77949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77949=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77932|0   |1
is obsolete||

--- Comment #104 from Katrin Fischer  ---
Created attachment 77950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77950=edit
Bug 19817: Remove numbering from chapter file names

See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8
Remove numbering from chapter file names
from koha-manual

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77793|0   |1
is obsolete||

--- Comment #98 from Katrin Fischer  ---
Created attachment 77944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77944=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77795|0   |1
is obsolete||

--- Comment #100 from Katrin Fischer  ---
Created attachment 77946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77946=edit
Bug 19817: Add pref KohaManualLanguage

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77792|0   |1
is obsolete||

--- Comment #97 from Katrin Fischer  ---
Created attachment 77943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77943=edit
Bug 19817: Remove local help files + edit help feature

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77794|0   |1
is obsolete||

--- Comment #99 from Katrin Fischer  ---
Created attachment 77945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77945=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77791|0   |1
is obsolete||

--- Comment #96 from Katrin Fischer  ---
Created attachment 77942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77942=edit
Bug 19817: Redirect to the online manual

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #95 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #94)
> (In reply to Katrin Fischer from comment #92)
> > Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How
> > to fix? CPAN?
> 
> I guess so, yes. But for sure you get it against master as well, it's not
> related with those patches.

I know it's not related - but this patch set changes the test and the failure
keeps me from testing that part. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #94 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #92)
> Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How
> to fix? CPAN?

I guess so, yes. But for sure you get it against master as well, it's not
related with those patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #93 from Jonathan Druart  
---
Created attachment 77932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77932=edit
Bug 19817: Remove numbering from chapter file names

See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8
Remove numbering from chapter file names
from koha-manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #92 from Katrin Fischer  ---
Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How to
fix? CPAN?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #91 from Katrin Fischer  ---
There is something not quite right with the default URL and mappings. We have
since removed the chapter numbers from the file names in Sphinx, but the
patches seem to link to an outdated version of the manual:

https://koha-community.org/manual/18.05/en/html/09_acquisitions.html#acquisition-searches

vs correct:

https://koha-community.org/manual/18.05/en/html/acquisitions.html#acquisition-searches

Have to stop working on this for now, hope to be back later today. If you beat
me to fixing this. I'd not be unhappy about it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #90 from Martin Renvoize  ---
All seems to work for me, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #76157|0   |1
is obsolete||

--- Comment #88 from Martin Renvoize  ---
Created attachment 77798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77798=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #76155|0   |1
is obsolete||

--- Comment #86 from Martin Renvoize  ---
Created attachment 77795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77795=edit
Bug 19817: Add pref KohaManualLanguage

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #76153|0   |1
is obsolete||

--- Comment #84 from Martin Renvoize  ---
Created attachment 77793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77793=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #76156|0   |1
is obsolete||

--- Comment #87 from Martin Renvoize  ---
Created attachment 77797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77797=edit
Bug 19817: Open the manual in a new window, not a popup

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #76158|0   |1
is obsolete||

--- Comment #89 from Martin Renvoize  ---
Created attachment 77799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77799=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #76154|0   |1
is obsolete||

--- Comment #85 from Martin Renvoize  ---
Created attachment 77794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77794=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #76152|0   |1
is obsolete||

--- Comment #83 from Martin Renvoize  ---
Created attachment 77792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77792=edit
Bug 19817: Remove local help files + edit help feature

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #76151|0   |1
is obsolete||

--- Comment #82 from Martin Renvoize  ---
Created attachment 77791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77791=edit
Bug 19817: Redirect to the online manual

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-08-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #81 from Martin Renvoize  ---
*** Bug 5 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #78 from Jonathan Druart  
---
Created attachment 76156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76156=edit
Bug 19817: Open the manual in a new window, not a popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #80 from Jonathan Druart  
---
Created attachment 76158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76158=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #79 from Jonathan Druart  
---
Created attachment 76157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76157=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #77 from Jonathan Druart  
---
Created attachment 76155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76155=edit
Bug 19817: Add pref KohaManualLanguage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #75 from Jonathan Druart  
---
Created attachment 76153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76153=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #76 from Jonathan Druart  
---
Created attachment 76154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76154=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #74 from Jonathan Druart  
---
Created attachment 76152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76152=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75370|0   |1
is obsolete||
  Attachment #75371|0   |1
is obsolete||
  Attachment #75372|0   |1
is obsolete||
  Attachment #75373|0   |1
is obsolete||
  Attachment #75374|0   |1
is obsolete||
  Attachment #75375|0   |1
is obsolete||
  Attachment #75376|0   |1
is obsolete||
  Attachment #75377|0   |1
is obsolete||

--- Comment #73 from Jonathan Druart  
---
Created attachment 76151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76151=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #72 from Jonathan Druart  
---
(In reply to Caroline Cyr La Rose from comment #71)
> I had a bit of trouble applying the patch. I had to add member-flags.tt and
> then continue applying the patch. I don't know if that's normal or not.

Yes, conflict. I am going to re-attached a rebased version of these patches.

> I went to Global system preferences and clicked on the tab for circulation.
> When I clicked help, the manual was at the beginning of the sysprefs
> section. I don't know if it's possible at all to point to the right
> sub-section? It's just that are so many system preferences...

It should be the same behaviour as prior to the patch. We can imagine a link
close to each pref to point to the dedicated section of the manual.
TODO later ;)

> My KohaManualLanguage is on Arabic by default. I'm guessing it's the first
> language in the list, but if I don't change it will this be the default?
> Should we put English by default instead of Arabic?

I guess you did not execute the updatedatabase.pl script. The default value is
"en".

> I also don't see the edit button mentioned in comment 7. Was that
> implemented or just an idea for a future development? It could be a second
> patch. People don't currently have the ability to modify from the staff
> interface, so it wouldn't necessarily be a step back. More advanced users
> can still use their own help files.

The original plan was to provide a full help system, local editing (on top of
git repository), etc.
I have asked several time on the mailing lists and during IRC meetings to get
feedbacks and ideas. I did not get answers and I am no longer willing to
provide such enhancements. Maybe later...

> I wasn't able to test switching languages because my master is only
> installed in English.

You can install a couple with:
  sudo koha-translate --install fr-CA --dev kohadev
  sudo koha-translate --install it-IT --dev kohadev

> It's a great development! It will be much easier to translate, no need to
> translate the help file, just the manual. It will also be more uniform.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #71 from Caroline Cyr La Rose  ---
I had a bit of trouble applying the patch. I had to add member-flags.tt and
then continue applying the patch. I don't know if that's normal or not.

I went to Global system preferences and clicked on the tab for circulation.
When I clicked help, the manual was at the beginning of the sysprefs section. I
don't know if it's possible at all to point to the right sub-section? It's just
that are so many system preferences...

My KohaManualLanguage is on Arabic by default. I'm guessing it's the first
language in the list, but if I don't change it will this be the default? Should
we put English by default instead of Arabic?

I also don't see the edit button mentioned in comment 7. Was that implemented
or just an idea for a future development? It could be a second patch. People
don't currently have the ability to modify from the staff interface, so it
wouldn't necessarily be a step back. More advanced users can still use their
own help files.

I wasn't able to test switching languages because my master is only installed
in English.

It's a great development! It will be much easier to translate, no need to
translate the help file, just the manual. It will also be more uniform.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
Bug 19817 depends on bug 20706, which changed state.

Bug 20706 Summary: Fix links to help files for changed file structure (removed 
numbering on files)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #70 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #69)
> Is there more of a test plan than "click the help link on a bunch of pages?"

Yes, definitely.
This change is more a philosophical changes, we are going to remove the local
manual.

To test the whole patchset you will need to play with KohaManualBaseURL and
KohaManualLanguage and make sure the links are still working and redirect to
the correct url.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Owen Leonard  changed:

   What|Removed |Added

 CC|oleon...@myacpl.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-31 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #69 from Owen Leonard  ---
Is there more of a test plan than "click the help link on a bunch of pages?"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=20706   |
 Depends on||20706

--- Comment #68 from Jonathan Druart  
---
Rebased on top of bug 20706.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706
[Bug 20706] Fix links to help files for changed file structure (removed
numbering on files)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #66 from Jonathan Druart  
---
Created attachment 75376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75376=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #67 from Jonathan Druart  
---
Created attachment 75377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75377=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #64 from Jonathan Druart  
---
Created attachment 75374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75374=edit
Bug 19817: Add pref KohaManualLanguage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #65 from Jonathan Druart  
---
Created attachment 75375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75375=edit
Bug 19817: Open the manual in a new window, not a popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #63 from Jonathan Druart  
---
Created attachment 75373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75373=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #62 from Jonathan Druart  
---
Created attachment 75372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75372=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #61 from Jonathan Druart  
---
Created attachment 75371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75371=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74644|0   |1
is obsolete||
  Attachment #74645|0   |1
is obsolete||
  Attachment #74646|0   |1
is obsolete||
  Attachment #74647|0   |1
is obsolete||
  Attachment #74648|0   |1
is obsolete||
  Attachment #74649|0   |1
is obsolete||
  Attachment #74650|0   |1
is obsolete||
  Attachment #74651|0   |1
is obsolete||

--- Comment #60 from Jonathan Druart  
---
Created attachment 75370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75370=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20706

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #55 from Jonathan Druart  
---
Created attachment 74647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74647=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #59 from Jonathan Druart  
---
Created attachment 74651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74651=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #56 from Jonathan Druart  
---
Created attachment 74648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74648=edit
Bug 19817: Add pref KohaManualLanguage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #58 from Jonathan Druart  
---
Created attachment 74650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74650=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #57 from Jonathan Druart  
---
Created attachment 74649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74649=edit
Bug 19817: Open the manual in a new window, not a popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74567|0   |1
is obsolete||
  Attachment #74568|0   |1
is obsolete||
  Attachment #74569|0   |1
is obsolete||
  Attachment #74570|0   |1
is obsolete||
  Attachment #74571|0   |1
is obsolete||
  Attachment #74572|0   |1
is obsolete||
  Attachment #74573|0   |1
is obsolete||
  Attachment #74574|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart  
---
Created attachment 74644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74644=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #53 from Jonathan Druart  
---
Created attachment 74645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74645=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #54 from Jonathan Druart  
---
Created attachment 74646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74646=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #51 from Jonathan Druart  
---
To me it does not make sense to make it a free text.
We could retrieve the available languages from the syspref options, it will
avoid to have it hardcoded in the code. And then a quick SQL query will allow
to extend the list.
I do not think it should be a blocker anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #50 from Katrin Fischer  ---
My idea was to use the pref as a white list of existing manuals, because I was
not sure we can tell and not have it end up on an error page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #49 from Katrin Fischer  ---
What if the selected language doesn't have an existing manual?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #48 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #39)
> 3) 
> >> - choice vs multiple in the added KohaManualLanguage sys pref
> 
> >It's a choice indeed.
> 
> Hm, what I was thinking about was a multiple indeed. We usually have at
> least German and English installed for staff, often Spanish and French now
> too. I would like to use the pref to indicate existing manuals for staff
> activated languages. So when I open the help and it matches one of the
> selected languages I get the right language manual. Makes sense?

The pref is the default value.

If the pref is set to English and the interface is in Spanish, the manual will
be in Spanish. If the interface is in Esperanto, the manual will be in English
(the manual is not translated in Esperanto, yet).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #47 from Jonathan Druart  
---
Created attachment 74574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74574=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #43 from Jonathan Druart  
---
Created attachment 74570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74570=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #45 from Jonathan Druart  
---
Created attachment 74572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74572=edit
Bug 19817: Open the manual in a new window, not a popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #44 from Jonathan Druart  
---
Created attachment 74571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74571=edit
Bug 19817: Add pref KohaManualLanguage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #41 from Jonathan Druart  
---
Created attachment 74568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74568=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #46 from Jonathan Druart  
---
Created attachment 74573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74573=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #42 from Jonathan Druart  
---
Created attachment 74569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74569=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73931|0   |1
is obsolete||
  Attachment #73932|0   |1
is obsolete||
  Attachment #73933|0   |1
is obsolete||
  Attachment #73934|0   |1
is obsolete||
  Attachment #73935|0   |1
is obsolete||
  Attachment #73936|0   |1
is obsolete||
  Attachment #73937|0   |1
is obsolete||
  Attachment #73938|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart  
---
Created attachment 74567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74567=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #39 from Katrin Fischer  ---
The patches don't apply right now - can you take a look? Looking at the last
comments:

1) Removing the po files on release date would make sense to me.

2)
>> - postfix slash the default URL creates a // in the URL.
>>   remove the '/' in the URL building in Koha::Manual?
>>   build smarter?

I think we expect people to get it right for BaseURLs already. so no need to be
more strict here. (Do not enter trailing slash)

3) 
>> - choice vs multiple in the added KohaManualLanguage sys pref

>It's a choice indeed.

Hm, what I was thinking about was a multiple indeed. We usually have at least
German and English installed for staff, often Spanish and French now too. I
would like to use the pref to indicate existing manuals for staff activated
languages. So when I open the help and it matches one of the selected languages
I get the right language manual. Makes sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #38 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #29)
> Preliminary testing was generally positive. Though, I think these points
> should be discussed, if not addressed, before considering sign off.

Thanks for catching those things. I have marked as obsolete the other comments
(they are the verbose version of the next 5 lines)

> - https vs http in the urls used.

Yes, in the meanwhile I have asked rangi to enable https on the manual (was not
there before).

> - choice vs multiple in the added KohaManualLanguage sys pref

It's a choice indeed.

> - help.pl removed from 00-strict.t

Re-added

> - postfix slash the default URL creates a // in the URL.
>   remove the '/' in the URL building in Koha::Manual?
>   build smarter?

I do not understand what you suggest here.

> kshell
> cd misc/translator
> for i in `ls po | cut -f1-2 -d'-' | sed -e "s#-opac##g" | sed -e
> "s#-pref.po##g" | sed -e "s#-staff##g" | sed -e "s#-marc##g" | sort -u`; do
> echo $i;perl translate install $i;done
> -- noisy! Though, I suspect correct.
> perhaps help po files need to be deleted too?

I do not think so, should be deleted on releasing (there are certainly other
things to do in the release scripts).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #35 from Jonathan Druart  
---
Created attachment 73936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73936=edit
Bug 19817: Open the manual in a new window, not a popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #36 from Jonathan Druart  
---
Created attachment 73937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73937=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #37 from Jonathan Druart  
---
Created attachment 73938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73938=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #34 from Jonathan Druart  
---
Created attachment 73935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73935=edit
Bug 19817: Add pref KohaManualLanguage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #33 from Jonathan Druart  
---
Created attachment 73934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73934=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #32 from Jonathan Druart  
---
Created attachment 73933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73933=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #31 from Jonathan Druart  
---
Created attachment 73932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73932=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73523|0   |1
is obsolete||
  Attachment #73524|0   |1
is obsolete||
  Attachment #73525|0   |1
is obsolete||
  Attachment #73526|0   |1
is obsolete||
  Attachment #73651|0   |1
is obsolete||
  Attachment #73652|0   |1
is obsolete||
  Attachment #73877|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart  
---
Created attachment 73931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73931=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #29 from M. Tompsett  ---
Preliminary testing was generally positive. Though, I think these points should
be discussed, if not addressed, before considering sign off.

- https vs http in the urls used.
- choice vs multiple in the added KohaManualLanguage sys pref
- help.pl removed from 00-strict.t
- postfix slash the default URL creates a // in the URL.
  remove the '/' in the URL building in Koha::Manual?
  build smarter?

kshell
cd misc/translator
for i in `ls po | cut -f1-2 -d'-' | sed -e "s#-opac##g" | sed -e
"s#-pref.po##g" | sed -e "s#-staff##g" | sed -e "s#-marc##g" | sort -u`; do
echo $i;perl translate install $i;done
-- noisy! Though, I suspect correct.
perhaps help po files need to be deleted too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 134 matches

Mail list logo