[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15681

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #11 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46758|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 46856
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46856=edit
Bug 1983: Checkout: Hold repquest when checking out an item already on loan or
reserved

This patch allows to put a hold on an item that is already checked out or
reserved.

To test:

- Check out an item A
- Put a hold on an item B
- Verify that the staff user has permission to put holds
- Check out item A to a patron X
- Try to checkout item A to a patron Y
- Verify that you see underneath the buttons for Checkin/Checkout a link
  with following text: "Click here to place hold for [Patron X' name]"
- Verify that the link is stylable (div class circ-scheckoutplacehold)
- Verify that the link takes you to the page to place a hold on this biblio
  for patron Y
- Do the same for item B and verify that it works for reserved items as well.
- Repeat steps above for a patron who has restrictions, verify that the link
  does not appear
- Log in with a staff member who has no permission to place holds
- Repeat steps above for a patron without restrictions, verify that the link
  does not appear.

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Chris Cormack  changed:

   What|Removed |Added

  Attachment #46668|0   |1
is obsolete||

--- Comment #9 from Chris Cormack  ---
Created attachment 46758
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46758=edit
Bug 1983: Checkout: Hold repquest when checking out an item already on loan or
reserved

This patch allows to put a hold on an item that is already checked out or
reserved.

To test:

- Check out an item A
- Put a hold on an item B
- Verify that the staff user has permission to put holds
- Check out item A to a patron X
- Try to checkout item A to a patron Y
- Verify that you see underneath the buttons for Checkin/Checkout a link
  with following text: "Click here to place hold for [Patron X' name]"
- Verify that the link is stylable (div class circ-scheckoutplacehold)
- Verify that the link takes you to the page to place a hold on this biblio
  for patron Y
- Do the same for item B and verify that it works for reserved items as well.
- Repeat steps above for a patron who has restrictions, verify that the link
  does not appear
- Log in with a staff member who has no permission to place holds
- Repeat steps above for a patron without restrictions, verify that the link
  does not appear.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

--- Comment #7 from Marc Véron  ---
Created attachment 46668
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46668=edit
Bug 1983: Checkout: Hold repquest when checking out an item already on loan or
reserved

This patch allows to put a hold on an item that is already checked out or
reserved.

To test:

- Check out an item A
- Put a hold on an item B
- Verify that the staff user has permission to put holds
- Check out item A to a patron X
- Try to checkout item A to a patron Y
- Verify that you see underneath the buttons for Checkin/Checkout a link
  with following text: "Click here to place hold for [Patron X' name]"
- Verify that the link is stylable (div class circ-scheckoutplacehold)
- Verify that the link takes you to the page to place a hold on this biblio
  for patron Y
- Do the same for item B and verify that it works for reserved items as well.
- Repeat steps above for a patron who has restrictions, verify that the link
  does not appear
- Log in with a staff member who has no permission to place holds
- Repeat steps above for a patron without restrictions, verify that the link
  does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Marc Véron  changed:

   What|Removed |Added

  Attachment #45991|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Marc Véron  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #8 from Marc Véron  ---
I refactored the patch (more / changed conditions to display link, give the
link correct params). 

The patch will need a new sign-off.
See changed test plan on this patch.

Regarding link vs button: For more clarity, I decided for a link below the
buttons with a text including the patron's name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

--- Comment #5 from Jonathan Druart  
---
Comment on attachment 45991
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45991
Bug 1983: Checkout: Hold request when checking out an item already on loan or
reserved

Review of attachment 45991:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=1983=45991)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ +408,5 @@
>  
>  
> +[% IF ( RESERVE_WAITING ) || ( RESERVED ) || ( ISSUED_TO_ANOTHER ) %]
> +[%IF (CAN_user_reserveforothers_place_holds ) %]
> + href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% itembiblionumber 
> %]=x">Click here to place hold

What is this 'x'??
Why a link instead of a button?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|ve...@veron.ch
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Marc Véron  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #6 from Marc Véron  ---
Oh, there was something missing.
Switching bach to assigned.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

--- Comment #3 from Marc Véron  ---
Created attachment 45984
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45984=edit
Bug 1983: Checkout: Hold request when checking out an item already on loan or
reserved

This patch allows to put a hold on an item that is already checked out or
reserved.

To test:

- Check out an item A
- Put a hold on an item B
- Verify thath the staff user has permission to put holds
- Check out item A to a patron X
- Try to checkout item A to a patron Y
- Verify that you see near the buttons for Checkin/Checkout a link "Click here
to place hold"
- Verify that the link is stylable (span class circ-scheckoutplacehold)
- Verify that the link takes you to the page for placing holds as appropriate
- Do the same for item B and verify that it works for reserved items as well.
- Log in with a staff client who has no permission to place holds
- Repeat steps above, verify that the link does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Chris Cormack  changed:

   What|Removed |Added

  Attachment #45984|0   |1
is obsolete||

--- Comment #4 from Chris Cormack  ---
Created attachment 45991
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45991=edit
Bug 1983: Checkout: Hold request when checking out an item already on loan or
reserved

This patch allows to put a hold on an item that is already checked out or
reserved.

To test:

- Check out an item A
- Put a hold on an item B
- Verify thath the staff user has permission to put holds
- Check out item A to a patron X
- Try to checkout item A to a patron Y
- Verify that you see near the buttons for Checkin/Checkout a link "Click here
to place hold"
- Verify that the link is stylable (span class circ-scheckoutplacehold)
- Verify that the link takes you to the page for placing holds as appropriate
- Do the same for item B and verify that it works for reserved items as well.
- Log in with a staff client who has no permission to place holds
- Repeat steps above, verify that the link does not appear.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Described behaviour is not available in current versions, so this is still
valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/