[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #9 from Jonathan Druart --- Created attachment 70290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70290&action=edit Bug 19899: Restore Item floats feature - do not crash Error is "The method noreturn is not covered by tests!" caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn) the library must be the current library (from userenv). This behaviour is used in C4::Circulation::AddReturn On bug 18276 I assumed that the value was either holdingbranch or homebranch, and forgot it could be "noreturn" Test plan: Set Return policy to Item floats Check an item in => without this patch it explodes => With this patch applied it will check the item in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added Depends on||18276 --- Comment #8 from Jonathan Druart --- Certainly caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added Summary|Software error while check |Software error while check |in, The method noreturn is |in, The method noreturn is |not covered by tests! after |not covered by tests! |upgrade from 16.05 to 17.11 | Severity|normal |critical Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Version|17.11 |master --- Comment #7 from Jonathan Druart --- Ok I recreate the problem, it happens when "Return policy" is "Item floats" (value noreturn) in circ rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #6 from Jonathan Druart --- Do you have something else in the Koha log file? I will need the file and line number where the error occurs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #5 from Mohd Hafiz Yusoff --- Return from command lib/C4/Circulation.pm: noreturn: do not return, let item remain where checked in (floating collections) lib/C4/Circulation.pm:# if $hbr was "noreturn" or any other non-item table value, then it should 'float' (i.e. stay at this branch) intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [% IF ( default_returnbranch == 'noreturn' ) %] intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [% ELSIF ( branch_item_rule_loo.returnbranch == 'noreturn' ) %] intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: Item floats intranet/cgi-bin/installer/data/mysql/kohastructure.sql: `returnbranch` varchar(15) default NULL, -- the branch the item returns to (homebranch, holdingbranch, noreturn) man/man3/C4::Circulation.3pm: noreturn: do not return, let item remain where checked in (floating collections) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899
--- Comment #4 from Mohd Hafiz Yusoff ---
Fresh install koha using this instruction:
https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages
After install, I restore old database (from KOHA 16.05).
And then upgrade schema "koha-upgrade-schema {instance}"
Last reindex "koha-rebuild-zebra -v -f {instance}"
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|enhancement |normal --- Comment #3 from Jonathan Druart --- Hi Mohd, How did you install Koha? Are you sure it is not a customized version of Koha? What returns the following commands? cd /usr/share/koha; grep -r noreturn | grep -v translator I do not find any relevant occurrences of "noreturn" in our code that could produce such error. Do you have something else in the Koha log file? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #2 from Mohd Hafiz Yusoff --- Anybody can help? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Mohd Hafiz Yusoff changed: What|Removed |Added Summary|Software error while check |Software error while check |in, The method noreturn is |in, The method noreturn is |not covered by tests! |not covered by tests! after ||upgrade from 16.05 to 17.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #1 from Mohd Hafiz Yusoff --- Software Error while upgrade from KOHA 16.05 to 17.11. This error while check in and I got error message "The method noreturn is not covered by tests!" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
