[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/665
 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Documentation||Caroline Cyr La Rose
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||33060

--- Comment #23 from Katrin Fischer  ---
There are more of these, I've filed a separate bug and provided a patch:
Bug 33060 - Fix yes/no setting to 1/0 in system preference YAML files


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33060
[Bug 33060] Fix yes/no setting to 1/0 in system preference YAML files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #22 from Jonathan Druart  ---
+  yes: permanent_location
+  no: homebranch

This is wrong, it must be 1 and 0, no "yes" and "no".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #21 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #20 from Nick Clemens  ---
Created attachment 140071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140071=edit
Bug 20058: (QA follow-up) Simplify test code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #19 from Nick Clemens  ---
Created attachment 140070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140070=edit
Bug 20058: (QA follow-up) Add exec flag to install file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #18 from Nick Clemens  ---
Created attachment 140069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140069=edit
Bug 20058: Add tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Nick Clemens  changed:

   What|Removed |Added

 Attachment #138925|0   |1
is obsolete||
 Attachment #138926|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 140068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140068=edit
Bug 20058: Add option to send permanent_location as AQ in SIP response

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #16 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #15)
> Thanks for the explanation.. all works as described to signing off.  Over to
> Kyle for a final QA run :)
> 
> PS, whilst rebasing it to apply I moved the syspref into the SIP2 section
> for display.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #15 from Martin Renvoize  ---
Thanks for the explanation.. all works as described to signing off.  Over to
Kyle for a final QA run :)

PS, whilst rebasing it to apply I moved the syspref into the SIP2 section for
display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #125455|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 138926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138926=edit
Bug 20058: Add tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #125454|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 138925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138925=edit
Bug 20058: Add option to send permanent_location as AQ in SIP response

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #12 from Stefan Berndtsson  ---
The main difference for us, and the reason for making the patch in the first
place, is that our sorting is done in each machine based on CT (branchcode) and
AQ (permanent_location).

CT is only set when the item is being sent to another library, so we first sort
on that, and if it is not set, we sort on AQ for different destinations within
the same library.

Using CL is likely a functional way forward for sorting, but it moves the
sorting rules to the server, which is not something that's setup yet, so I
haven't looked into that here.

When we first wrote this patch (in 2018 or so), Koha did not produce CT, so AQ
was all we had. Now that Koha sets CT to homebranch when transferring, the
default behaviour of also setting AQ to the same thing seems a bit redundant.

The SIP name of the AQ field is "permanent location" (FID_PERM_LOCN), although
what that technically means is of course an interpretation.

To me, AQ and CL has two different meanings. One is information on the returned
item (AQ), one is instructions to a machine (CL).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #11 from Martin Renvoize  ---
Hmm, well bug 20517 uses the CL field for sorter, which from memory is what
sorters here use.. I'd have to look at the docs again to remind myself what AQ
is for, but from the code this looks reasonable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20517

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Katrin Fischer  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com,
   ||martin.renvoize@ptfs-europe
   ||.com
   Assignee|koha-b...@lists.koha-commun |stefan.berndts...@ub.gu.se
   |ity.org |

--- Comment #10 from Katrin Fischer  ---
A quick observation here:

1) I notice that the new system preference is added under Holds policy, I think
that doesn't fit well and should better bemoved to be under the new SIP2
heading.

2) As this is supposed to be used for sorting: there is now a configuration
option specific to sort bins with the SIP2SortBinMapping system preference, but
it's setting the CL field. Is this still required with this new development?

Also adding Kyle and Martin as they know SIP2 well, I am not sure if we don't
have a way to achieve that yet via the conf file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson  changed:

   What|Removed |Added

 Attachment #125366|0   |1
is obsolete||

--- Comment #9 from David Gustafsson  ---
Created attachment 125455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125455=edit
Bug 20058: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson  changed:

   What|Removed |Added

 Attachment #125364|0   |1
is obsolete||

--- Comment #8 from David Gustafsson  ---
Created attachment 125454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125454=edit
Bug 20058: Add option to send permanent_location as AQ in SIP response

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #7 from David Gustafsson  ---
Yes! Will fix this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
---
a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
+++
b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ -655,10 +655,19 @@ Circulation:
 - pref: StoreLastBorrower
   default: 0
   choices:
+-
   1: Store
   0: "Don't store"

This change is a mistake no ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson  changed:

   What|Removed |Added

 Attachment #125365|0   |1
is obsolete||

--- Comment #5 from David Gustafsson  ---
Created attachment 125366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125366=edit
Bug 20058: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||glask...@gmail.com

--- Comment #4 from David Gustafsson  ---
Rebased against master and added tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #3 from David Gustafsson  ---
Created attachment 125365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125365=edit
Bug 20058: Add tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson  changed:

   What|Removed |Added

  Attachment #70791|0   |1
is obsolete||

--- Comment #2 from David Gustafsson  ---
Created attachment 125364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125364=edit
Bug 20058: Add option to send permanent_location as AQ in SIP response

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #1 from Stefan Berndtsson  ---
Created attachment 70791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70791=edit
Add option to send permanent_location as AQ in SIP response

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/