[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72546|0   |1
is obsolete||

--- Comment #10 from M. Tompsett  ---
Comment on attachment 72546
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72546
Bug 20103: Remove Readonly::XS from PerlDependencies

Counter patch is better. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19735

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #9 from M. Tompsett  ---
(In reply to M. Tompsett from comment #8)
> please include the removal of Readonly::XS on the other bug.

It is, nevermind. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

--- Comment #8 from M. Tompsett  ---
If we don't want to remove Readonly::XS from the dependencies until after we
remove Readonly, then sign off patch 2 and rename this bug "Readonly::XS dies
before returning $VERSION" or something similar, and please include the removal
of Readonly::XS on the other bug.

If we wish to remove Readonly::XS from the dependencies, because more modern
versions of Perl (post 5.8) don't need it explicitly, as shown in comment #5,
then sign off patch 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73406|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 73407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73407=edit
Bug 20103: Readonly::XS is completely bogus post perl 5.8

A ha! Lie about who we are, and the module will return a version.

./koha_perl_deps.pl -a
-- before patch Readonly::XS is 0
-- after patch it has a version number.
run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

--- Comment #6 from M. Tompsett  ---
Created attachment 73406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73406=edit
Bug 20103: Readonly::XS is completely bogus post perl 5.8

This patch continues the whitelie that Readonly tells about
$XSokay, so that we don't worry people who try to install everything.

./koha_perl_deps.pl -a
-- before patch Readonly::XS is 0
-- after patch it's listed as 0.01 (the minimum version)
run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

--- Comment #5 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #4)
> I do not understand the quote like you.
> It says it is faster and we should not "use" it, in the sense we should not
> write
>   use Readonly::XS;
> but
>   use Readonly;
> instead.
> 
> To me it makes sense to keep it in the dependency list (until Readonly is
> removed, bug 16588).

>From Readonly.pm
 18 # These functions may be overridden by Readonly::XS, if installed.
 19 use vars qw/$XSokay/;# Set to true in Readonly::XS, if available
 20 
 21 # For perl 5.8.x or higher
 22 # These functions are exposed in perl 5.8.x (Thanks, Leon!)
 23 # They may be overridden by Readonly::XS, if installed on old perl versions
 24 if ($] < 5.008) {# 'Classic' perl
 25 *is_sv_readonly = sub ($) {0};
 26 *make_sv_readonly
 27 = sub ($) { die "make_sv_readonly called but not overridden" };
 28 
 29 # See if we can use the XS stuff.
 30 $Readonly::XS::MAGIC_COOKIE
 31 = "Do NOT use or require Readonly::XS unless you're me.";
 32 eval 'use Readonly::XS';
 33 }
 34 else {   # Modern perl doesn't need Readonly::XS
 35 *is_sv_readonly = sub ($) { Internals::SvREADONLY($_[0]) };
 36 *make_sv_readonly
 37 = sub ($) { Internals::SvREADONLY($_[0], 1) };
 38 $XSokay = 1; # We're using the new built-ins so this is a white lie
 39 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||tomasco...@gmail.com
 Status|Passed QA   |In Discussion

--- Comment #4 from Jonathan Druart  
---
I do not understand the quote like you.
It says it is faster and we should not "use" it, in the sense we should not
write
  use Readonly::XS;
but
  use Readonly;
instead.

To me it makes sense to keep it in the dependency list (until Readonly is
removed, bug 16588).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71071|0   |1
is obsolete||

--- Comment #2 from Marcel de Rooy  ---
Created attachment 72546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72546=edit
Bug 20103: Remove Readonly::XS from PerlDependencies

While having Readonly::XS is a good thing on slower systems
the CPAN page for Readonly says it isn't required to be
used directly, so we don't need to check for it.

Additionally, even reading /usr/share/perl5/Readonly.pm you
see "# Modern perl doesn't need Readonly::XS" on an if
statement checking for version 5.8! Koha requires 5.20
(see C4::Log::cronlogaction's use of caller).

TEST PLAN
-
Can you run a fresh install?
Does the about page list Readonly::XS? It shouldn't after the patch.
Run koha qa test tools

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #3 from Marcel de Rooy  ---
Combining SO+QA / trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16588

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

--- Comment #1 from M. Tompsett  ---
Created attachment 71071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71071=edit
Bug 20103: Remove Readonly::XS from PerlDependencies

While having Readonly::XS is a good thing on slower systems
the CPAN page for Readonly says it isn't required to be
used directly, so we don't need to check for it.

Additionally, even reading /usr/share/perl5/Readonly.pm you
see "# Modern perl doesn't need Readonly::XS" on an if
statement checking for version 5.8! Koha requires 5.20
(see C4::Log::cronlogaction's use of caller).

TEST PLAN
-
Can you run a fresh install?
Does the about page list Readonly::XS? It shouldn't after the patch.
Run koha qa test tools

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/