[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #21 from Katrin Fischer  ---
Hi Alex, could you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20119 - Ability to print claims for late orders
Applying: Bug 20119 - Add unit tests
error: sha1 information is lacking or useless (C4/Letters.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 20119 - Add unit tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-20119---Add-unit-tests-BTwZip.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18796

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Amit Gupta  changed:

   What|Removed |Added

 CC||amit.gupta@informaticsgloba
   ||l.com,
   ||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #20 from Alex Arnaud  ---
Patches rebased on master.
I attached a new one that add an option for updating claims count and claim
date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

--- Comment #19 from Alex Arnaud  ---
Created attachment 125825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125825=edit
Bug 20119: Add option to update claims count and claim date

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72945|0   |1
is obsolete||

--- Comment #18 from Alex Arnaud  ---
Created attachment 125824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125824=edit
Bug 20119 - Add unit tests

[2018-03-15] Rebased-by: Alex Arnaud 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72944|0   |1
is obsolete||

--- Comment #17 from Alex Arnaud  ---
Created attachment 125823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125823=edit
Bug 20119 - Ability to print claims for late orders

Test plan:

 - create a notice: module: claimacquisition, code: ACQCLAIM: transport:
   print
 - create at least a bookseller, basket and orders,
 - close the basket and change the closedate to make orders late,
 - go to cgi-bin/koha/acqui/lateorders.pl,
 - select one or more order(s) to claim and click on "Print claim",
 - check the pdf downloaded

[2018-03-15] Rebased-by: Alex Arnaud 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

--- Comment #16 from Séverine Queune  ---
(In reply to Katrin Fischer from comment #15)
> Could we add a checkbox or a confirmation question? That way the library
> could decide when the count is updated.

That's a good idea !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20125
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #15 from Katrin Fischer  ---
Could we add a checkbox or a confirmation question? That way the library could
decide when the count is updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Séverine Queune  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #14 from Séverine Queune  ---
The current patch (that works perfectly for pdf export) doesn't update the
claims count nor the claimed date.
Is it a behaviour we want to keep ? In that case, as the claims count is update
only when emailing the vendor, there is no way in Koha to trace the "paper
claims".
But, in the other hand, there is no garanty that the claim pdf will be send to
the vendor, or the date of sending can be different of the one in Koha so it's
not necesarly a good idea to update these informations at the printing moment.
I don't know which behaviour is better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Séverine Queune  changed:

   What|Removed |Added

  Attachment #72929|0   |1
is obsolete||

--- Comment #13 from Séverine Queune  ---
Created attachment 72945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72945=edit
Bug 20119 - Add unit tests

[2018-03-15] Rebased-by: Alex Arnaud 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Séverine Queune  changed:

   What|Removed |Added

  Attachment #72928|0   |1
is obsolete||

--- Comment #12 from Séverine Queune  ---
Created attachment 72944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72944=edit
Bug 20119 - Ability to print claims for late orders

Test plan:

 - create a notice: module: claimacquisition, code: ACQCLAIM: transport:
   print
 - create at least a bookseller, basket and orders,
 - close the basket and change the closedate to make orders late,
 - go to cgi-bin/koha/acqui/lateorders.pl,
 - select one or more order(s) to claim and click on "Print claim",
 - check the pdf downloaded

[2018-03-15] Rebased-by: Alex Arnaud 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #71150|0   |1
is obsolete||

--- Comment #10 from Alex Arnaud  ---
Created attachment 72928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72928=edit
Bug 20119 - Ability to print claims for late orders

Test plan:

 - create a notice: module: claimacquisition, code: ACQCLAIM: transport:
   print
 - create at least a bookseller, basket and orders,
 - close the basket and change the closedate to make orders late,
 - go to cgi-bin/koha/acqui/lateorders.pl,
 - select one or more order(s) to claim and click on "Print claim",
 - check the pdf downloaded

[2018-03-15] Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #71151|0   |1
is obsolete||

--- Comment #11 from Alex Arnaud  ---
Created attachment 72929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72929=edit
Bug 20119 - Add unit tests

[2018-03-15] Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #9 from Séverine Queune  ---
Applying: Bug 20119 - Ability to print claims for late orders
Using index info to reconstruct a base tree...
M   C4/Letters.pm
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
Auto-merging C4/Letters.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 20119 - Ability to print claims for late orders
The copy of the patch that failed is found in:
   /var/repositories/koha/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-20119---Ability-to-print-claims-for-late-order-II3tjp.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #71106|0   |1
is obsolete||

--- Comment #7 from Alex Arnaud  ---
Created attachment 71150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71150=edit
Bug 20119 - Ability to print claims for late orders

Test plan:

 - create a notice: module: claimacquisition, code: ACQCLAIM: transport:
   print
 - create at least a bookseller, basket and orders,
 - close the basket and change the closedate to make orders late,
 - go to cgi-bin/koha/acqui/lateorders.pl,
 - select one or more order(s) to claim and click on "Print claim",
 - check the pdf downloaded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

--- Comment #8 from Alex Arnaud  ---
Created attachment 71151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71151=edit
Bug 20119 - Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20119] Ability to print claims for late orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Alex Arnaud  changed:

   What|Removed |Added

Summary|Improve orders claiming |Ability to print claims for
   ||late orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/