[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Jonathan Druartchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 --- Comment #3 from Katrin Fischer--- Created attachment 71696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71696=edit k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Katrin Fischerchanged: What|Removed |Added Attachment #71658|0 |1 is obsolete|| Attachment #71696|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 71697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71697=edit Bug 20205: Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Owen Leonardchanged: What|Removed |Added Attachment #71641|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 71658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71658=edit Bug 20205 - Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Magnus Engerchanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 --- Comment #1 from Magnus Enger--- Created attachment 71641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71641=edit Bug 20205 - Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/