[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #297 from Kyle M Hall --- Created attachment 128737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128737=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #296 from Kyle M Hall --- Created attachment 128736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128736=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #295 from Kyle M Hall --- Created attachment 128735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128735=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What|Removed |Added Attachment #124286|0 |1 is obsolete|| Attachment #124287|0 |1 is obsolete|| Attachment #124288|0 |1 is obsolete|| Attachment #124289|0 |1 is obsolete|| Attachment #124290|0 |1 is obsolete|| Attachment #124291|0 |1 is obsolete|| Attachment #124292|0 |1 is obsolete|| Attachment #124293|0 |1 is obsolete|| Attachment #124294|0 |1 is obsolete|| Attachment #124295|0 |1 is obsolete|| Attachment #124296|0 |1 is obsolete|| Attachment #124297|0 |1 is obsolete|| Attachment #124298|0 |1 is obsolete|| Attachment #124299|0 |1 is obsolete|| Attachment #124300|0 |1 is obsolete|| Attachment #124301|0 |1 is obsolete|| Attachment #124302|0 |1 is obsolete|| Attachment #124303|0 |1 is obsolete|| Attachment #124304|0 |1 is obsolete|| Attachment #124305|0 |1 is obsolete|| Attachment #124306|0 |1 is obsolete|| Attachment #124307|0 |1 is obsolete|| Attachment #124321|0 |1 is obsolete|| --- Comment #294 from Kyle M Hall --- Created attachment 128734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128734=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #293 from Katrin Fischer --- Patches no longer apply, could you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions Applying: Bug 20256: Update groups editor Applying: Bug 20256: Use new methods Using index info to reconstruct a base tree... M Koha/Item.pm M catalogue/detail.pl M cataloguing/additem.pl M tools/batchMod.pl Falling back to patching base and 3-way merge... Auto-merging tools/batchMod.pl CONFLICT (content): Merge conflict in tools/batchMod.pl Auto-merging cataloguing/additem.pl CONFLICT (content): Merge conflict in cataloguing/additem.pl Auto-merging catalogue/detail.pl Auto-merging Koha/Item.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20256: Use new methods The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20256-Use-new-methods-G2R6lg.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #292 from Nick Clemens --- Created attachment 124321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124321=edit Bug 20256: (follow-up) Don't filter if no libraries are restricted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #291 from Nick Clemens --- Created attachment 124307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124307=edit Bug 20256: (follow-up) Fix spelling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121792|0 |1 is obsolete|| --- Comment #290 from Nick Clemens --- Created attachment 124306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124306=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121791|0 |1 is obsolete|| --- Comment #289 from Nick Clemens --- Created attachment 124305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124305=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121790|0 |1 is obsolete|| --- Comment #288 from Nick Clemens --- Created attachment 124304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124304=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121789|0 |1 is obsolete|| --- Comment #287 from Nick Clemens --- Created attachment 124303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124303=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121788|0 |1 is obsolete|| --- Comment #286 from Nick Clemens --- Created attachment 124302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124302=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121787|0 |1 is obsolete|| --- Comment #285 from Nick Clemens --- Created attachment 124301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124301=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121786|0 |1 is obsolete|| --- Comment #284 from Nick Clemens --- Created attachment 124300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124300=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121785|0 |1 is obsolete|| --- Comment #283 from Nick Clemens --- Created attachment 124299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124299=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121783|0 |1 is obsolete|| --- Comment #282 from Nick Clemens --- Created attachment 124298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124298=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121782|0 |1 is obsolete|| --- Comment #281 from Nick Clemens --- Created attachment 124297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124297=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121781|0 |1 is obsolete|| --- Comment #280 from Nick Clemens --- Created attachment 124296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124296=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121780|0 |1 is obsolete|| --- Comment #279 from Nick Clemens --- Created attachment 124295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124295=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121779|0 |1 is obsolete|| --- Comment #278 from Nick Clemens --- Created attachment 124294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124294=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121778|0 |1 is obsolete|| --- Comment #277 from Nick Clemens --- Created attachment 124293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124293=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121777|0 |1 is obsolete|| --- Comment #276 from Nick Clemens --- Created attachment 124292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124292=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121776|0 |1 is obsolete|| --- Comment #275 from Nick Clemens --- Created attachment 124291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124291=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121775|0 |1 is obsolete|| --- Comment #274 from Nick Clemens --- Created attachment 124290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124290=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121774|0 |1 is obsolete|| --- Comment #273 from Nick Clemens --- Created attachment 124289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124289=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121773|0 |1 is obsolete|| --- Comment #272 from Nick Clemens --- Created attachment 124288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124288=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121772|0 |1 is obsolete|| --- Comment #271 from Nick Clemens --- Created attachment 124287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124287=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Attachment #121771|0 |1 is obsolete|| --- Comment #270 from Nick Clemens --- Created attachment 124286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124286=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #269 from Katrin Fischer --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions Applying: Bug 20256: Update groups editor Applying: Bug 20256: Use new methods Applying: Bug 20256: Add unit tests Applying: Bug 20256: (QA follow-up) Remove double negative from code Applying: Bug 20256: (QA follow-up) Change meaning should change code Applying: Bug 20256: (QA follow-up) test borrowernumber in userenv too Applying: Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Applying: Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Applying: Bug 20256: (QA follow-up) Handle non-existing userenv Applying: Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Applying: Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit error: sha1 information is lacking or useless (tools/batchMod.pl). error: could not build fake ancestor Patch failed at 0001 Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20256-QA-follow-up-Skip-batch-editing-items-th-RbN33J.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #268 from Martin Renvoize --- Minor rebase and added my SO line as I've tested this.. still think it would be good to let Katrin do the final QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120076|0 |1 is obsolete|| --- Comment #267 from Martin Renvoize --- Created attachment 121792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121792=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120075|0 |1 is obsolete|| --- Comment #266 from Martin Renvoize --- Created attachment 121791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121791=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120074|0 |1 is obsolete|| --- Comment #265 from Martin Renvoize --- Created attachment 121790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121790=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120073|0 |1 is obsolete|| --- Comment #264 from Martin Renvoize --- Created attachment 121789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121789=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120072|0 |1 is obsolete|| --- Comment #263 from Martin Renvoize --- Created attachment 121788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121788=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120071|0 |1 is obsolete|| --- Comment #262 from Martin Renvoize --- Created attachment 121787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121787=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120070|0 |1 is obsolete|| --- Comment #261 from Martin Renvoize --- Created attachment 121786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121786=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120069|0 |1 is obsolete|| --- Comment #260 from Martin Renvoize --- Created attachment 121785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121785=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120068|0 |1 is obsolete|| --- Comment #259 from Martin Renvoize --- Created attachment 121783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121783=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120067|0 |1 is obsolete|| --- Comment #258 from Martin Renvoize --- Created attachment 121782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121782=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120066|0 |1 is obsolete|| --- Comment #257 from Martin Renvoize --- Created attachment 121781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121781=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120065|0 |1 is obsolete|| --- Comment #256 from Martin Renvoize --- Created attachment 121780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121780=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120064|0 |1 is obsolete|| --- Comment #255 from Martin Renvoize --- Created attachment 121779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121779=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120063|0 |1 is obsolete|| --- Comment #254 from Martin Renvoize --- Created attachment 121778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121778=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120062|0 |1 is obsolete|| --- Comment #253 from Martin Renvoize --- Created attachment 121777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121777=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120061|0 |1 is obsolete|| --- Comment #252 from Martin Renvoize --- Created attachment 121776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121776=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120060|0 |1 is obsolete|| --- Comment #251 from Martin Renvoize --- Created attachment 121775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121775=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120059|0 |1 is obsolete|| --- Comment #250 from Martin Renvoize --- Created attachment 121774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121774=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120058|0 |1 is obsolete|| --- Comment #249 from Martin Renvoize --- Created attachment 121773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121773=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120057|0 |1 is obsolete|| --- Comment #248 from Martin Renvoize --- Created attachment 121772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121772=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Attachment #120056|0 |1 is obsolete|| --- Comment #247 from Martin Renvoize --- Created attachment 121771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121771=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Keywords||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #246 from Martin Renvoize --- This looks good to me, and in my testing, all seems to be working well. As Katrin appears to already be most of the way through testing however.. I'll leave it to her to do the final signoff and PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #245 from Kyle M Hall --- Created attachment 120076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120076=edit Bug 20256: Update DB Schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #244 from Kyle M Hall --- Created attachment 120075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120075=edit Bug 20256: (QA follow-up) Implement for item search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #243 from Kyle M Hall --- Created attachment 120074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120074=edit Bug 20256: (QA follow-up) Implement for course reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #242 from Kyle M Hall --- Created attachment 120073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120073=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #241 from Kyle M Hall --- Created attachment 120072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120072=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #240 from Kyle M Hall --- Created attachment 120071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120071=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #239 from Kyle M Hall --- Created attachment 120070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120070=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #238 from Kyle M Hall --- Created attachment 120069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120069=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #236 from Kyle M Hall --- Created attachment 120067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120067=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #237 from Kyle M Hall --- Created attachment 120068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120068=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #235 from Kyle M Hall --- Created attachment 120066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120066=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #234 from Kyle M Hall --- Created attachment 120065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120065=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #233 from Kyle M Hall --- Created attachment 120064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120064=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #232 from Kyle M Hall --- Created attachment 120063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120063=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #231 from Kyle M Hall --- Created attachment 120062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120062=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #230 from Kyle M Hall --- Created attachment 120061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120061=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #229 from Kyle M Hall --- Created attachment 120060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120060=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #228 from Kyle M Hall --- Created attachment 120059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120059=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #227 from Kyle M Hall --- Created attachment 120058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120058=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #226 from Kyle M Hall --- Created attachment 120057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120057=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What|Removed |Added Attachment #120055|0 |1 is obsolete|| --- Comment #225 from Kyle M Hall --- Created attachment 120056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120056=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What|Removed |Added Attachment #116043|0 |1 is obsolete|| Attachment #116044|0 |1 is obsolete|| Attachment #116045|0 |1 is obsolete|| Attachment #116046|0 |1 is obsolete|| Attachment #116047|0 |1 is obsolete|| Attachment #116048|0 |1 is obsolete|| Attachment #116049|0 |1 is obsolete|| Attachment #116050|0 |1 is obsolete|| Attachment #116051|0 |1 is obsolete|| Attachment #116052|0 |1 is obsolete|| Attachment #116053|0 |1 is obsolete|| Attachment #116054|0 |1 is obsolete|| Attachment #116055|0 |1 is obsolete|| Attachment #116056|0 |1 is obsolete|| Attachment #116057|0 |1 is obsolete|| Attachment #116058|0 |1 is obsolete|| Attachment #116059|0 |1 is obsolete|| Attachment #116060|0 |1 is obsolete|| Attachment #116061|0 |1 is obsolete|| Attachment #116062|0 |1 is obsolete|| Attachment #116063|0 |1 is obsolete|| Attachment #116064|0 |1 is obsolete|| --- Comment #224 from Kyle M Hall --- Created attachment 120055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120055=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #223 from Katrin Fischer --- *** Bug 28174 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Summary|Add ability to limit|Add ability to limit |editing of items to home|editing of items to home |library |library or library group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #222 from Katrin Fischer --- Hi Kyle, could you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions error: sha1 information is lacking or useless (Koha/Patron.pm). error: could not build fake ancestor Patch failed at 0001 Bug 20256: Add new methods for checking item editing permissions The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20256-Add-new-methods-for-checking-item-editin-QeAIqS.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #221 from Kyle M Hall --- Created attachment 116064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116064=edit Bug 20256: Update DB Schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #220 from Kyle M Hall --- Created attachment 116063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116063=edit Bug 20256: (QA follow-up) Implement for item search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #218 from Kyle M Hall --- Created attachment 116061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116061=edit Bug 20256: (QA follow-up) Fix number of tests in Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #219 from Kyle M Hall --- Created attachment 116062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116062=edit Bug 20256: (QA follow-up) Implement for course reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #217 from Kyle M Hall --- Created attachment 116060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116060=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #216 from Kyle M Hall --- Created attachment 116059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116059=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #215 from Kyle M Hall --- Created attachment 116058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116058=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #214 from Kyle M Hall --- Created attachment 116057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116057=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #213 from Kyle M Hall --- Created attachment 116056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116056=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #212 from Kyle M Hall --- Created attachment 116055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116055=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #211 from Kyle M Hall --- Created attachment 116054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116054=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #210 from Kyle M Hall --- Created attachment 116053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116053=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #209 from Kyle M Hall --- Created attachment 116052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116052=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #208 from Kyle M Hall --- Created attachment 116051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116051=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #207 from Kyle M Hall --- Created attachment 116050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116050=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #206 from Kyle M Hall --- Created attachment 116049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116049=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #205 from Kyle M Hall --- Created attachment 116048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116048=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
