[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

David Nind  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds a new |This enhancement adds a new
  release notes|system preference   |system preference
   |StaffHghlightWords. This|StaffHighlightWords. This
   |enables highlighting of |enables highlighting of
   |words in search results for |words in search results for
   |the staff interface to be   |the staff interface to be
   |turned on or off.   |turned on or off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #42 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 🦄

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #41 from Fridolin Somers  ---
Commit messages corrected :
no space before ':'
Follow-up => follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #40 from Thibaud Guillot  ---
Created attachment 132414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132414&action=edit
Bug 20398: (QA Follow-up) Fix position of 'if' statement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #39 from Fridolin Somers  ---
In results.js :

Shouldn't block :
if( PREF_StaffHighlightedWords == 1 ){
highlightOn();
} else {
highlightOff();
}

Be inside :
  if( search_result.query_desc )

?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #38 from Thibaud Guillot  ---
Hi Katrin, 

Thanks to you, I will remember that :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #37 from Katrin Fischer  ---
Hi Thibaud,

1) Commit message 
Please make sure to run the QA test tools on your patches - they can highlight
things like mistakes with the commit message and give other helpful hints. In
this case there is an extra space that needs to be removed: Bug  : should
be Bug :

2) b/installer/data/mysql/mandatory/sysprefs.sql
This file is sorted alphabetically, as you are dealing with librarians here, we
take this seriously :)

3) Database update
For some time we are using a new format for database updates, see here:
https://wiki.koha-community.org/wiki/Database_updates

That's for next time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #36 from Katrin Fischer  ---
Created attachment 130532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130532&action=edit
Bug 20398: (QA follow-up) Fix alphabetical order in sysprefs.sql

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #130450|0   |1
is obsolete||

--- Comment #35 from Katrin Fischer  ---
Created attachment 130531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130531&action=edit
Bug 20398 : Added a syspref to highlight or not highlight search terms in
results on the staff interface

There is a possibility on OPAC but not yet on the staff interface, so I added
this syspref which has the same behaviour as the OPAC highlighting syspref.
When you choose to disable highlighting on the syspref, the toggle anchor in
the result page does not appear at all.
But if you keep the default state (highlighting on), you still have the option
to switch between "Unhighlight" and "Highlight" modes.

Test plan :
1. Go to the syspref named "StaffHighlightedWords" and see that the default
state is "Highlight".
2. Look for something in the catalogue for example and see that the words are
highlighted and that it is also possible to change between "Unhighlight" and
"Highlight".
3. Go back to syspref and choose to disable highlighting by choosing "Don't
Highlight".
4. Refresh your results page if you have not closed it or reload a new search.
5. There is no highlighting at all and anchors do not exist (same behaviour as
the OPAC interface).

Signed-off-by: ManuB 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds a new
  release notes||system preference
   ||StaffHghlightWords. This
   ||enables highlighting of
   ||words in search results for
   ||the staff interface to be
   ||turned on or off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #130446|0   |1
is obsolete||

--- Comment #34 from Kyle M Hall  ---
Created attachment 130450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130450&action=edit
Bug 20398 : Added a syspref to highlight or not highlight search terms in
results on the staff interface

There is a possibility on OPAC but not yet on the staff interface, so I added
this syspref which has the same behaviour as the OPAC highlighting syspref.
When you choose to disable highlighting on the syspref, the toggle anchor in
the result page does not appear at all.
But if you keep the default state (highlighting on), you still have the option
to switch between "Unhighlight" and "Highlight" modes.

Test plan :
1. Go to the syspref named "StaffHighlightedWords" and see that the default
state is "Highlight".
2. Look for something in the catalogue for example and see that the words are
highlighted and that it is also possible to change between "Unhighlight" and
"Highlight".
3. Go back to syspref and choose to disable highlighting by choosing "Don't
Highlight".
4. Refresh your results page if you have not closed it or reload a new search.
5. There is no highlighting at all and anchors do not exist (same behaviour as
the OPAC interface).

Signed-off-by: ManuB 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #33 from Thibaud Guillot  ---
(In reply to e.betemps from comment #31)
> (but the name of the syspref is 'StaffHighlightedWords')

yes.. I saw that I forgot to change the name in my test plan with latest
changes... this is fixed now, thanks for your feedback

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #130429|0   |1
is obsolete||

--- Comment #32 from Thibaud Guillot  ---
Created attachment 130446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130446&action=edit
Bug 20398 : Added a syspref to highlight or not highlight search terms in
results on the staff interface

There is a possibility on OPAC but not yet on the staff interface, so I added
this syspref which has the same behaviour as the OPAC highlighting syspref.
When you choose to disable highlighting on the syspref, the toggle anchor in
the result page does not appear at all.
But if you keep the default state (highlighting on), you still have the option
to switch between "Unhighlight" and "Highlight" modes.

Test plan :
1. Go to the syspref named "StaffHighlightedWords" and see that the default
state is "Highlight".
2. Look for something in the catalogue for example and see that the words are
highlighted and that it is also possible to change between "Unhighlight" and
"Highlight".
3. Go back to syspref and choose to disable highlighting by choosing "Don't
Highlight".
4. Refresh your results page if you have not closed it or reload a new search.
5. There is no highlighting at all and anchors do not exist (same behaviour as
the OPAC interface).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #31 from e.betemps  ---
(but the name of the syspref is 'StaffHighlightedWords')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

e.betemps  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #30 from e.betemps  ---
This patch applies.

I encountered problems this morning (patch uninstalled or ineffective) but they
seem solved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #130426|0   |1
is obsolete||

--- Comment #29 from Kyle M Hall  ---
Created attachment 130429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130429&action=edit
Bug 20398 : Added a syspref to highlight or not highlight search terms in
results on the staff interface

There is a possibility on OPAC but not yet on the staff interface, so I added
this syspref which has the same behaviour as the OPAC highlighting syspref.
When you choose to disable highlighting on the syspref, the toggle anchor in
the result page does not appear at all.
But if you keep the default state (highlighting on), you still have the option
to switch between "Unhighlight" and "Highlight" modes.

Test plan :
1. Go to the syspref named "HighlightedWords" and see that the default state is
"Highlight".
2. Look for something in the catalogue for example and see that the words are
highlighted and that it is also possible to change between "Unhighlight" and
"Highlight".
3. Go back to syspref and choose to disable highlighting by choosing "Don't
Highlight".
4. Refresh your results page if you have not closed it or reload a new search.
5. There is no highlighting at all and anchors do not exist (same behaviour as
the OPAC interface).

Signed-off-by: Emmanuel Bétemps 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #28 from Thibaud Guillot  ---
(In reply to David Nind from comment #25)
> Patch no longer applies 8-(... things move too fast sometimes!
> 
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 20398 : Added a syspref to highlight or not highlight search
> terms in results on the staff interface
> Using index info to reconstruct a base tree...
> M koha-tmpl/intranet-tmpl/prog/js/pages/results.js
> Falling back to patching base and 3-way merge...
> Auto-merging koha-tmpl/intranet-tmpl/prog/js/pages/results.js
> CONFLICT (content): Merge conflict in
> koha-tmpl/intranet-tmpl/prog/js/pages/results.js
> error: Failed to merge in the changes.
> Patch failed at 0001 Bug 20398 : Added a syspref to highlight or not
> highlight search terms in results on the staff interface

Normally I solved the conflict, thanks to you

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Thibaud Guillot  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #130420|0   |1
is obsolete||

--- Comment #27 from Thibaud Guillot  ---
Created attachment 130426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130426&action=edit
Bug 20398 : Added a syspref to highlight or not highlight search terms in
results on the staff interface

There is a possibility on OPAC but not yet on the staff interface, so I added
this syspref which has the same behaviour as the OPAC highlighting syspref.
When you choose to disable highlighting on the syspref, the toggle anchor in
the result page does not appear at all.
But if you keep the default state (highlighting on), you still have the option
to switch between "Unhighlight" and "Highlight" modes.

Test plan :
1. Go to the syspref named "HighlightedWords" and see that the default state is
"Highlight".
2. Look for something in the catalogue for example and see that the words are
highlighted and that it is also possible to change between "Unhighlight" and
"Highlight".
3. Go back to syspref and choose to disable highlighting by choosing "Don't
Highlight".
4. Refresh your results page if you have not closed it or reload a new search.
5. There is no highlighting at all and anchors do not exist (same behaviour as
the OPAC interface).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

e.betemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #26 from David Nind  ---
(In reply to Thibaud Guillot from comment #24)
> 
> Yes David you are absolutely right, yesterday when I rebased the patch I
> forgot to change some variable names on the script that manages the
> feature... my apologies, now its works. And I adjust the commit by the way
> with the bug number :)

No worries and excellent!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #25 from David Nind  ---
Patch no longer applies 8-(... things move too fast sometimes!

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20398 : Added a syspref to highlight or not highlight search
terms in results on the staff interface
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/js/pages/results.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/pages/results.js
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/js/pages/results.js
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20398 : Added a syspref to highlight or not highlight
search terms in results on the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #24 from Thibaud Guillot  ---
(In reply to David Nind from comment #22)
> (In reply to Thibaud Guillot from comment #21)
> 
> > Also for the description, my english is not as good as i would like ^^ so I
> > change this too.
> Hi Thibaud.
> 
> Thanks for incorporating my suggestions - writing things in another language
> can be challenging, so hopefully that is where testing can help!
> 
> I've retested, but for some reason highlighting doesn't seem to be working
> for me now - with either 'Highlight' or 'Don't highlight' selected for the
> new system preference.
> 
> Also, I would suggest:
> 
> - Setting the default to 'Highlight' (that is, leave the current behavour in
> place) (I'm not a developer, but from reading the code it should do that,
> but I'm not sure why it isn't).
> 
> - For the patch add the bug number at the start, that is: Bug 20398:
> Added... (the QA Team will most likely pick this up).
> 
> David

Yes David you are absolutely right, yesterday when I rebased the patch I forgot
to change some variable names on the script that manages the feature... my
apologies, now its works. And I adjust the commit by the way with the bug
number :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #130396|0   |1
is obsolete||

--- Comment #23 from Thibaud Guillot  ---
Created attachment 130420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130420&action=edit
Bug 20398 : Added a syspref to highlight or not highlight search terms in
results on the staff interface

There is a possibility on OPAC but not yet on the staff interface, so I added
this syspref which has the same behaviour as the OPAC highlighting syspref.
When you choose to disable highlighting on the syspref, the toggle anchor in
the result page does not appear at all.
But if you keep the default state (highlighting on), you still have the option
to switch between "Unhighlight" and "Highlight" modes.

Test plan :
1. Go to the syspref named "HighlightedWords" and see that the default state is
"Highlight".
2. Look for something in the catalogue for example and see that the words are
highlighted and that it is also possible to change between "Unhighlight" and
"Highlight".
3. Go back to syspref and choose to disable highlighting by choosing "Don't
Highlight".
4. Refresh your results page if you have not closed it or reload a new search.
5. There is no highlighting at all and anchors do not exist (same behaviour as
the OPAC interface).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #22 from David Nind  ---
(In reply to Thibaud Guillot from comment #21)

> Also for the description, my english is not as good as i would like ^^ so I
> change this too.
Hi Thibaud.

Thanks for incorporating my suggestions - writing things in another language
can be challenging, so hopefully that is where testing can help!

I've retested, but for some reason highlighting doesn't seem to be working for
me now - with either 'Highlight' or 'Don't highlight' selected for the new
system preference.

Also, I would suggest:

- Setting the default to 'Highlight' (that is, leave the current behavour in
place) (I'm not a developer, but from reading the code it should do that, but
I'm not sure why it isn't).

- For the patch add the bug number at the start, that is: Bug 20398: Added...
(the QA Team will most likely pick this up).

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #21 from Thibaud Guillot  ---
(In reply to David Nind from comment #19)
> I have tested this and it works as expected. I would suggest these changes:
>  
> 1. System preference name: change from HighlightedWords to
> StaffHighlightedWords
>  
> 2.System preference wording:
>   . Current: Don't highlight|Highlight words the patron searched for in
> their search results and detail pages.
>   . Suggested: Don't highlight|Highlight words searched for in the staff
> interface search results pages.
>   . Notes: For me the highlighting is only working on the search listing
> results pages, not on the record detail pages.
>  
>  - Location in the system preferences area: I would put under Staff
> interface > Appearance as this is consistent with the OPAC system
> preference, rather than under Searching > Results display.
>  
>  - Enable highlighting by default: as this is a change in the default
> behavour I would tend to leave the default (highlighting) enabled, rather
> than disabling it (that is, set the default to Highlight).

Hello David, 

Thanks for you feedback :)

I completely understand your notes, I'm agree for the syspref name : the more
precise, the better it will be.

Also for the description, my english is not as good as i would like ^^ so I
change this too.

And for the location... yes totally correct and adequate I concede it, like the
default behavior as you notice.

So I push again the patch with all this changes, thanks to tell me your opinion
:) 
And if other people test it of course we can discuss

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #128359|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #20 from Thibaud Guillot  ---
Created attachment 130396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130396&action=edit
Added a syspref to highlight or not highlight search terms in results on the
staff interface

There is a possibility on OPAC but not yet on the staff interface, so I added
this syspref which has the same behaviour as the OPAC highlighting syspref.
When you choose to disable highlighting on the syspref, the toggle anchor in
the result page does not appear at all.
But if you keep the default state (highlighting on), you still have the option
to switch between "Unhighlight" and "Highlight" modes.

Test plan :
1. Go to the syspref named "HighlightedWords" and see that the default state is
"Highlight".
2. Look for something in the catalogue for example and see that the words are
highlighted and that it is also possible to change between "Unhighlight" and
"Highlight".
3. Go back to syspref and choose to disable highlighting by choosing "Don't
Highlight".
4. Refresh your results page if you have not closed it or reload a new search.
5. There is no highlighting at all and anchors do not exist (same behaviour as
the OPAC interface).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2022-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #19 from David Nind  ---
I have tested this and it works as expected. I would suggest these changes:

1. System preference name: change from HighlightedWords to
StaffHighlightedWords

2.System preference wording:
  . Current: Don't highlight|Highlight words the patron searched for in their
search results and detail pages.
  . Suggested: Don't highlight|Highlight words searched for in the staff
interface search results pages.
  . Notes: For me the highlighting is only working on the search listing
results pages, not on the record detail pages.

 - Location in the system preferences area: I would put under Staff interface >
Appearance as this is consistent with the OPAC system preference, rather than
under Searching > Results display.

 - Enable highlighting by default: as this is a change in the default behavour
I would tend to leave the default (highlighting) enabled, rather than disabling
it (that is, set the default to Highlight).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #18 from Thibaud Guillot  ---
Because it can concerned other syspref and this can be interesting to develop
more I created https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29701

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #17 from Thibaud Guillot  ---
For now maybe someone can test my patch and tell if it's appropriate or not ?
"Highlighting" and "Unhighlighting" options are still possible on the go when
syspref isn't set to "Highlight" (by default) but if you disable highlighting
you will didn't see any highlighting after that

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #16 from Katrin Fischer  ---
What I am trying to say: this is a feature that is not wanted by some and we
have a lot of feature on/off switches. I don't see the difference with this
one? 

Having it in localstorage would be nice, but then I think we also should have a
pref to set the default (highlight or not highlight). The unhighlight option is
often missed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #15 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #13)
> Why do we need the syspref if each user can decide if they want the feature?
> We could (later) remove OpacHighlightedWords and use local storage for OPAC
> as well.
> 
> The reason I see would be to turn it off globally, but I don't think it's
> useful.

We had requests to turn it off in the OPAC and also the staff interface. I
think that it's by default 'on' is an issue that can be annoying. People are
often irritated that everything is highlighted instead of only highlighting the
words int he fields they searched in. I think having a pref here would be
helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #14 from Thibaud Guillot  ---
I agree, it's like "killing an ant with a tank" to remove the highlight by
adding a syspref, run updatedatabase.pl, add a conditioner... etc.

I wanted to keep the same behavior as OPAC for some unity of operation.

If we plan to remove OPACHighlightedWords later, it may be easier to add it to
localstorage by a little js code for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #13 from Jonathan Druart  ---
Why do we need the syspref if each user can decide if they want the feature?
We could (later) remove OpacHighlightedWords and use local storage for OPAC as
well.

The reason I see would be to turn it off globally, but I don't think it's
useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #12 from Owen Leonard  ---
I think that the existence of OpacHighlightedWords makes it logical to add a
preference for the staff interface. I agree that the "stopwords" option is
important to have.

I think it might also be good to preserve the user's highlight/unhighlight
choice in local storage so that it is preserved across their session.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #11 from Jonathan Druart  ---
In my opinion sysprefs should not drive UI's preferences. We are using local
storage for several features already so that should not be a problem.

See bug 5697 for instance, that have been pushed recently, or bug 24958.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #10 from Thibaud Guillot  ---
I reproduced the same behavior than OPAC side and from the discussion it
coincided with the integration of a system preference. If we put this parameter
in the localstorage could problems arise? Like using a browser that is set to
not store anything in the localstorage or simply the library that would prefer
not to store anything there. I am not against it but I question to raise
possible problems with its storage.
Especially since the system preference allows not to highlight certain words.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #9 from Jonathan Druart  ---
Shouldn't we store it as a user's setting in local storage instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Thibaud Guillot  changed:

   What|Removed |Added

 Blocks|20396   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396
[Bug 20396] Omnibus: Cleanup Koha and fight feature creep
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Thibaud Guillot  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #8 from Thibaud Guillot  ---
Created attachment 128359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128359&action=edit
Added a syspref to highlight or not highlight search terms in results on the
staff interface

There is a possibility on OPAC but not yet on the staff interface, so I added
this syspref which has the same behaviour as the OPAC highlighting syspref.
When you choose to disable highlighting on the syspref, the toggle anchor in
the result page does not appear at all.
But if you keep the default state (highlighting on), you still have the option
to switch between "Unhighlight" and "Highlight" modes.

Test plan :
1. Go to the syspref named "HighlightedWords" and see that the default state is
"Highlight".
2. Look for something in the catalogue for example and see that the words are
highlighted and that it is also possible to change between "Unhighlight" and
"Highlight".
3. Go back to syspref and choose to disable highlighting by choosing "Don't
Highlight".
4. Refresh your results page if you have not closed it or reload a new search.
5. There is no highlighting at all and anchors do not exist (same behaviour as
the OPAC interface).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2021-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Thibaud Guillot  changed:

   What|Removed |Added

 CC||thibaud.guil...@biblibre.co
   ||m
   Assignee|fridolin.som...@biblibre.co |thibaud.guil...@biblibre.co
   |m   |m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2020-07-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Owen Leonard  changed:

   What|Removed |Added

 CC||pasi.kalli...@koha-suomi.fi

--- Comment #7 from Owen Leonard  ---
*** Bug 11525 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2018-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #6 from Elaine Bradtke  ---
(In reply to Katrin Fischer from comment #5)
We deactivated it in the OPAC. Shortly after we activated it.  

> You can already deactivate it on the OPAC:  HighlightOwnItemsOnOPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2018-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #5 from Katrin Fischer  ---
(In reply to Elaine Bradtke from comment #4)
> +1 we've actually had comments / complaints from users who don't like it. 
> Would love to switch it off or remove it completely.
> (In reply to Andreas Hedström Mace from comment #3)
> > +1 on adding a pref to disable!
> > 
> > (I wouldn't mind if the functionality was removed altogether either.)

You can already deactivate it on the OPAC:  HighlightOwnItemsOnOPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2018-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Elaine Bradtke  changed:

   What|Removed |Added

 CC||e...@efdss.org

--- Comment #4 from Elaine Bradtke  ---
+1 we've actually had comments / complaints from users who don't like it. 
Would love to switch it off or remove it completely.
(In reply to Andreas Hedström Mace from comment #3)
> +1 on adding a pref to disable!
> 
> (I wouldn't mind if the functionality was removed altogether either.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2018-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Andreas Hedström Mace  changed:

   What|Removed |Added

 CC||andreas.hedstrom.mace@sub.s
   ||u.se

--- Comment #3 from Andreas Hedström Mace  ---
+1 on adding a pref to disable!

(I wouldn't mind if the functionality was removed altogether either.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2018-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2018-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
It works to a certain extend - it higlights words from your search in the
results. It could work better, yes, but it's not totally broken. A pref seems
fine to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

2018-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

Gaetan Boisson  changed:

   What|Removed |Added

Summary|Remove search result|Add a system preference to
   |highlighting|disable search result
   ||highlighting in the staff
   ||interface

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/