[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #697 from Magnus Enger --- (In reply to Katrin Fischer from comment #691) > I believe it would be better to focus on this one right after the release > and try to get it pushed early for 24.05. Looks like that didn't happen. Maybe 24.11? What is the status here, apart from "Patch does not apply"? Is anyone willing to rebase/update the patches? As far as I can see, there are already signoffs from the current QAM and another member of the QA team, so this should not be too far off from passing QA, if the patches could be updated? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #698 from Katrin Fischer --- (In reply to Magnus Enger from comment #697) > (In reply to Katrin Fischer from comment #691) > > I believe it would be better to focus on this one right after the release > > and try to get it pushed early for 24.05. > > Looks like that didn't happen. Maybe 24.11? > > What is the status here, apart from "Patch does not apply"? Is anyone > willing to rebase/update the patches? As far as I can see, there are already > signoffs from the current QAM and another member of the QA team, so this > should not be too far off from passing QA, if the patches could be updated? Yes, I think in order to make this to happen we a joint effort of the patch writers, tester and QA team. As it's been sitting for a while, we certainly want to do another run through before pushing. I am open to do it still, but we need to hurry up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #689 from Andrii Nugged --- Publishing this week rebased (many changes & few more bugfixes). I will ask for community to push this ticket to master if possible. + I will put plan what is more here should be improved (there still lack of batch processing, but our team in National Library of Finland will work on this further). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #690 from Andrii Nugged --- I will publish this week rebased (many changes & few more bugfixes). I will ask the community to push this ticket to master if possible. + I will put a plan on what is more here that should be improved (there is still a lack of batch processing, but our team in the National Library of Finland will work on this further). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #691 from Katrin Fischer --- It's quite late in the current cycle and we already have a lot of big and small developments in the queues that we are trying to finish for the 23.11 release in time. I believe it would be better to focus on this one right after the release and try to get it pushed early for 24.05. Maybe a dedicated sandbox could also help in getting this tested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrii Nugged changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrii Nugged changed: What|Removed |Added Attachment #139895|0 |1 is obsolete|| Attachment #139896|0 |1 is obsolete|| --- Comment #692 from Andrii Nugged --- Created attachment 157492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157492&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Smaller notes to task parts (batch rebuild script): --- Includes misc/batchRebuildHoldingsTables.pl: a batch rebuild script for holdings table which can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. --- End of smaller notes Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Co-authored-by: Andrew Nugged Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #693 from Andrii Nugged --- Created attachment 157493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157493&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #694 from Andrii Nugged --- PerlKohaCon.fi talk by this topic: " ... about Holdings what are those and how they are used when items are not enough: in our case in the National Library in Finland. Why do we need to have Holdings and then something about Holdings in Koha in general, and what kind of improvements we do need to use those better ones, ... " is here: https://www.youtube.com/watch?v=d2i1dW9CKAs&list=PLa9kvrI3VLf7ZvLvJk9EtlnF2OVETvddm&index=20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #695 from Andrii Nugged --- (In reply to Michal Denar from comment #688) Michal, can you check this: https://wiki.koha-community.org/wiki/Road_map_24.05#Project_proposals -> Project proposals -> Add support for MARC holdings records. Others who are also interested in this feature appear: we need more supporters in one week there, so if there is enough support, this ticket will be included in the 24.05 plan. Please sign in there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Laurence Rault changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||laurence.ra...@biblibre.com --- Comment #696 from Laurence Rault --- merge conflicts in applying in ktd -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 JillDye changed: What|Removed |Added CC||j@nms.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com ||, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #688 from Michal Denar --- Any news? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #76670|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #83556|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #76 from Ere Maijala --- Created attachment 85364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85364&action=edit Sample MARCXML file with interleaved holdings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #83558|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #83555|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #83559|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #83557|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #78 from Ere Maijala --- Created attachment 85369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85369&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #77 from Ere Maijala --- Created attachment 85368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85368&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #79 from Ere Maijala --- Created attachment 85370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85370&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #80 from Ere Maijala --- Created attachment 85371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85371&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #81 from Ere Maijala --- Almost there. I missed addition of holdings framework to update scripts, so clearing status until I get that fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85370|0 |1 is obsolete|| --- Comment #84 from Ere Maijala --- Created attachment 85418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85418&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85369|0 |1 is obsolete|| --- Comment #83 from Ere Maijala --- Created attachment 85417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85417&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85371|0 |1 is obsolete|| --- Comment #85 from Ere Maijala --- Created attachment 85419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85419&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85368|0 |1 is obsolete|| --- Comment #82 from Ere Maijala --- Created attachment 85416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85416&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #86 from Ere Maijala --- All QA comments should now be addressed. I've converted everything to Koha namespace and cleaned up the code heavily. There are still some references to existing code in C4 namespace, but that's difficult to avoid at the moment. I had to come up with a method for updating metadata, and I hope what I came up with is nice and clean, but it can still be adjusted especially when C4::Biblio is converted to keep them as similar as possible. Functional changes from previous versions: - Subfield 'k' is now used for linking from item to holdings record. While its position is not so nice in the item form, it was the only subfield available. - biblioitemnumber has been dropped from the holdings table since it wasn't used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #87 from Ere Maijala --- One thing that could be done would be to decouple the MARC editor from addbiblio so that the code could be re-used. I'll see if that's something that could be done with not too high impact. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Irma Birchall changed: What|Removed |Added CC||i...@calyx.net.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21280 --- Comment #88 from Ere Maijala --- I'll work in Bug 21280 to unify the MARC editors in biblios and authorities. I don't consider it blocking, but if it happened that it would be accepted, I would update the editor here to use the common stuff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85416|0 |1 is obsolete|| --- Comment #89 from Ere Maijala --- Created attachment 85906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85906&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85417|0 |1 is obsolete|| --- Comment #90 from Ere Maijala --- Created attachment 85907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85907&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85419|0 |1 is obsolete|| --- Comment #92 from Ere Maijala --- Created attachment 85909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85909&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85418|0 |1 is obsolete|| --- Comment #91 from Ere Maijala --- Created attachment 85908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85908&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85907|0 |1 is obsolete|| --- Comment #94 from Ere Maijala --- Created attachment 85995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85995&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85909|0 |1 is obsolete|| --- Comment #96 from Ere Maijala --- Created attachment 85997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85997&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85908|0 |1 is obsolete|| --- Comment #95 from Ere Maijala --- Created attachment 85996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85996&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85906|0 |1 is obsolete|| --- Comment #93 from Ere Maijala --- Created attachment 85994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85994&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #97 from Joonas Kylmälä --- Why is there deleted_on on in both holdings and holdings_metadata tables? Why is it not enough to have it just in holdings? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
--- Comment #98 from Joonas Kylmälä ---
Comment on attachment 85994
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85994
Bug 20447: MARC Holdings support
Review of attachment 85994:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=85994)
-
::: C4/Biblio.pm
@@ +1563,5 @@
> }
>
> +# holdings
> +if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq
> "holdings" ) {
> +my $holding = Koha::Holdings->find( $value );
does the find need "deleted_on => undef" as a parameter in order to not care
about deleted holdings?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
--- Comment #99 from Joonas Kylmälä ---
Comment on attachment 85994
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85994
Bug 20447: MARC Holdings support
Review of attachment 85994:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=85994)
-
::: C4/Items.pm
@@ +1705,5 @@
> +holdingbranch=> $oldHolding->{'holdingbranch'},
> +location => $oldHolding->{'location'},
> +callnumber => $oldHolding->{'callnumber'},
> +suppress => $oldHolding->{'suppress'},
> +deleted_on => undef
if deleted_on is not needed / is undef by default this can be removed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20271 --- Comment #100 from Ere Maijala --- (In reply to Joonas Kylmälä from comment #97) > Why is there deleted_on on in both holdings and holdings_metadata tables? > Why is it not enough to have it just in holdings? Because that's how it's done also for biblios in bug 20271. There's at least one practical upside: it allows one to fetch a metadata record without joining with the base table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
--- Comment #101 from Ere Maijala ---
(In reply to Joonas Kylmälä from comment #98)
> Comment on attachment 85994 [details] [review]
> Bug 20447: MARC Holdings support
>
> Review of attachment 85994 [details] [review]:
> -
>
> ::: C4/Biblio.pm
> @@ +1563,5 @@
> > }
> >
> > +# holdings
> > +if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq
> > "holdings" ) {
> > +my $holding = Koha::Holdings->find( $value );
>
> does the find need "deleted_on => undef" as a parameter in order to not care
> about deleted holdings?
It allows one to fetch a holdings record by ID even if it's deleted. I believe
it makes sense since otherwise it would be possible, at least in theory, for an
item to point to a deleted holdings record without it showing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #103 from Joonas Kylmälä --- (In reply to Ere Maijala from comment #100) > (In reply to Joonas Kylmälä from comment #97) > > Why is there deleted_on on in both holdings and holdings_metadata tables? > > Why is it not enough to have it just in holdings? > > Because that's how it's done also for biblios in bug 20271. There's at least > one practical upside: it allows one to fetch a metadata record without > joining with the base table. #1 rule in my database course was always use the normal form for databases. It feels wrong to have the data in one place: twice the possibility of having bugs and also taking twice as much space. I read quickly https://stackoverflow.com/questions/2623852/why-are-joins-bad-when-considering-scalability and in the end the performance difference might not be that big. I would like you to provide performance benchmarks if we are going to use the non-normalized way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
--- Comment #102 from Ere Maijala ---
(In reply to Joonas Kylmälä from comment #99)
> Comment on attachment 85994 [details] [review]
> Bug 20447: MARC Holdings support
>
> Review of attachment 85994 [details] [review]:
> -
>
> ::: C4/Items.pm
> @@ +1705,5 @@
> > +holdingbranch=> $oldHolding->{'holdingbranch'},
> > +location => $oldHolding->{'location'},
> > +callnumber => $oldHolding->{'callnumber'},
> > +suppress => $oldHolding->{'suppress'},
> > +deleted_on => undef
>
> if deleted_on is not needed / is undef by default this can be removed
It tries to find an existing holdings record for the item to be attached to.
Deleted holdings do not qualify, so the filter is needed. However, I just
realized that the search terms can match multiple records which would cause
find() to fail. I need to revise that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #104 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #103) > #1 rule in my database course was always use the normal form for databases. > It feels wrong to have the data in one place: twice the possibility of > having bugs and also taking twice as much space. I read quickly > https://stackoverflow.com/questions/2623852/why-are-joins-bad-when- > considering-scalability and in the end the performance difference might not > be that big. I would like you to provide performance benchmarks if we are > going to use the non-normalized way. Here is a few pages of reasoning why we should use the normal form: https://mariadb.com/kb/en/library/database-normalization/ (unless there is a significant performance gain) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #105 from Ere Maijala --- I'm aware of that, but I'm not making the call here. I think it would be better to continue discussion about the deleted_on field in the metadata tables in bug 20271. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85994|0 |1 is obsolete|| --- Comment #106 from Ere Maijala --- Created attachment 86088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86088&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85995|0 |1 is obsolete|| --- Comment #107 from Ere Maijala --- Created attachment 86089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86089&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85996|0 |1 is obsolete|| --- Comment #108 from Ere Maijala --- Created attachment 86090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86090&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #85997|0 |1 is obsolete|| --- Comment #109 from Ere Maijala --- Created attachment 86091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86091&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #110 from Ere Maijala --- Fixed item relinking and made saving a holdings record reindex its biblio record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #112 from Michal Denar --- Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm Auto-merging Koha/Schema/Result/Biblio.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #111 from Michal Denar --- Ere, please rebase on master. Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #113 from Josef Moravec --- (In reply to Michal Denar from comment #112) > Auto-merging Koha/Schema/Result/Branch.pm > CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm > Auto-merging Koha/Schema/Result/Biblio.pm > CONFLICT (content): Merge conflict in Koha/Schema/Result/Biblio.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 20447: DBIX schema changes Mike, these files could be easily regeneretad, just omit this one patch and run command 'dbic' on kohadevbox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Frank Hansen changed: What|Removed |Added CC||frank.han...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #86088|0 |1 is obsolete|| --- Comment #114 from Ere Maijala --- Created attachment 87307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87307&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #86090|0 |1 is obsolete|| --- Comment #116 from Ere Maijala --- Created attachment 87309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87309&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #86089|0 |1 is obsolete|| --- Comment #115 from Ere Maijala --- Created attachment 87308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87308&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #86091|0 |1 is obsolete|| --- Comment #117 from Ere Maijala --- Created attachment 87310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87310&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #118 from Ere Maijala --- Rebased, but the schema patch is likely to break again.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #119 from Michal Denar --- Hi Ere, tests passed, but I'm not able to import attached files: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 0 MARC bibliographic records and 0 holdings records done in 0.012 seconds Any ideas? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #120 from Ere Maijala --- A couple of simple checks first: check that you have holdings.xml in the current directory and that it's valid xml. bulkmarcimport doesn't have very good error checking and it will just report 0 records if it doesn't find the file or can't read it. For what it's worth, here are my results: $ xmllint -noout holdings.xml $ misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML . 5 MARC bibliographic records and 3 holdings records done in 1.711 seconds If you are still unable to make it work, I'll need to recheck with kohadevbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #121 from Michal Denar --- Hi Ere, sorry my fault., no holdings.xml on devbox :-( I'll next round... Thanks to Josef for kick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #124 from Michal Denar --- Created attachment 87348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87348&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Michal Denar changed: What|Removed |Added Attachment #87307|0 |1 is obsolete|| Attachment #87308|0 |1 is obsolete|| Attachment #87309|0 |1 is obsolete|| Attachment #87310|0 |1 is obsolete|| --- Comment #122 from Michal Denar --- Created attachment 87346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87346&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #125 from Michal Denar --- Created attachment 87349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87349&action=edit Bug 20447: DBIX schema changes Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #123 from Michal Denar --- Created attachment 87347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87347&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
--- Comment #126 from Josef Moravec ---
Comment on attachment 87346
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87346
Bug 20447: MARC Holdings support
Review of attachment 87346:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=87346)
-
::: C4/Biblio.pm
@@ +2828,5 @@
>
> $itemnumbers = [] unless defined $itemnumbers;
>
> +if ( !$skip_holdings && C4::Context->preference('SummaryHoldings') &&
> !@$itemnumbers ) {
> +require Koha::Holdings;
You don't need this require
::: C4/Items.pm
@@ +1690,5 @@
> AND biblionumber = ?
> |, undef, $tobiblioitem, $tobiblio, $itemnumber, $frombiblio );
> if ($return == 1) {
> +# Check if the moved item is attached to a holdings record
> +my $item = my $item = Koha::Items->find($itemnumber);
double "my $item"
::: C4/Search.pm
@@ +2252,5 @@
> }
>
> +# Fetch summary holdings
> +if (C4::Context->preference('SummaryHoldings')) {
> +$summary_holdings = Koha::Holdings->search({ biblionumber =>
> $oldbiblio->{biblionumber}, deleted_on => undef })->unblessed;
why do you unbless here?
::: Koha/Holding.pm
@@ +53,5 @@
> +my ($self) = @_;
> +
> +$self->{_metadata} ||= Koha::Holdings::Metadatas->find({ holding_id =>
> $self->id });
> +
> +return $self->{_metadata};
Should be changed, according to bug 22407, see
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-oriented_code_and_the_Koha::_namespace
You should use something like
my $metadata = $self->_result->metadata;
return Koha::Holdings::Metadata->_new_from_dbic($metadata);
@@ +111,5 @@
> +my ($self) = @_;
> +
> +$self->{_items} ||= Koha::Items->search( { holding_id =>
> $self->holding_id() } );
> +
> +return wantarray ? $self->{_items}->as_list : $self->{_items};
PERL15 rule applies here too
::: Koha/Template/Plugin/Holdings.pm
@@ +71,5 @@
> +my $sth = C4::Context->dbh->prepare($query);
> +$sth->execute($holding->{'holdingbranch'});
> +my $b = $sth->fetchrow_hashref();
> +push @parts, $b->{'branchname'} if $b;
> +$sth->finish();
Why do you use sql instead of relation method like $holding->library ?
::: catalogue/detail.pl
@@ +194,5 @@
>
> +# Summary holdings
> +my $summary_holdings;
> +if (C4::Context->preference('SummaryHoldings')) {
> +$summary_holdings = Koha::Holdings->search({ biblionumber =>
> $biblionumber, deleted_on => undef })->unblessed;
Why do you unbless?
::: t/db_dependent/Koha/Holding.t
@@ +22,5 @@
> +use t::lib::TestBuilder;
> +
> +use C4::Biblio;
> +
> +use Koha::BiblioFramework;
Singular class is imported through plural class, it is not needed to be used
explicitaly.
::: t/db_dependent/Koha/Holdings.t
@@ +22,5 @@
> +use t::lib::TestBuilder;
> +
> +use C4::Biblio;
> +
> +use Koha::BiblioFramework;
Not needed to use singular class
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #127 from Josef Moravec --- Started QA, found some first issues: When editing holding marc record, i am able to change framework to default and acquisition, is it intended? The holdings marc editor need to be upgraded to new style introduce by bug 22045. Could be done in own bug report or on bug 21280 I think. QA test tools report: FAILC4/Biblio.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/ImportBatch.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/Items.pm FAIL valid "my" variable $item masks earlier declaration in same statement "my" variable $item masks earlier declaration in same statement FAIL C4/Search.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/XSLT.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Exporter/Record.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Holdings.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/OAI/Server/ListBase.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/OAI/Server/Repository.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Template/Plugin/Holdings.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL admin/marc_subfields_structure.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL catalogue/detail.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL catalogue/showmarc.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/addholding.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/additem.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/value_builder/marc21_field_008_holdings.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/value_builder/marc21_leader_holdings.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc FAIL filters missing_filter at line 14 (New holdings record) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 210 ( Edit) missing_filter at line 210 ( Edit) missing_filter at line 211 ( Delete) missing_filter at line 211 ( Delete) missing_filter at line 212 ( Add item) missing_filter at line 212 ( Add item) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addholding.tt FAIL filters wrong_html_filter at line 358 ( › Edit [% title | html %] [% IF ( author ) %] by [% author | html %][% END %] (Record #[% biblionumber | html %])) wrong_html_filter at line 359 ( › Holdings) wrong_html_filter at line 457 ([% BIG_LOO.number | html %]) missing_filter at line 469 ([% innerloo.tag %]) missing_filter at line 471 ([% innerloo.tag | html %]) missing_filter at line 553 ([% subfield_loo.marc_lib %]) missing_filter at line 578 ([% mv.javascript %]) missing_filter at line 582 ([%- mv.value -%]) FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 11) forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 376) FAIL js_in_body A
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #87349|0 |1 is obsolete|| --- Comment #131 from Ere Maijala --- Created attachment 88754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88754&action=edit Bug 20447: DBIX schema changes Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #87347|0 |1 is obsolete|| --- Comment #129 from Ere Maijala --- Created attachment 88752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88752&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #87346|0 |1 is obsolete|| --- Comment #128 from Ere Maijala --- Created attachment 88751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88751&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Attachment #87348|0 |1 is obsolete|| --- Comment #130 from Ere Maijala --- Created attachment 88753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88753&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #132 from Ere Maijala --- Created attachment 88755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88755&action=edit Bug 20447: Use blessed objects and fix issues found during review -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #133 from Ere Maijala --- Thanks Josef, I believe I've addressed the comments in the latest patch. I'd rather leave editor unification to bug 21280 or a separate bug. Regarding changing the framework, I had in one version a new column for the framework type so that the selection list could be filtered, but I dropped it to keep the changes to minimum. That can be revisited later. I don't consider it a big issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=9442 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #134 from Joonas Kylmälä --- This patch set would break cataloguing/merge.pl since there is no patch to move holdings to a different bibliographic record. I have moved this back to "In Discussion" because I think this needs to be fixed before merging this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #135 from Katrin Fischer --- (In reply to Joonas Kylmälä from comment #134) > This patch set would break cataloguing/merge.pl since there is no patch to > move holdings to a different bibliographic record. I have moved this back to > "In Discussion" because I think this needs to be fixed before merging this > patch set. Hi Joonas, thx for testing. Setting to Failed QA is better in this case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #652 from Andrew Nugged --- I am now doing intermediate rebase, this one will go on tag v22.04.05 (commit hash 75372f012b4ecc321a0658f22ae4f3700502f018). Intermediate, because in the next step after below pre-rebase (pre- because not yet on current master), I plan to squash and re-factor TOO BIG to debug and do future rebasings code, and this will help us to rebase & sign off much cleaner code later. And also, it will include 7 more (!) bug fixes patches over the current state of the things above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged changed: What|Removed |Added Attachment #131458|0 |1 is obsolete|| Attachment #131459|0 |1 is obsolete|| Attachment #131460|0 |1 is obsolete|| Attachment #131461|0 |1 is obsolete|| Attachment #131462|0 |1 is obsolete|| Attachment #131463|0 |1 is obsolete|| Attachment #131464|0 |1 is obsolete|| Attachment #131465|0 |1 is obsolete|| Attachment #131466|0 |1 is obsolete|| Attachment #131467|0 |1 is obsolete|| Attachment #131468|0 |1 is obsolete|| Attachment #131469|0 |1 is obsolete|| Attachment #131470|0 |1 is obsolete|| Attachment #131471|0 |1 is obsolete|| Attachment #131472|0 |1 is obsolete|| Attachment #131473|0 |1 is obsolete|| Attachment #131474|0 |1 is obsolete|| Attachment #131475|0 |1 is obsolete|| Attachment #131476|0 |1 is obsolete|| Attachment #131477|0 |1 is obsolete|| Attachment #131478|0 |1 is obsolete|| Attachment #131479|0 |1 is obsolete|| Attachment #131480|0 |1 is obsolete|| Attachment #131481|0 |1 is obsolete|| Attachment #131482|0 |1 is obsolete|| --- Comment #653 from Andrew Nugged --- Created attachment 139865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139865&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Co-authored-by: Andrew Nugged Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #654 from Andrew Nugged --- Created attachment 139866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139866&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #655 from Andrew Nugged --- Created attachment 139867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139867&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #656 from Andrew Nugged --- Created attachment 139868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139868&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #657 from Andrew Nugged --- Created attachment 139869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139869&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #658 from Andrew Nugged --- Created attachment 139870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139870&action=edit Bug 20447: Fixes for bug 17600 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #659 from Andrew Nugged --- Created attachment 139871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139871&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged Rebased-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #660 from Andrew Nugged --- Created attachment 139872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139872&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #661 from Andrew Nugged --- Created attachment 139873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139873&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
