[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS --- I choose not to backport to 17.05.x, I focus on major and blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #13 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #12 from Martin Renvoize --- This patch has been pushed to 18.05.x and will be in 18.05.01 Go forth and debug all the things :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_05_candidate --- Comment #11 from Jonathan Druart --- We need it to be backported to help debug! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Julian Maurice from comment #7) > (In reply to Julian Maurice from comment #3) > > So, the message should probably be "This method does not exist" rather than > > "not covered by tests". > > Any opinion on that ? Should I open a new bug ? I agree. File a new one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #8 from Marcel de Rooy --- (In reply to Julian Maurice from comment #7) > (In reply to Julian Maurice from comment #3) > > So, the message should probably be "This method does not exist" rather than > > "not covered by tests". > > Any opinion on that ? Should I open a new bug ? This method is not supported ? If you only replace a few words, please add a QA follow-up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #7 from Julian Maurice --- (In reply to Julian Maurice from comment #3) > So, the message should probably be "This method does not exist" rather than > "not covered by tests". Any opinion on that ? Should I open a new bug ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Marcel de Rooy changed: What|Removed |Added Attachment #75547|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 75552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75552&action=edit Bug 20767: Display a stack trace when a method is not covered by tests When a method is not allowed yet (not covered by tests), developers get an error the is not really useful: "The method XXX is not covered by tests!" It would be more useful to have a stack trace in order to know where this error come from. Test plan: Modify some code to display this stack trace and confirm it makes sense to have it, i.e. it will make debug easier Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 M. Tompsett changed: What|Removed |Added Attachment #75319|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 75547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75547&action=edit Bug 20767: Display a stack trace when a method is not covered by tests When a method is not allowed yet (not covered by tests), developers get an error the is not really useful: "The method XXX is not covered by tests!" It would be more useful to have a stack trace in order to know where this error come from. Test plan: Modify some code to display this stack trace and confirm it makes sense to have it, i.e. it will make debug easier Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
--- Comment #4 from Séverine Queune ---
I have a (good ?) example on my test instance : when I try to use the new
syspref to mark an item lost and notify patron from holds to pull list, I get
this software error :
The method homebranch is not covered by tests!"
Applying this patch, I get this one :
The method Koha::Patron->homebranch is not covered by tests!
Trace begun at /var/repositories/koha/Koha/Object.pm line 398
Koha::Object::AUTOLOAD('Koha::Patron=HASH(0x8d10e08)') called at
/var/repositories/koha/
circ/pendingreserves.pl line 71
Is it the behaviour you were looking for ?
As I don't know what you expect I prefer not signing it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #3 from Julian Maurice --- (In reply to Victor Grousset/tuxayo from comment #2) > (In reply to Jonathan Druart from comment #0) > > When a method is not allowed yet (not covered by tests) > > Is this about automated tests? Then what does this has to do when executing > the method? Is this a way to make people to write tests? > > It seems that there can be other causes to this error, is that correct? > > I also heard that this had to do with the mapping with de DB columns being > done or not. So, I'm confused ^^" We can get this error when we try to use a new column and Koha::Schema was not updated. So, the message should probably be "This method does not exist" rather than "not covered by tests". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m --- Comment #2 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #0) > When a method is not allowed yet (not covered by tests) Is this about automated tests? Then what does this has to do when executing the method? Is this a way to make people to write tests? It seems that there can be other causes to this error, is that correct? I also heard that this had to do with the mapping with de DB columns being done or not. So, I'm confused ^^" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #1 from Jonathan Druart --- Created attachment 75319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75319&action=edit Bug 20767: Display a stack trace when a method is not covered by tests When a method is not allowed yet (not covered by tests), developers get an error the is not really useful: "The method XXX is not covered by tests!" It would be more useful to have a stack trace in order to know where this error come from. Test plan: Modify some code to display this stack trace and confirm it makes sense to have it, i.e. it will make debug easier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
