[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin SOMERS --- Depends on Bug 19777 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Martin Renvoize changed: What|Removed |Added Keywords|rel_18_05_candidate | Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #13 from Martin Renvoize --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Katrin Fischer changed: What|Removed |Added Attachment #75778|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 75793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75793&action=edit Bug 20778: (bug 19777 follow-up) Fix subscription deletion Caused by commit 666a1b276097785c2a7c33e718f26f5512b3d972 Bug 19777: Move template JavaScript to the footer: Serials, part 3 TT vars should not be used in .js files Test plan: Delete a subscription, confirm you see the confirmation popup and that the it deletes the subscription correctly after it has been confirmed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Owen Leonard changed: What|Removed |Added Attachment #75777|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 75778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75778&action=edit Bug 20778: (bug 19777 follow-up) Fix subscription deletion Caused by commit 666a1b276097785c2a7c33e718f26f5512b3d972 Bug 19777: Move template JavaScript to the footer: Serials, part 3 TT vars should not be used in .js files Test plan: Delete a subscription, confirm you see the confirmation popup and that the it deletes the subscription correctly after it has been confirmed. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Jonathan Druart changed: What|Removed |Added Attachment #75505|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 75777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75777&action=edit Bug 20778: (bug 19777 follow-up) Fix subscription deletion Caused by commit 666a1b276097785c2a7c33e718f26f5512b3d972 Bug 19777: Move template JavaScript to the footer: Serials, part 3 TT vars should not be used in .js files Test plan: Delete a subscription, confirm you see the confirmation popup and that the it deletes the subscription correctly after it has been confirmed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|In Discussion |ASSIGNED Depends on||19777 Assignee|alex.arn...@biblibre.com|jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- Caused by commit 666a1b276097785c2a7c33e718f26f5512b3d972 Bug 19777: Move template JavaScript to the footer: Serials, part 3 TT var used in .js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 [Bug 19777] Move template JavaScript to the footer: Serials, part 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 --- Comment #7 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #6) > Not sure to understand what you are expecting. If i remove the 2 others JS > confirmation (for closing and reopening), we have no more confirmation at > all. I did it for deleting because there is an other one after. So the JS > one is useless. > > Other possibility is to remove the one after JS for subscription deletion. > > I agree that this BZ is for fixing subscription deleting. Not for removing a > useless confirmation. So i can just do what it is expected for Yeah. Consider removing the one after the JS confirm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Alex Arnaud changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #6 from Alex Arnaud --- (In reply to Marcel de Rooy from comment #5) > I think we are not adding consistency in this script by removing a confirm > from one of the js functions in a row of similar ones. > Should you remove the other confirmation perhaps ? > > If you have confirm_deletion as name, I would expect a confirm there too. Hello Marcel, Not sure to understand what you are expecting. If i remove the 2 others JS confirmation (for closing and reopening), we have no more confirmation at all. I did it for deleting because there is an other one after. So the JS one is useless. Other possibility is to remove the one after JS for subscription deletion. I agree that this BZ is for fixing subscription deleting. Not for removing a useless confirmation. So i can just do what it is expected for -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy --- I think we are not adding consistency in this script by removing a confirm from one of the js functions in a row of similar ones. Should you remove the other confirmation perhaps ? If you have confirm_deletion as name, I would expect a confirm there too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #4 from Séverine Queune --- I never noticed that point before :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 --- Comment #3 from sandbo...@biblibre.com --- Created attachment 75505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75505&action=edit Bug 20778: Fix subscription deletion. Also remove the first confirmation pop because we have another one. Test plan: - go to a subscription detail page, - click on edit -> delete subscription, - confirm deletion, - check that the subscription is no longer here Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 sandbo...@biblibre.com changed: What|Removed |Added Attachment #75429|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #2 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Alex Arnaud changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Alex Arnaud changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 --- Comment #1 from Alex Arnaud --- Created attachment 75429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75429&action=edit Bug 20778: Fix subscription deletion. Also remove the first confirmation pop because we have another one. Test plan: - go to a subscription detail page, - click on edit -> delete subscription, - confirm deletion, - check that the subscription is no longer here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/