[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Nick Clemens changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #131 from Nick Clemens --- This needs work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #130 from Katrin Fischer --- Hi Nick, does this still need a follow-up or back to testing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Assignee|k...@bywatersolutions.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Nick Clemens changed: What|Removed |Added Attachment #142651|0 |1 is obsolete|| --- Comment #129 from Nick Clemens --- Created attachment 142829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142829=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record This patchset intends to add the use of MarcItemFieldsToOrder and MarcFieldsToOrder to neworderempty.pl When adding to a basket fomr a staged file the above preferences create orders on addorderiso2709.pl if the records are unique, or if the records have been matched during staging If the records are not matched at staging, but a duplicate is found you must add the orders individually, and the info is not pulled from the incoming record Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l To test: 1 - Stage the sample record for bib303 without looking for matching records (if not using Koha testing docker smaple data import this record, then stage again without matching) 2 - From acqusitions, find a vendor and an open basket and 'Add to basket' 'From a staged file' 3 - On the record in question, check the checbox, then click the 'Add order' link 4 - You are taken to page notifying of duplicate - click 'Use existing record' 5 - You are taken to new order empty, and item forms are prepopulated with order info 6 - Save the orders and confirm all added to basket as expected Additional Authors: Devinim Marcel de Rooy Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
--- Comment #128 from Katrin Fischer ---
3) POD and use of GetMarcItemFieldsToOrderValues don't match up (first param):
+my $data = GetMarcItemFieldsToOrderValues('MarcItemFieldsToOrder',
$marcrecord, ['homebranch', 'holdingbranch', 'itype', 'nonpublic_note',
'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price',
'replacementprice', 'itemcallnumber', 'quantity', 'budget_code']);
my $alliteminfos = Koha::Acquisition::Utils::GetMarcItemFieldsToOrderValues(
$marcrecord, [ 'homebranch', 'holdingbranch', 'itype', 'nonpublic_note',
'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price',
'replacementprice', 'itemcallnumber', 'quantity', 'budget_code' ] );
4) +use C4::Suggestions;# GetSuggestion
Should list all used methods explicitly.
Further testing might also be blocked by bug 32045. :(
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #127 from Katrin Fischer --- I know it's hard to keep on top of bugs with many comments, but 2 issues found here: 1) Method names are not snake case (see comment84, comment#104) 2) I still don't know what to do here in order to test this (see comment#104) The test plan assumes you know a lot of things about the process already. Maybe a test record with 9xx could be supplied? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Attachment #142650|0 |1 is obsolete|| --- Comment #126 from Kyle M Hall --- Created attachment 142651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142651=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record We would like an Acquisitions development that would streamline the workflow of ordering items that already exist in the system (reorders). The ideal workflow would be something along the lines of: 1. Staged files are added to a basket and a duplicate warning is received. You click "Display them" (This step already exists) 2. From this screen, when you click "add order" on an item, you are able to add that order record to an existing bib record using the information in the 9xx fields. Currently this step discards any 9xx information and creates a blank order record. 3. Click "Save" and move on to the next duplicate. Since the ability to add an order to an existing record is already present, we're just looking to add the 9xx information as well. Additional Authors: Devinim Marcel de Rooy Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Assignee|kohadevi...@devinim.com.tr |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Attachment #142646|0 |1 is obsolete|| Attachment #142647|0 |1 is obsolete|| Attachment #142648|0 |1 is obsolete|| Attachment #142649|0 |1 is obsolete|| --- Comment #125 from Kyle M Hall --- Created attachment 142650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142650=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #124 from Kyle M Hall --- Created attachment 142649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142649=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #123 from Kyle M Hall --- Created attachment 142648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142648=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #122 from Kyle M Hall --- Created attachment 142647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142647=edit Bug 20817: Squashed follow-ups * Move subroutines to a new Perl module * Add unit tests * Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues * Rename get_infos_syspref to GetMarcFieldsToOrderValues * Remove syspref from parameters, it is invariant * Fix QA script issues * Update module to use YAML::XS * _trim should always return a value * (QA follow-up) Fix 'undefined subroutine' error * Fix incorrect namespace for subroutine call * Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl * (QA follow-up) Add new parameter for PrepareItemrecordDisplay * (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Attachment #142630|0 |1 is obsolete|| Attachment #142631|0 |1 is obsolete|| Attachment #142632|0 |1 is obsolete|| Attachment #142633|0 |1 is obsolete|| Attachment #142634|0 |1 is obsolete|| Attachment #142635|0 |1 is obsolete|| Attachment #142636|0 |1 is obsolete|| Attachment #142637|0 |1 is obsolete|| Attachment #142638|0 |1 is obsolete|| Attachment #142639|0 |1 is obsolete|| Attachment #142640|0 |1 is obsolete|| Attachment #142641|0 |1 is obsolete|| Attachment #142642|0 |1 is obsolete|| Attachment #142643|0 |1 is obsolete|| Attachment #142644|0 |1 is obsolete|| Attachment #142645|0 |1 is obsolete|| --- Comment #121 from Kyle M Hall --- Created attachment 142646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142646=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #120 from Kyle M Hall --- Created attachment 142645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142645=edit Bug 20817: (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #119 from Kyle M Hall --- Created attachment 142644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142644=edit Bug 20817: (QA follow-up) Add new parameter for PrepareItemrecordDisplay -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #118 from Kyle M Hall --- Created attachment 142643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142643=edit Bug 20817: Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #117 from Kyle M Hall --- Created attachment 142642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142642=edit Bug 20817: Fix incorrect namespace for subroutine call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #116 from Kyle M Hall --- Created attachment 142641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142641=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #115 from Kyle M Hall --- Created attachment 142640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142640=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #114 from Kyle M Hall --- Created attachment 142639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142639=edit Bug 20817: _trim should always return a value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #113 from Kyle M Hall --- Created attachment 142638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142638=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #112 from Kyle M Hall --- Created attachment 142637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142637=edit Bug 20817: Update module to use YAML::XS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #111 from Kyle M Hall --- Created attachment 142636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142636=edit Bug 20817: Fix QA script issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #110 from Kyle M Hall --- Created attachment 142635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142635=edit Bug 20817: Remove syspref from parameters, it is invariant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #106 from Kyle M Hall --- Created attachment 142631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142631=edit Bug 20817: Move subroutines to a new Perl module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #109 from Kyle M Hall --- Created attachment 142634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142634=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #108 from Kyle M Hall --- Created attachment 142633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142633=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #107 from Kyle M Hall --- Created attachment 142632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142632=edit Bug 20817: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Attachment #131734|0 |1 is obsolete|| Attachment #131735|0 |1 is obsolete|| Attachment #131736|0 |1 is obsolete|| Attachment #131737|0 |1 is obsolete|| Attachment #131738|0 |1 is obsolete|| Attachment #131739|0 |1 is obsolete|| Attachment #131740|0 |1 is obsolete|| Attachment #131741|0 |1 is obsolete|| Attachment #131742|0 |1 is obsolete|| Attachment #131743|0 |1 is obsolete|| Attachment #131744|0 |1 is obsolete|| Attachment #131745|0 |1 is obsolete|| Attachment #131746|0 |1 is obsolete|| Attachment #131747|0 |1 is obsolete|| Attachment #131748|0 |1 is obsolete|| Attachment #131749|0 |1 is obsolete|| --- Comment #105 from Kyle M Hall --- Created attachment 142630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142630=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Nick Clemens changed: What|Removed |Added Status|Failed QA |Patch doesn't apply CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #104 from Katrin Fischer --- I am sorry, but I need a more detailed test plan. I am not sure what I am looking for here as I have never really used the stage feature much. Provided test plan: 1) Choose an existing record from "Add order to basket" area either searching a record or clicking "From a staged file" section 2) After you reach "New order" page for existing record you will see new fieldset called "Existing items" which are existing items belong to a record not previously ordered 3) When you choose item(s) from this new tab fields of "Accounting details" tab will be automatically filled 4) When you finished click save button. What I have tried: * Exported "Intermediate Perl" from sample database http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=12 * Add to basket > From a new file * Imported my record * When I look at the MARC view, I can see the 952 Next I tried: * Add to basket > From existing record * Searched for "Intermediate Perl" * Picked it for my order Each time, there was no "Existing items" section on the form. ... and now I am stuck. How do I need to set up the system preferences? What is the behavior I should see? My basket was set to create items on order. Note: We should at least write up a follow-up bug to change the new methods to snake case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #103 from Kyle M Hall --- (In reply to Katrin Fischer from comment #84) > 1) Can you please explain this change in Items.pm? > > This would also affect the item form in serials IIRC. Agreed. I've submitted a followup to return the existing behavior for serials. > 2) GetMarcFieldsToOrderValues in Koha/Acquisition/Utils.pm > 3) GetMarcItemFieldsToOrderValues in Koha/Acquisition/Utils.pm It looks like the original author (Devinim) started with one subroutine that handled both, but ended up forking the subroutine without updated the POD. I've submitted a followup to fix the POD for both subroutines. > 4) Test plan Done as well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #102 from Kyle M Hall --- Created attachment 131749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131749=edit Bug 20817: (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #101 from Kyle M Hall --- Created attachment 131748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131748=edit Bug 20817: (QA follow-up) Add new parameter for PrepareItemrecordDisplay -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #100 from Kyle M Hall --- Created attachment 131747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131747=edit Bug 20817: Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #99 from Kyle M Hall --- Created attachment 131746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131746=edit Bug 20817: Fix incorrect namespace for subroutine call Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #98 from Kyle M Hall --- Created attachment 131745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131745=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #97 from Kyle M Hall --- Created attachment 131744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131744=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #96 from Kyle M Hall --- Created attachment 131743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131743=edit Bug 20817: _trim should always return a value Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #95 from Kyle M Hall --- Created attachment 131742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131742=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #94 from Kyle M Hall --- Created attachment 131741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131741=edit Bug 20817: Update module to use YAML::XS Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #93 from Kyle M Hall --- Created attachment 131740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131740=edit Bug 20817: Fix QA script issues Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #92 from Kyle M Hall --- Created attachment 131739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131739=edit Bug 20817: Remove syspref from parameters, it is invariant Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #91 from Kyle M Hall --- Created attachment 131738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131738=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #90 from Kyle M Hall --- Created attachment 131737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131737=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #89 from Kyle M Hall --- Created attachment 131736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131736=edit Bug 20817: Add unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #88 from Kyle M Hall --- Created attachment 131735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131735=edit Bug 20817: Move subroutines to a new Perl module Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Attachment #128785|0 |1 is obsolete|| Attachment #128786|0 |1 is obsolete|| Attachment #128787|0 |1 is obsolete|| Attachment #128788|0 |1 is obsolete|| Attachment #128789|0 |1 is obsolete|| Attachment #128790|0 |1 is obsolete|| Attachment #128791|0 |1 is obsolete|| Attachment #128792|0 |1 is obsolete|| Attachment #128793|0 |1 is obsolete|| Attachment #128794|0 |1 is obsolete|| Attachment #128795|0 |1 is obsolete|| Attachment #128796|0 |1 is obsolete|| Attachment #128797|0 |1 is obsolete|| Attachment #128798|0 |1 is obsolete|| Attachment #131732|0 |1 is obsolete|| Attachment #131733|0 |1 is obsolete|| --- Comment #87 from Kyle M Hall --- Created attachment 131734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131734=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record 1) Choose an existing record from "Add order to basket" area either searching a record or clicking "From a staged file" section 2) After you reach "New order" page for existing record you will see new fieldset called "Existing items" which are existing items belong to a record not previously ordered 3) When you choose item(s) from this new tab fields of "Accounting details" tab will be automatically filled 4) When you finished click save button. Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=20187 Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #86 from Kyle M Hall --- Created attachment 131733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131733=edit Bug 20817: (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #85 from Kyle M Hall --- Created attachment 131732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131732=edit Bug 20817: (QA follow-up) Add new parameter for PrepareItemrecordDisplay -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #84 from Katrin Fischer ---
1) Can you please explain this change in Items.pm?
This would also affect the item form in serials IIRC.
@@ -1559,6 +1559,8 @@ sub PrepareItemrecordDisplay {
my $itemrecord;
if ($itemnum) {
$itemrecord = C4::Items::GetMarcItem( $bibnum, $itemnum );
+}elsif ($defaultvalues && $defaultvalues->{'itemrecord'} ) {
+$itemrecord = $defaultvalues->{'itemrecord'};
}
2) GetMarcFieldsToOrderValues in Koha/Acquisition/Utils.pm
* Method names in Koha should be using snake case.
* Is it possible that the $syspref parameter has been removed/not implemented?
It appears to be hardcoded to Koha/Acquisition/Utils.pm.
+=head3 GetMarcFieldsToOrderValues($syspref_name, $record, $field_list)
+
+my $data =
Koha::Acquisition::Utils::GetMarcFieldsToOrderValues('MarcFieldsToOrder',
$marcrecord, ['price', 'quantity', 'budget_code', etc.]);
+
+sub GetMarcFieldsToOrderValues {
+my ($record, $field_list) = @_;
+my $syspref = C4::Context->preference('MarcFieldsToOrder');
3) GetMarcItemFieldsToOrderValues in Koha/Acquisition/Utils.pm
Same questions as for 2) actually.
4) Test plan
None of the commit messages contain much of a description or test plan. I found
this - is it still accurate? Could you add some notes for how
GetMarcFieldsToOrder and GetMarcItemFieldsToOrder should be set up/tested? I
haven't used these features so far.
To test:
1) Choose an existing record from "Add order to basket" area either searching a
record or clicking "From a staged file" section
2) After you reach "New order" page for existing record you will see new
fieldset called "Existing items" which are existing items belong to a record
not previously ordered
3) When you choose item(s) from this new tab fields of "Accounting details" tab
will be automatically filled
4) When you finished click save button.
If you could at least enhance the first commit message that would be great.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128783|0 |1 is obsolete|| --- Comment #83 from Andrew Fuerste-Henry --- Created attachment 128798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128798=edit Bug 20817: Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128782|0 |1 is obsolete|| --- Comment #82 from Andrew Fuerste-Henry --- Created attachment 128797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128797=edit Bug 20817: Fix incorrect namespace for subroutine call Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128777|0 |1 is obsolete|| --- Comment #81 from Andrew Fuerste-Henry --- Created attachment 128796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128796=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128776|0 |1 is obsolete|| --- Comment #80 from Andrew Fuerste-Henry --- Created attachment 128795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128795=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128775|0 |1 is obsolete|| --- Comment #79 from Andrew Fuerste-Henry --- Created attachment 128794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128794=edit Bug 20817: _trim should always return a value Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128774|0 |1 is obsolete|| --- Comment #78 from Andrew Fuerste-Henry --- Created attachment 128793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128793=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128773|0 |1 is obsolete|| --- Comment #77 from Andrew Fuerste-Henry --- Created attachment 128792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128792=edit Bug 20817: Update module to use YAML::XS Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128772|0 |1 is obsolete|| --- Comment #76 from Andrew Fuerste-Henry --- Created attachment 128791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128791=edit Bug 20817: Fix QA script issues Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128771|0 |1 is obsolete|| --- Comment #75 from Andrew Fuerste-Henry --- Created attachment 128790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128790=edit Bug 20817: Remove syspref from parameters, it is invariant Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128770|0 |1 is obsolete|| --- Comment #74 from Andrew Fuerste-Henry --- Created attachment 128789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128789=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128769|0 |1 is obsolete|| --- Comment #73 from Andrew Fuerste-Henry --- Created attachment 128788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128788=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128768|0 |1 is obsolete|| --- Comment #72 from Andrew Fuerste-Henry --- Created attachment 128787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128787=edit Bug 20817: Add unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128767|0 |1 is obsolete|| --- Comment #71 from Andrew Fuerste-Henry --- Created attachment 128786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128786=edit Bug 20817: Move subroutines to a new Perl module Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #128766|0 |1 is obsolete|| --- Comment #70 from Andrew Fuerste-Henry --- Created attachment 128785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128785=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=20187 Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #69 from Kyle M Hall --- Created attachment 128783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128783=edit Bug 20817: Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #68 from Kyle M Hall --- Created attachment 128782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128782=edit Bug 20817: Fix incorrect namespace for subroutine call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #67 from Andrew Fuerste-Henry --- I'm getting an error trying to test this. With the patch applied, I get a duplicate warning when trying to submit my order, click "Use existing" from the dupe check page, and get this error: Undefined subroutine ::Acquisition::Utils::GetMarcItemFieldsToOrderValues called at /kohadevbox/koha/acqui/neworderempty.pl line 652 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #66 from Kyle M Hall --- Created attachment 128777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128777=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #65 from Kyle M Hall --- Created attachment 128776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128776=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #64 from Kyle M Hall --- Created attachment 128775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128775=edit Bug 20817: _trim should always return a value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #63 from Kyle M Hall --- Created attachment 128774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128774=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #62 from Kyle M Hall --- Created attachment 128773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128773=edit Bug 20817: Update module to use YAML::XS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #61 from Kyle M Hall --- Created attachment 128772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128772=edit Bug 20817: Fix QA script issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #60 from Kyle M Hall --- Created attachment 128771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128771=edit Bug 20817: Remove syspref from parameters, it is invariant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #59 from Kyle M Hall --- Created attachment 128770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128770=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #58 from Kyle M Hall --- Created attachment 128769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128769=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #57 from Kyle M Hall --- Created attachment 128768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128768=edit Bug 20817: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #56 from Kyle M Hall --- Created attachment 128767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128767=edit Bug 20817: Move subroutines to a new Perl module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Attachment #118371|0 |1 is obsolete|| Attachment #118372|0 |1 is obsolete|| Attachment #118373|0 |1 is obsolete|| Attachment #118374|0 |1 is obsolete|| Attachment #118375|0 |1 is obsolete|| Attachment #118376|0 |1 is obsolete|| Attachment #118377|0 |1 is obsolete|| Attachment #118378|0 |1 is obsolete|| Attachment #122692|0 |1 is obsolete|| Attachment #122834|0 |1 is obsolete|| Attachment #122841|0 |1 is obsolete|| Attachment #122858|0 |1 is obsolete|| Attachment #122861|0 |1 is obsolete|| --- Comment #55 from Kyle M Hall --- Created attachment 128766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128766=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #54 from Tomás Cohen Arazi --- Hi, get_infos_syspref() should be using C4::Context->yaml_preference instead of manually dealing with YAML. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #53 from David Cook --- (In reply to Kyle M Hall from comment #52) > (In reply to Jonathan Druart from comment #51) > > "Util" sounds wrong, it's a too generic term IMO. > > Choose a replacement word and I'll make it happen! Looking at Nick's email "Helper/Static methods for objects", I'm curious why we'd create a Util module and not just use static/class methods from the relevant Koha::Acquisitions namespace (probably Koha::Acquisition::Orders in this case?). I had a similar dilemma the other day on a different project. I almost made a Utils module, but then I realized that would just fragment my application model more, so I added a static/class method, and kept everything together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #52 from Kyle M Hall --- (In reply to Jonathan Druart from comment #51) > "Util" sounds wrong, it's a too generic term IMO. Choose a replacement word and I'll make it happen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #51 from Jonathan Druart --- "Util" sounds wrong, it's a too generic term IMO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #50 from Marcel de Rooy ---
acqui/neworderempty.pl:my ($marcrecord, $encoding) =
MARCfindbreeding($params->{'breedingid'});
acqui/neworderempty.pl:=head2 MARCfindbreeding
acqui/neworderempty.pl: $record = MARCfindbreeding($breedingid);
acqui/neworderempty.pl:sub MARCfindbreeding {
acqui/neworderempty.pl:my ($marcrecord, $encoding) =
MARCfindbreeding($breedingid);
authorities/authorities.pl:sub MARCfindbreeding_auth {
authorities/authorities.pl:( $record, $encoding ) = MARCfindbreeding_auth(
$breedingid );
cataloguing/addbiblio.pl:=head2 MARCfindbreeding
cataloguing/addbiblio.pl:$record = MARCfindbreeding($breedingid);
cataloguing/addbiblio.pl:sub MARCfindbreeding {
cataloguing/addbiblio.pl:( $record, $encoding ) = MARCfindbreeding(
$breedingid ) ;
=> Can we consolidate this in a module ?
Do we need a (small) extra test for the new itemrecord parameter in
PrepareItemrecordDisplay ?
Another crash:
my $alliteminfos = C4::Acquisition::Utils::GetMarcItemFieldsToOrderValues(
$marcrecord, [ 'homebranch', 'holdingbranch', 'itype', 'nonpublic_note',
'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price',
'replacementprice', 'itemcallnumber', 'quantity', 'budget_code' ] );
Test plan
The whole workflow is not completely clear to me here. We should have a solid
test plan that tells me how I can verify it this development really works as we
hope it does.
With the changes and time passed, a new signoff from someone with Acquisition
experience would be welcome.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #49 from Marcel de Rooy --- Created attachment 122861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122861=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #48 from Marcel de Rooy --- Created attachment 122858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122858=edit Bug 20817: (QA follow-up) Add missing module Output This resolves a perl -cw warning: Useless use of a variable in void context at acqui/neworderempty.pl line 700. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #47 from Marcel de Rooy --- To clear: Useless use of a variable in void context at acqui/neworderempty.pl line 700. You need to look at line 492 output_html_with_http_headers $input, $cookie, $template->output; And then understand that the C4::Output module was not included yet at the start of the file. Hmm ;) Adding a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #46 from Marcel de Rooy --- Having another look here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #45 from Kyle M Hall --- Created attachment 122841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122841=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
