[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin SOMERS --- Depends on Bug 16735 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #13 from Martin Renvoize --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Pushed to master for 18.11, awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Jonathan Druart changed: What|Removed |Added Blocks||20875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 [Bug 20875] OpacAddMastheadLibraryPulldown displays an empty list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 --- Comment #11 from Jonathan Druart --- (In reply to Nick Clemens from comment #10) > I am having issues testing this - when I enable > "OpacAddMastheadLibraryPulldown" I don't have a list of libraries and my > group doesn't show any values Right, it's another bug. I am going to deal with it on a separate bug report. To test this one you need to use the advanced search form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- I am having issues testing this - when I enable "OpacAddMastheadLibraryPulldown" I don't have a list of libraries and my group doesn't show any values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 --- Comment #9 from Jonathan Druart --- Created attachment 75739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75739=edit Bug 20838: Add 2 small tests to check ref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #8 from Marcel de Rooy --- Test coverage of all_libraries is rather limited.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added Attachment #75701|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 75732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75732=edit Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries Instead of a list of Koha::Library::Group Ideally it should be a Koh::Libraries iterator Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added Attachment #75700|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 75731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75731=edit Bug 20838: (bug 16735 follow-up) Fix search by group of libraries In the last patches of bug 16735, we completely broke the feature! The limit is using library_groups.id instead of branches.branchcode. Test plan: Create a group of library with the search feature Search (OPAC and staff interfaces) using this limit => Without this patch you will see that the generated search query does not contain branchcodes => With this patch applied you will see the branchcodes Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #5 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 --- Comment #4 from Kyle M Hall --- Created attachment 75701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75701=edit Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries Instead of a list of Koha::Library::Group Ideally it should be a Koh::Libraries iterator Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Kyle M Hall changed: What|Removed |Added Attachment #75686|0 |1 is obsolete|| Attachment #75687|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 75700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75700=edit Bug 20838: (bug 16735 follow-up) Fix search by group of libraries In the last patches of bug 16735, we completely broke the feature! The limit is using library_groups.id instead of branches.branchcode. Test plan: Create a group of library with the search feature Search (OPAC and staff interfaces) using this limit => Without this patch you will see that the generated search query does not contain branchcodes => With this patch applied you will see the branchcodes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Ata ur Rehman changed: What|Removed |Added CC||ata.reh...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 --- Comment #2 from Jonathan Druart --- Created attachment 75687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75687=edit Bug 20838: Make Koha::Library::Group->all_libraries return a list of Koha::Libraries Instead of a list of Koha::Library::Group Ideally it should be a Koh::Libraries iterator -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 --- Comment #1 from Jonathan Druart --- Created attachment 75686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75686=edit Bug 20838: (bug 16735 follow-up) Fix search by group of libraries In the last patches of bug 16735, we completely broke the feature! The limit is using library_groups.id instead of branches.branchcode. Test plan: Create a group of library with the search feature Search (OPAC and staff interfaces) using this limit => Without this patch you will see that the generated search query does not contain branchcodes => With this patch applied you will see the branchcodes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20838] Search by group of libraries is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 Jonathan Druart changed: What|Removed |Added Summary|Search by group of |Search by group of |libraries |libraries is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
