[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #96 from Kyle M Hall --- Created attachment 85294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85294&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #95 from Kyle M Hall --- Created attachment 85293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85293&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #94 from Kyle M Hall --- Created attachment 85292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85292&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall changed: What|Removed |Added Attachment #84707|0 |1 is obsolete|| Attachment #84708|0 |1 is obsolete|| Attachment #84709|0 |1 is obsolete|| Attachment #84710|0 |1 is obsolete|| Attachment #84711|0 |1 is obsolete|| Attachment #84712|0 |1 is obsolete|| Attachment #84713|0 |1 is obsolete|| Attachment #84714|0 |1 is obsolete|| Attachment #84715|0 |1 is obsolete|| Attachment #84716|0 |1 is obsolete|| Attachment #84717|0 |1 is obsolete|| Attachment #84718|0 |1 is obsolete|| Attachment #84719|0 |1 is obsolete|| Attachment #84720|0 |1 is obsolete|| Attachment #84721|0 |1 is obsolete|| Attachment #84722|0 |1 is obsolete|| Attachment #84723|0 |1 is obsolete|| Attachment #84724|0 |1 is obsolete|| --- Comment #93 from Kyle M Hall --- Created attachment 85291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85291&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #104 from Kyle M Hall --- Created attachment 85302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85302&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #101 from Kyle M Hall --- Created attachment 85299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85299&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #103 from Kyle M Hall --- Created attachment 85301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85301&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #105 from Kyle M Hall --- Created attachment 85303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85303&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #98 from Kyle M Hall --- Created attachment 85296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85296&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #99 from Kyle M Hall --- Created attachment 85297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85297&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #100 from Kyle M Hall --- Created attachment 85298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85298&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #97 from Kyle M Hall --- Created attachment 85295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85295&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #102 from Kyle M Hall --- Created attachment 85300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85300&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #106 from Kyle M Hall --- Created attachment 85304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85304&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #109 from Kyle M Hall --- Created attachment 85307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85307&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #107 from Kyle M Hall --- Created attachment 85305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85305&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #108 from Kyle M Hall --- Created attachment 85306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85306&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #110 from Kyle M Hall --- Created attachment 85308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85308&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #111 from Martin Renvoize --- Not strictly a blocker for 14825, but I believe it will cause a requirement to rebase or at least revisit the affected routine for the add_devit/add_credit conversion tree so I'm adding it there to aid my own tracking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #112 from Nick Clemens --- Couple things: 1 - Early renewals: The patron is charged for the full checkout duration on each renewal - I think they should only be charged for the additional days? or at least only for the renewal period? - if renewal period base is 'current day' and the checkout is not extended by the renewal I think they should not be charged, or charged only the renewal period - if the renewal period base is 'old due date' then they are charged for only added days 2 - The OPAC patron summary lists any general rental fees, but does not list the periodic rental fees - ideally I think the patron would have to confirm acceptance of charges before completing the transaction, but warning ahead of time is needed at a minimum - I can file a new bug for confirmation of renewing with rental charges -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #113 from Martin Renvoize --- Created attachment 85316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85316&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #114 from Martin Renvoize --- Followup added to fix the first issue Nick found.. can't believe that got through so many QA eyes.. it was even incorrectly tested for in the tests, highlighting the issue. I'm not sure I fully understand your second comment though Nick... is that something that can go in a second bug with a clear description of what you think should happen? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Depends on||21721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85292|0 |1 is obsolete|| --- Comment #116 from Martin Renvoize --- Created attachment 85544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85544&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85293|0 |1 is obsolete|| --- Comment #117 from Martin Renvoize --- Created attachment 85545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85545&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85291|0 |1 is obsolete|| --- Comment #115 from Martin Renvoize --- Created attachment 85543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85543&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85300|0 |1 is obsolete|| --- Comment #124 from Martin Renvoize --- Created attachment 85552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85552&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85301|0 |1 is obsolete|| --- Comment #125 from Martin Renvoize --- Created attachment 85553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85553&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85298|0 |1 is obsolete|| --- Comment #122 from Martin Renvoize --- Created attachment 85550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85550&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85299|0 |1 is obsolete|| --- Comment #123 from Martin Renvoize --- Created attachment 85551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85551&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85296|0 |1 is obsolete|| --- Comment #120 from Martin Renvoize --- Created attachment 85548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85548&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85303|0 |1 is obsolete|| --- Comment #127 from Martin Renvoize --- Created attachment 8 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85304|0 |1 is obsolete|| --- Comment #128 from Martin Renvoize --- Created attachment 85556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85556&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85316|0 |1 is obsolete|| --- Comment #133 from Martin Renvoize --- Created attachment 85561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85561&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85308|0 |1 is obsolete|| --- Comment #132 from Martin Renvoize --- Created attachment 85560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85560&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85294|0 |1 is obsolete|| --- Comment #118 from Martin Renvoize --- Created attachment 85546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85546&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85295|0 |1 is obsolete|| --- Comment #119 from Martin Renvoize --- Created attachment 85547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85547&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85307|0 |1 is obsolete|| --- Comment #131 from Martin Renvoize --- Created attachment 85559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85559&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85306|0 |1 is obsolete|| --- Comment #130 from Martin Renvoize --- Created attachment 85558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85558&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85305|0 |1 is obsolete|| --- Comment #129 from Martin Renvoize --- Created attachment 85557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85557&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85302|0 |1 is obsolete|| --- Comment #126 from Martin Renvoize --- Created attachment 85554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85554&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85297|0 |1 is obsolete|| --- Comment #121 from Martin Renvoize --- Created attachment 85549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85549&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #134 from Martin Renvoize --- Minor rebase to fit it on top of the add_debits accounts bug tree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #135 from Martin Renvoize --- (In reply to Nick Clemens from comment #112) > 2 - The OPAC patron summary lists any general rental fees, but does not list > the periodic rental fees - ideally I think the patron would have to confirm > acceptance of charges before completing the transaction, but warning ahead > of time is needed at a minimum - I can file a new bug for confirmation of > renewing with rental charges OK, I understand now.. I'll mark it back to failed qa.. hopefully one of us will get to it some time soon. In short, I think we need to add Koha::Charges::Fees into opac/opac-user.pl to add in predicted renewal fees for a period based fee so that they display in the checkouts table where the user can opt to renew items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #136 from Kyle M Hall --- (In reply to Martin Renvoize from comment #135) > (In reply to Nick Clemens from comment #112) > > 2 - The OPAC patron summary lists any general rental fees, but does not list > > the periodic rental fees - ideally I think the patron would have to confirm > > acceptance of charges before completing the transaction, but warning ahead > > of time is needed at a minimum - I can file a new bug for confirmation of > > renewing with rental charges > > OK, I understand now.. I'll mark it back to failed qa.. hopefully one of us > will get to it some time soon. > > In short, I think we need to add Koha::Charges::Fees into opac/opac-user.pl > to add in predicted renewal fees for a period based fee so that they display > in the checkouts table where the user can opt to renew items. Does the existing rental charge do this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #137 from Martin Renvoize --- Yup, nick even showed me a screenshot 😉. It's not obvious though to be fair, it's just a note within renew field of the table. It's says "Fee for item type 'Book': 1.00" - https://snag.gy/MWntYk.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #138 from Katrin Fischer --- (In reply to Martin Renvoize from comment #137) > Yup, nick even showed me a screenshot 😉. It's not obvious though to be > fair, it's just a note within renew field of the table. It's says "Fee for > item type 'Book': 1.00" - https://snag.gy/MWntYk.jpg I think this was added not too long ago, which might explain it not being well known: Bug 13796 - Alert in OPAC when renewing an item with a rental charge (signed by Kyle :) ) I agree that information/confirmation is needed before charging from a user's point of view, but I think also probably legally in some cases. I remember discussions here about labelling buttons for ordering clearly. Better to be safe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #139 from Kyle M Hall --- Created attachment 85628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85628&action=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall changed: What|Removed |Added Attachment #85628|0 |1 is obsolete|| --- Comment #140 from Kyle M Hall --- Created attachment 85631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85631&action=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Blocks||17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85544|0 |1 is obsolete|| --- Comment #142 from Martin Renvoize --- Created attachment 86141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86141&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85547|0 |1 is obsolete|| --- Comment #145 from Martin Renvoize --- Created attachment 86144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86144&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85548|0 |1 is obsolete|| --- Comment #146 from Martin Renvoize --- Created attachment 86145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86145&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85543|0 |1 is obsolete|| --- Comment #141 from Martin Renvoize --- Created attachment 86140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86140&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85549|0 |1 is obsolete|| --- Comment #147 from Martin Renvoize --- Created attachment 86146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86146&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85546|0 |1 is obsolete|| --- Comment #144 from Martin Renvoize --- Created attachment 86143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86143&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85545|0 |1 is obsolete|| --- Comment #143 from Martin Renvoize --- Created attachment 86142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86142&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85552|0 |1 is obsolete|| --- Comment #150 from Martin Renvoize --- Created attachment 86149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86149&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85556|0 |1 is obsolete|| --- Comment #154 from Martin Renvoize --- Created attachment 86154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86154&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85553|0 |1 is obsolete|| --- Comment #151 from Martin Renvoize --- Created attachment 86151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86151&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #8|0 |1 is obsolete|| --- Comment #153 from Martin Renvoize --- Created attachment 86153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86153&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85558|0 |1 is obsolete|| --- Comment #156 from Martin Renvoize --- Created attachment 86156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86156&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85631|0 |1 is obsolete|| --- Comment #160 from Martin Renvoize --- Created attachment 86160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86160&action=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85561|0 |1 is obsolete|| --- Comment #159 from Martin Renvoize --- Created attachment 86159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86159&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85559|0 |1 is obsolete|| --- Comment #157 from Martin Renvoize --- Created attachment 86157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86157&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85560|0 |1 is obsolete|| --- Comment #158 from Martin Renvoize --- Created attachment 86158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86158&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85551|0 |1 is obsolete|| --- Comment #149 from Martin Renvoize --- Created attachment 86148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86148&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85550|0 |1 is obsolete|| --- Comment #148 from Martin Renvoize --- Created attachment 86147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86147&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85554|0 |1 is obsolete|| --- Comment #152 from Martin Renvoize --- Created attachment 86152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86152&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85557|0 |1 is obsolete|| --- Comment #155 from Martin Renvoize --- Created attachment 86155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86155&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86142|0 |1 is obsolete|| --- Comment #163 from Martin Renvoize --- Created attachment 86246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86246&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86141|0 |1 is obsolete|| --- Comment #162 from Martin Renvoize --- Created attachment 86245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86245&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86143|0 |1 is obsolete|| --- Comment #164 from Martin Renvoize --- Created attachment 86247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86247&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86140|0 |1 is obsolete|| --- Comment #161 from Martin Renvoize --- Created attachment 86244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86244&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86144|0 |1 is obsolete|| --- Comment #165 from Martin Renvoize --- Created attachment 86248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86248&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86145|0 |1 is obsolete|| --- Comment #166 from Martin Renvoize --- Created attachment 86249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86249&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86147|0 |1 is obsolete|| --- Comment #168 from Martin Renvoize --- Created attachment 86251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86251&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86146|0 |1 is obsolete|| --- Comment #167 from Martin Renvoize --- Created attachment 86250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86250&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86148|0 |1 is obsolete|| --- Comment #169 from Martin Renvoize --- Created attachment 86252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86252&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86149|0 |1 is obsolete|| --- Comment #170 from Martin Renvoize --- Created attachment 86253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86253&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86151|0 |1 is obsolete|| --- Comment #171 from Martin Renvoize --- Created attachment 86254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86254&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86154|0 |1 is obsolete|| --- Comment #174 from Martin Renvoize --- Created attachment 86257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86257&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86153|0 |1 is obsolete|| --- Comment #173 from Martin Renvoize --- Created attachment 86256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86256&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86155|0 |1 is obsolete|| --- Comment #175 from Martin Renvoize --- Created attachment 86258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86258&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86152|0 |1 is obsolete|| --- Comment #172 from Martin Renvoize --- Created attachment 86255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86255&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86159|0 |1 is obsolete|| --- Comment #179 from Martin Renvoize --- Created attachment 86262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86262&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86158|0 |1 is obsolete|| --- Comment #178 from Martin Renvoize --- Created attachment 86261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86261&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86160|0 |1 is obsolete|| --- Comment #180 from Martin Renvoize --- Created attachment 86263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86263&action=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86156|0 |1 is obsolete|| --- Comment #176 from Martin Renvoize --- Created attachment 86259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86259&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86157|0 |1 is obsolete|| --- Comment #177 from Martin Renvoize --- Created attachment 86260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86260&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #181 from Martin Renvoize --- Created attachment 86264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86264&action=edit Bug 20912: (QA follow-up) Rebase error corrections The automatic rebase after bug 21206 required a helping hand. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #182 from Martin Renvoize --- Fresh rebase, should all be working again now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86245|0 |1 is obsolete|| --- Comment #184 from Martin Renvoize --- Created attachment 86283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86283&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
