[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03, always nice to tidy up a bit :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Marcel de Rooy changed: What|Removed |Added Attachment #76762|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 76970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76970&action=edit Bug 20974: Remove files left behind after removing Solr Some files were left behind when Bug 12538 removed support for Solr. This patch removes them. To test, apply the patch and fail to observe the existence of these files: koha-tmpl/opac-tmpl/bootstrap/en/includes/search/facets.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/page-numbers.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/resort_form.inc Perform a search in the OPAC to confirm that nothing broke. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 --- Comment #5 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #4) > Hi Marcel, please take a closer look. There are small differences: > > > 1) git grep -E "INCLUDE [']?facets.inc" > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:[% INCLUDE > 'facets.inc' %] > > This is the intranet version of the file. The patch removes from bootstrap. > > 2) git grep -E "INCLUDE [']?page-numbers.inc" > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: > [% INCLUDE 'page-numbers.inc' %] > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:[% > INCLUDE 'page-numbers.inc' %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt: > [% INCLUDE 'page-numbers.inc' %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: > [% INCLUDE 'page-numbers.inc' %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: > [% INCLUDE 'page-numbers.inc' %] > > The file removed is from includes/search/, not includes. The file in > includes is still there. > > 3) git grep -E "INCLUDE [']?resort_form.inc" > Same for this one, the difference is includes/search vs. includes. Hmm. Sorry for overlooking this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Failed QA |Signed Off --- Comment #4 from Katrin Fischer --- Hi Marcel, please take a closer look. There are small differences: 1) git grep -E "INCLUDE [']?facets.inc" koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:[% INCLUDE 'facets.inc' %] This is the intranet version of the file. The patch removes from bootstrap. 2) git grep -E "INCLUDE [']?page-numbers.inc" koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:[% INCLUDE 'page-numbers.inc' %] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:[% INCLUDE 'page-numbers.inc' %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt: [% INCLUDE 'page-numbers.inc' %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: [% INCLUDE 'page-numbers.inc' %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: [% INCLUDE 'page-numbers.inc' %] The file removed is from includes/search/, not includes. The file in includes is still there. 3) git grep -E "INCLUDE [']?resort_form.inc" Same for this one, the difference is includes/search vs. includes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- How did you test this, guys? git grep -E "INCLUDE [']?facets.inc" git grep -E "INCLUDE [']?page-numbers.inc" git grep -E "INCLUDE [']?resort_form.inc" Every statement still produces results ! "Perform a search in the OPAC" is stated too simply? The test depends on more settings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Katrin Fischer changed: What|Removed |Added Attachment #76229|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76762&action=edit Bug 20974: Remove files left behind after removing Solr Some files were left behind when Bug 12538 removed support for Solr. This patch removes them. To test, apply the patch and fail to observe the existence of these files: koha-tmpl/opac-tmpl/bootstrap/en/includes/search/facets.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/page-numbers.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/resort_form.inc Perform a search in the OPAC to confirm that nothing broke. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 --- Comment #1 from Owen Leonard --- Created attachment 76229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76229&action=edit Bug 20974: Remove files left behind after removing Solr Some files were left behind when Bug 12538 removed support for Solr. This patch removes them. To test, apply the patch and fail to observe the existence of these files: koha-tmpl/opac-tmpl/bootstrap/en/includes/search/facets.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/page-numbers.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/resort_form.inc Perform a search in the OPAC to confirm that nothing broke. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
