[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19297 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11999 CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com --- Comment #1 from Arthur Suzuki --- Isn't this a duplicate of 19294 since HoldTitle and HoldItem calls CanBookBeReserved and CanItemBeReserved to check if reference can be reserved? Or does it solves 19294? -> I guess so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Blocks||19294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #2 from Arthur Suzuki --- Created attachment 86874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86874&action=edit Bug 20985 : Add OnShelfHoldsAllowed checks to CanItemBeReserved Test plan : 1 / Check that default circulation have OnShelfHoldsAllowed to Yes 2 / Place a hold on a book with a single item, item being available for loan, verify that hold can be placed. 3 / Set OnShelfHoldsAllowed to any other value, verify that hold cannot be placed for reason "onShelfHoldsNotAllowed" (shown in the item table). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |arthur.suz...@biblibre.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||hayleymap...@catalyst.net.n ||z --- Comment #3 from Hayley Mapley --- This patch results in a runtime error. Here are the steps I followed which led to the error. - Checked default circulation rule - OnShelfHoldsAllowed is set to yes - Clicked Place hold on a biblio with one available item - Entered card number - error! Error trace: Can't call method "effective_itemtype" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 1181 1.in C4::Reserves::IsAvailableForItemLevelRequest at /home/vagrant/kohaclone/C4/Reserves.pm line 1181 1178: # consolidated 1179: my $patron = Koha::Patrons->find( $borrower->{borrowernumber} ); 1180: my $item_object = Koha::Items->find( $item->{itemnumber } ); 1181: my $itemtype = $item_object->effective_itemtype; 1182: my $notforloan_per_itemtype 1183: = $dbh->selectrow_array("SELECT notforloan FROM itemtypes WHERE itemtype = ?", 1184: undef, $itemtype); 2.in C4::Reserves::CanItemBeReserved at /home/vagrant/kohaclone/C4/Reserves.pm line 332 329: && !C4::Context->preference('AllowHoldsOnDamagedItems') ); 330: 331: # Check for item on shelves and OnShelfHoldsAllowed 332: return { status => 'onShelfHoldsNotAllowed' } 333: unless ( IsAvailableForItemLevelRequest($item,$borrower) ); 334: 335: # Check for the age restriction 3.in C4::Reserves::CanBookBeReserved at /home/vagrant/kohaclone/C4/Reserves.pm line 286 283: 284: my $canReserve = { status => '' }; 285: foreach my $itemnumber (@itemnumbers) { 286: $canReserve = CanItemBeReserved( $borrowernumber, $itemnumber, $pickup_branchcode ); 287: return { status => 'OK' } if $canReserve->{status} eq 'OK'; 288: } 289: return $canReserve; Setting to Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Nick Clemens changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #4 from Nick Clemens --- *** Bug 19294 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Depends on||25408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #89723|0 |1 is obsolete|| --- Comment #9 from Arthur Suzuki --- Created attachment 105991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105991&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved Test plan : 1 / Check that default circulation have OnShelfHoldsAllowed to Yes 2 / Place a hold on a book with a single item, item being available for loan, verify that hold can be placed. 3 / Set OnShelfHoldsAllowed to any other value, verify that hold cannot be placed for reason "onShelfHoldsNotAllowed" (shown in the item table). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #115732|0 |1 is obsolete|| --- Comment #27 from Arthur Suzuki --- Created attachment 121100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121100&action=edit Bug 20985: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #115733|0 |1 is obsolete|| --- Comment #28 from Arthur Suzuki --- Created attachment 121101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121101&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #121101|0 |1 is obsolete|| --- Comment #29 from Arthur Suzuki --- Created attachment 121102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121102&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #30 from Arthur Suzuki --- Hi Joubu, I've re-applied on top of master + removed opacitemholds variable. on_shelf_holds variable is used. Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #31 from David Nind --- Hi Arthur. I quickly ran through the test plan. Everything works as expected, except the tests fail. If I manually update the number of tests to 68, everything passes. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #121100|0 |1 is obsolete|| --- Comment #32 from Arthur Suzuki --- Created attachment 121139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121139&action=edit Bug 20985: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #33 from Arthur Suzuki --- Hi David, just pushed a new version of the test patch with number of tests updated. Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #34 from David Nind --- Path no longer applies 8-(... error: sha1 information is lacking or useless (t/db_dependent/Reserves.t). error: could not build fake ancestor Patch failed at 0001 Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #121102|0 |1 is obsolete|| --- Comment #35 from Arthur Suzuki --- Created attachment 121176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121176&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #36 from Arthur Suzuki --- Hi David, Can you retry? seems the patches have to be uploaded in the proper order to be applied the same... Should work now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #37 from David Nind --- > Should work now. Everything works now - sign off on the way.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Attachment #121176|0 |1 is obsolete|| --- Comment #39 from David Nind --- Created attachment 121186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121186&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Attachment #121139|0 |1 is obsolete|| --- Comment #38 from David Nind --- Created attachment 121185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121185&action=edit Bug 20985: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #40 from Arthur Suzuki --- Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Kyle M Hall changed: What|Removed |Added Attachment #121185|0 |1 is obsolete|| Attachment #121186|0 |1 is obsolete|| --- Comment #41 from Kyle M Hall --- Created attachment 121485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121485&action=edit Bug 20985: Unit tests Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #42 from Kyle M Hall --- Created attachment 121486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121486&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #43 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #44 from Jonathan Druart --- There are tons of tests failing. t/db_dependent/Holds.t, t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t, t/db_dependent/api/v1/holds.t, t/db_dependent/ILSDI_Services.t and t/db_dependent/Reserves/MultiplePerRecord.t. Please fix ASAP or I will revert. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #45 from Arthur Suzuki --- Joubu, can you revert? otherwise I cannot apply to master (conflicts) + if solving the problem in master i'm afraid to run into issues applying the patch afterward (fake ancestor). Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Jonathan Druart changed: What|Removed |Added Text to go in the|This bug fixes the "On |This bug fixes the "On release notes|shelf holds allowed" rules |shelf holds allowed" rules |so that they work correctly |so that they work correctly |when using ILS-DI to place |when using ILS-DI to place |holds. |holds. | | |The expected|The expected |behaviour for "On shelf |behaviour for "On shelf |holds allowed" settings for |holds allowed" settings for |the circulation rules (Koha |the circulation rules (Koha |administration > Patrons|administration > Patrons |and circulation > |and circulation > |Circulation and fines |Circulation and fines |rules) are: |rules) are: |- If set to |- If set to |"Yes", patrons can place|"Yes", patrons can place |holds on items currently|holds on items currently |checked in. |checked in. |- If set to "If |- If set to "If |any unavailable", patrons |any unavailable", patrons |can only place holds on |can only place holds on |items that are not |items that are not |unavailable. |unavailable. |- If set to |- If set to |"If all unavailable", |"If all unavailable", |patrons can only place |patrons can only place |holds on items where *all* |holds on items where *all* |items on the record are |items on the record are |unavailable.|unavailable. || ||RMNOTE: ||Reverted! Status|Pushed to master|ASSIGNED Version(s)|21.11.00| released in|| --- Comment #46 from Jonathan Druart --- Patches reverted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #47 from Fridolin Somers --- +# Check for item on shelves and OnShelfHoldsAllowed +return { status => 'onShelfHoldsNotAllowed' } +unless IsAvailableForItemLevelRequest($item, $patron, $pickup_branchcode,1); Strange : IsAvailableForItemLevelRequest() is not the feature of on shelf holds allowed, it means hold can be on item level or forced to biblio level o_O -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Fridolin Somers changed: What|Removed |Added Blocks|19294 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #48 from David Cook --- If I recall correctly, consideration of hold rules is a mess across the board. I keep thinking that we need to do something that covers them all otherwise all the changes will always just be Band-Aids. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Depends on|25408 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #26 from Joonas Kylmälä --- The patch doesn't apply. The patch seems to also introduce some unused code, e.g. > +my $on_shelf_holds = 0; # Default to "if any unavailable" > +my $opacitemholds = 'Y'; # Itemlevel holds default to allowed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #105991|0 |1 is obsolete|| --- Comment #10 from Arthur Suzuki --- Created attachment 110095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110095&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved Test plan : 1 / Check that default circulation have OnShelfHoldsAllowed to Yes 2 / Place a hold on a book with a single item, item being available for loan, verify that hold can be placed. 3 / Set OnShelfHoldsAllowed to any other value, verify that hold cannot be placed for reason "onShelfHoldsNotAllowed" (shown in the item table). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26463 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #11 from David Nind --- Sorry Arthur, I found this one very confusing to test as I am not very familiar with setting circulation rules and the "On shelf holds allowed". I wasn't sure what this bug fixes or what we are testing for (no explanation before the test). So probably better if someone else more familiar tests this. 1. At first I thought these were system preferences, but these are the Perl code names variable/routine used to check the rules. 2. Are you supposed to test with the staff interface or using ILS-DI, or both? I only tested using the staff interface. 3. I wasn't really sure what was different between before the patch was applied and after - the only behaviour change I could see was the text appearing in the hold column (red X vs red "X onShelfHoldsNotAllowed"), which didn't seem to be useful to me as a "normal" user. My notes Expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) Testing using staff interface: 1. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 2. Set "On shelf holds allowed" to "Yes" for all libraries/patron categories/item types. 3. Place a hold on a record with a single item (where the item is available for loan) . I placed a hold for an item and patron both in/belonging to the Centerville library. . Information column in the item table displays "Not on hold". 4. The hold is placed. 5. Cancel the hold. 6. Set "On shelf holds allowed" to either "If any unavailable" or "If all unavailable" for all patrons/patron categories/item types. 7. The hold is not placed: . Message is "Cannot place hold. No items are available to be placed on hold." . Item table: Hold column displays in red "X onShelfHoldsNotAllowed" and the information column displays "Not on hold". 8. Run the tests prove t/db_dependent/Reserves.t - these should pass Tests fail -- Also, the tests fail 8-( : prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 24/63 Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line 597. Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line 597. Use of uninitialized value $opacitemholds in string eq at /kohadevbox/koha/C4/Reserves.pm line 440. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 451. Use of uninitialized value $opacitemholds in string eq at /kohadevbox/koha/C4/Reserves.pm line 440. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 451. t/db_dependent/Reserves.t .. 58/63 Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 451. # Failed test 'record-level holds should not be possible with opacitemholds set to "Force"' # at t/db_dependent/Reserves.t line 1012. # got: 'OK' # expected: 'RecordHoldNotAllowed' Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 451. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 451. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 451. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 451. # Looks like you failed 1 test of 6. # Failed test 'test opacitemholds rules' # at t/db_dependent/Reserves.t line 1080. # Looks like you planned 2 tests but ran 3. # Looks like you failed 1 test of 3 run. t/db_dependent/Reserves.t .. 61/63 # Failed test 'reserves.item_level_hold' # at t/db_dependent/Reserves.t line 1081. t/db_dependent/Reserves.t .. 63/63 # Looks like you failed 1 test of 63. t/db_dependent/Reserves.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/63 subtests Test Summary Report --- t/db_dependent/Reserves.t (Wstat: 256 Tests: 63 Failed: 1) Failed test: 61 Non-zero exit status: 1 Files=1, Tests=63, 6 wallclock secs ( 0.04 usr 0.00 sys + 5.40 cusr 0.71 csys = 6.15 CPU) Result: FAIL -- You are receiving this mail because: You a
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin SOMERS --- Hi, why this addition : +$item = Koha::Items->find( $itemnumber ); $item object is already fetched at beginning of method. If it is to refresh the ORM object, I think you must use ->get_from_storage() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #110095|0 |1 is obsolete|| --- Comment #13 from Arthur Suzuki --- Created attachment 111954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111954&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved Via ILSDI we use the routines mentioned above to determine holdability, however, neither of these routines check on shelf hold policies Test plan : 1 / Check that default circulation have OnShelfHoldsAllowed to Yes 2 / Place a hold on a book with a single item, item being available for loan, verify that hold can be placed. 3 / Set OnShelfHoldsAllowed to any other value, verify that hold cannot be placed for reason "onShelfHoldsNotAllowed" (shown in the item table). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #86874|0 |1 is obsolete|| --- Comment #5 from Arthur Suzuki --- Created attachment 89723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89723&action=edit Bug 20985 : Add OnShelfHoldsAllowed checks to CanItemBeReserved Test plan : 1 / Check that default circulation have OnShelfHoldsAllowed to Yes 2 / Place a hold on a book with a single item, item being available for loan, verify that hold can be placed. 3 / Set OnShelfHoldsAllowed to any other value, verify that hold cannot be placed for reason "onShelfHoldsNotAllowed" (shown in the item table). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #6 from Arthur Suzuki --- (In reply to Hayley Mapley from comment #3) > This patch results in a runtime error. Here are the steps I followed which > led to the error. > > - Checked default circulation rule - OnShelfHoldsAllowed is set to yes > - Clicked Place hold on a biblio with one available item > - Entered card number - error! > > Error trace: > > Can't call method "effective_itemtype" on an undefined value at > /home/vagrant/kohaclone/C4/Reserves.pm line 1181 > > 1.in C4::Reserves::IsAvailableForItemLevelRequest at > /home/vagrant/kohaclone/C4/Reserves.pm line 1181 > > 1178: # consolidated > 1179: my $patron = Koha::Patrons->find( $borrower->{borrowernumber} > ); > 1180: my $item_object = Koha::Items->find( $item->{itemnumber } ); > 1181: my $itemtype = $item_object->effective_itemtype; > 1182: my $notforloan_per_itemtype > 1183: = $dbh->selectrow_array("SELECT notforloan FROM itemtypes > WHERE itemtype = ?", > 1184: undef, $itemtype); > > 2.in C4::Reserves::CanItemBeReserved at > /home/vagrant/kohaclone/C4/Reserves.pm line 332 > > 329: && !C4::Context->preference('AllowHoldsOnDamagedItems') ); > 330: > 331: # Check for item on shelves and OnShelfHoldsAllowed > 332: return { status => 'onShelfHoldsNotAllowed' } > 333: unless ( IsAvailableForItemLevelRequest($item,$borrower) ); > 334: > 335: # Check for the age restriction > > 3.in C4::Reserves::CanBookBeReserved at > /home/vagrant/kohaclone/C4/Reserves.pm line 286 > > 283: > 284: my $canReserve = { status => '' }; > 285: foreach my $itemnumber (@itemnumbers) { > 286: $canReserve = CanItemBeReserved( $borrowernumber, > $itemnumber, $pickup_branchcode ); > 287: return { status => 'OK' } if $canReserve->{status} eq > 'OK'; > 288: } > 289: return $canReserve; > > Setting to Failed QA Hi Hayley, Thanks for testing, updated my patch in consequence :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #7 from Hayley Mapley --- Hi Arthur, Looks good, only the description is not displayed in the Hold column of the item table when the 'On shelf holds allowed' preference is set to 'If all unavailable'. It is shown though when the preference is set to 'If any unavailable' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard --- Marking "Failed QA" based on comment 7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #14 from David Nind --- Created attachment 112688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112688&action=edit Bug 25898: Fix indirect object notation in debian/list-deps There's a Parallel::ForkManager call in debian/list-deps that doesn't follow the guidelines regarding indirect object notation. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Attachment #112688|0 |1 is obsolete|| --- Comment #15 from David Nind --- Comment on attachment 112688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112688 Bug 25898: Fix indirect object notation in debian/list-deps Apologies - applied the wrong patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added CC|da...@davidnind.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #17 from Arthur Suzuki --- Created attachment 113731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113731&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved Expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) Testing using staff interface: 1. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 2. Set "On shelf holds allowed" to "Yes" for all libraries/patron categories/item types. 3. Place a hold on a record with a single item (where the item is available for loan) . I placed a hold for an item and patron both in/belonging to the Centerville library. . Information column in the item table displays "Not on hold". 4. The hold is placed. 5. Cancel the hold. 6. Set "On shelf holds allowed" to either "If any unavailable" or "If all unavailable" for all patrons/patron categories/item types. 7. The hold is not placed: . Message is "Cannot place hold. No items are available to be placed on hold." . Item table: Hold column displays in red "X onShelfHoldsNotAllowed" and the information column displays "Not on hold". 8. Run the tests prove t/db_dependent/Reserves.t - these should pass Signed-off-by: Arthur Suzuki -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #111954|0 |1 is obsolete|| --- Comment #16 from Arthur Suzuki --- Created attachment 113730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113730&action=edit Bug 20985: Unit tests Signed-off-by: Arthur Suzuki -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #18 from David Nind --- Hi Arthur. Apologies for taking so long to get back to this (and work out what this was about!). I've read the description properly now and bug 19294, so the aim is to make sure that if using ILS-DI the "On shelf holds allowed" options for circulation and fines rules are correctly applied - at the moment they aren't. Here is an updated test plan - I've worked through it and everything works as expected. (I'm not sure I've made the test plan better, but it covers both the staff interface and using ILS-DI.) Suggested updated test plan === The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. Changes === Tests fail ~~ The number of tests need updating from 66 to 67 (the tests pass if I update this myself): ok 67 - MergeHolds # Looks like you planned 66 tests but ran 67. Dubious, test returned 255 (wstat 65280, 0xff00) All 66 subtests passed Test Summary Report --- t/db_dependent/Reserves.t (Wstat: 65280 Tests: 67 Failed: 1) Failed test: 67 Non-zero exit status: 255 Parse errors: Bad plan. You planned 66 tests but ran 67. Files=1, Tests=67, 8 wallclock secs ( 0.05 usr 0.01 sys + 6.65 cusr 0.93 csys = 7.64 CPU) Result: FAIL Wording change suggestion ~ I didn't notice any change in behaviour except for Step 4 with the patch applied, red "X onShelfHoldsNotAllowed". I would prefer to see a human readable message for the staff interface, rather than the code "onShelfHoldsNotAllowed", maybe "Holds not allowed for items on shelves" or "Holds not allowed for items available". Happy to sign off once tests fixed. David -- You are rec
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #113730|0 |1 is obsolete|| Attachment #113731|0 |1 is obsolete|| --- Comment #19 from Arthur Suzuki --- Created attachment 114801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114801&action=edit Bug 20985: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #20 from Arthur Suzuki --- Created attachment 114802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114802&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #114801|0 |1 is obsolete|| Attachment #114802|0 |1 is obsolete|| --- Comment #21 from Arthur Suzuki --- Created attachment 114804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114804&action=edit Bug 20985: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #22 from Arthur Suzuki --- Created attachment 114805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114805&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #23 from Arthur Suzuki --- applied recommended changes and rebased on current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Attachment #114804|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 115732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115732&action=edit Bug 20985: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Attachment #114805|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 115733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115733&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan: 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: . "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: . "Yes" ==> information column in the item table displays "Not on hold", the hold is placed, cancel the hold . "If any unavailable" and "If all unavailable" ==> the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold". 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): . Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold . Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) ==> Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests prove t/db_dependent/Reserves.t - these should pass. 7. Apply the patch (and flush_memcached and restart_all if using koha-testing-docker). 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: . For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". . For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) . Tests: should still pass. 9. Sign off. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Nind changed: What|Removed |Added Text to go in the||This bug fixes the "On release notes||shelf holds allowed" rules ||so that they work correctly ||when using ILS-DI to place ||holds. || ||The expected ||behaviour for "On shelf ||holds allowed" settings for ||the circulation rules (Koha ||administration > Patrons ||and circulation > ||Circulation and fines ||rules) are: ||- If set to ||"Yes", patrons can place ||holds on items currently ||checked in. ||- If set to "If ||any unavailable", patrons ||can only place holds on ||items that are not ||unavailable. ||- If set to ||"If all unavailable", ||patrons can only place ||holds on items where *all* ||items on the record are ||unavailable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #49 from Fridolin Somers --- (In reply to Fridolin Somers from comment #47) > +# Check for item on shelves and OnShelfHoldsAllowed > +return { status => 'onShelfHoldsNotAllowed' } > +unless IsAvailableForItemLevelRequest($item, $patron, > $pickup_branchcode,1); > > Strange : IsAvailableForItemLevelRequest() is not the feature of on shelf > holds allowed, it means hold can be on item level or forced to biblio level > o_O Ah this method is calling : Koha::CirculationRules->get_onshelfholds_policy() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Nick Clemens changed: What|Removed |Added Blocks||30845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30845 [Bug 30845] OMNIBUS: Move holds checks into CanBookBeReserved/CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #53 from Fridolin Somers --- +unless ( $params->{ignore_onshelfholds_policy} ) { +unless ( IsOnShelfHoldsPolicySatisfied( { item => $item, patron => $patron } ) ) { +return _cache { status => 'onShelfHoldsNotAllowed' }; +} +} Why call _cache() ? I cant find this method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #54 from Julian Maurice --- (In reply to Fridolin Somers from comment #53) > Why call _cache() ? I cant find this method That's how it's done on master. It's in C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 pierre.ge...@biblibre.com changed: What|Removed |Added CC||pierre.ge...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Julian Maurice changed: What|Removed |Added Attachment #121485|0 |1 is obsolete|| Attachment #121486|0 |1 is obsolete|| --- Comment #50 from Julian Maurice --- Created attachment 154711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154711&action=edit Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved The expected behaviour for "On shelf holds allowed" setting for the circulation rules (Koha administration > Patrons and circulation > Circulation and fines rules): - Allow holds only on items that are currently checked out or otherwise unavailable. - If set to "Yes", patrons can place holds on items currently checked in. - If set to "If any unavailable", patrons can only place holds on items that are not unavailable. - If set to "If all unavailable", patrons can only place holds on items where *all* items on the record are unavailable. (Adapted from https://bywatersolutions.com/education/preparing-for-library-closures) These rules should also work when using ILS-DI, but currently they don't. This bug makes sure that the "On shelf holds allowed" rules work correctly when using ILS-DI to place holds. Test plan - 1. Enable ILS-DI (set the ILS-DI system preference to Enable). 2. Go to Koha administration > Patrons and circulation > Circulation and fines rules. 3. Work through steps 4-5 for each of the settings for "On shelf holds allowed" for all libraries/patron categories/item types: "Yes", "If any unavailable", and "If all unavailable" 4. Staff interface - place a hold on a record with items available for loan, the rules should work as expected before and after the patch is applied: "Yes": information column in the item table displays "Not on hold", the hold is placed, cancel the hold "If any unavailable" and "If all unavailable": the hold is not placed, message is "Cannot place hold. No items are available to be placed on hold.", red "X" in the hold column and the information column displays "Not on hold" 5. ILS-DI - place a hold on a record with items available for loan (note: without the patch, holds can be placed): - Query to place a hold using ILS-DI on a title that have all its items available, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=127.0.0.1 Without the patch the hold is placed but it shouldn't be allowed, cancel the hold - Query to place a hold using ILS-DI on an available item, example query: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) Without the patch the hold is placed but it shouldn't be allowed, cancel the hold 6. Run the tests in t/db_dependent/Reserves.t - these should pass. 7. Apply the patch, flush the cache and restart Koha (if using koha-testing-docker, run flush_memcached and restart_all) 8. Run through steps 3-6 again, and note the changes when "If any unavailable" and "If all unavailable" options are used: For the staff interface: there should be no change in behavour and should work as expected, for the red "X" in the items table additional text is added "onShelfHoldsNotAllowed". For ILS-DI: these should now work as expected, with holds not placed, and this message in the results returned onShelfHoldsNotAllowed (check to confirm no holds place for either the patron or the item) Tests: should still pass, in particular the following tests: - t/db_dependent/Reserves.t - t/db_dependent/Holds.t - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t - t/db_dependent/api/v1/holds.t - t/db_dependent/ILSDI_Services.t - t/db_dependent/Reserves/MultiplePerRecord.t - t/db_dependent/Reserves/IsOnShelfHoldsPolicySatisfied.t (new test file) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #51 from Julian Maurice --- Patch rebased and reworked. The original patch had a problem that caused infinite recursion (CanItemBeReserved called IsAvailableForItemLevelRequest which called ItemsAnyAvailableAndNotRestricted which called CanItemBeReserved) Replaced the call to IsAvailableForItemLevelRequest by a call to a new subroutine IsOnShelfHoldsPolicySatisfied which does only what its name suggests All tests mentioned in comment 44 should pass. I removed the Signed-off-by lines because the patch changed significantly, but the test plan did not change. Please test again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #52 from Nick Clemens --- I believe other calls to CanItemBeRserved should be adjusted or taken into consideration Both reserve/request.pl and opac/opac-reserve.pl currently call CanItemBeReserved and then call IsAvailableForItemLevelRequest After this code, if I understand correctly, IsOnShelfHoldsPolicySatisfied will now be called twice for each item - once from CanItem.. and once from IsAvailable.. See bug 32702 - we really need to consolidate these two routines, or if a check is moved into CanItemBeReserved, it should be removed from the other? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Shi Yao Wang changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30556 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/