[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED --- Comment #14 from Fridolin SOMERS --- Depends on Bug 18789 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #13 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 --- Comment #11 from Jonathan Druart --- Created attachment 76899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76899=edit Bug 21008: Use Koha::Patron->is_child Signed-off-by: Tomas Cohen Arazi Edit: I removed the category parameter as it is not really used. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Jonathan Druart changed: What|Removed |Added Attachment #76766|0 |1 is obsolete|| Attachment #76767|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 76898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76898=edit Bug 21008: Use patron object to get category_type This patch makes borrower_add_additional_fields() in both pay.pl and paycollect.pl use the right object to pick the category_type. It also populates the extendedattributes template variable in pay.pl which was missed by a change. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What|Removed |Added Attachment #76545|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 76766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76766=edit Bug 21008: Use patron object to get category_type This patch makes borrower_add_additional_fields() in both pay.pl and paycollect.pl use the right object to pick the category_type. It also populates the extendedattributes template variable in pay.pl which was missed by a change. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What|Removed |Added Attachment #76547|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 76767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76767=edit Bug 21008: Use Koha::Patron->is_child Signed-off-by: Tomas Cohen Arazi Edit: I removed the category parameter as it is not really used. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- No test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76546|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 76547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76547=edit Bug 21008: Use Koha::Patron->is_child Signed-off-by: Tomas Cohen Arazi Edit: I removed the category parameter as it is not really used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 --- Comment #5 from Jonathan Druart --- Created attachment 76546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76546=edit Bug 21008: Use Koha::Patron->is_child -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 76545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76545=edit Bug 21008: Use patron object to get category_type This patch makes borrower_add_additional_fields() in both pay.pl and paycollect.pl use the right object to pick the category_type. It also populates the extendedattributes template variable in pay.pl which was missed by a change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008
--- Comment #3 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #2)
> Which variables?
1- $b_ref->{extendedattributes}
The other scripts set $template->param( extendedattributes => ... );
2- CATCODE_MULTI
I made a mistake on this one, as it is used in patron-search.inc. But the
current logic prevents it to be populated.
3- catcode
Same as 2.
I really think this should all be moved into using the global $patron object.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- Which variables? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Tomás Cohen Arazi changed: What|Removed |Added Summary|pay.pl and paycollect.pl|pay.pl and paycollect.pl |pass unused (and expensive) |raise warning |data to templates | --- Comment #1 from Tomás Cohen Arazi --- They are used, in patron-search.inc. Still needs fixing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
