[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 --- Comment #14 from Marcel de Rooy --- (In reply to David Cook from comment #4) > It seems that technically 01e is a violation of the MARC standard. > > Maybe it is time to remove 01e from the frameworks... See bug 24274 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24274 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com Version(s)||19.05.00, 18.11.05 released in|| --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22721 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- Happy to see this old warning go away. I provided a follow-up to fix Josef's concern. I noticed there are still a lot of calls with the framework parameter even if it has no effect. Something to fix separately at some point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Katrin Fischer changed: What|Removed |Added Attachment #88092|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 88117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88117=edit Bug 21172: Remove warning from addbiblio.pl Argument "01e" isn't numeric in numeric ne (!=) at /home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507. A tagfield can be 01e and so raise a warning is compared with == or != This patch also fixes few inconsistencies: - tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField (to support other marcflavours) - do not use $_ - loop only once on $usedTagsLib Test plan: For devs only, read the code and confirm the changes make sense. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 --- Comment #9 from Katrin Fischer --- Created attachment 88118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88118=edit Bug 21172: Remove obsolete framework parameter from GetMarcFromKohaField -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #7 from Josef Moravec --- Otherwise looking good for me, marc21 standard does not allow non numeric tags, but sometimes it happens and Koha should count with this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172
--- Comment #6 from Josef Moravec ---
Comment on attachment 88092
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88092
Bug 21172: Remove warning from addbiblio.pl
Review of attachment 88092:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21172=88092)
-
::: cataloguing/addbiblio.pl
@@ +490,5 @@
> my %seen;
> my @tab_data; # all tags to display
> +
> +my $max_num_tab=-1;
> +my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField(
> "items.itemnumber", scalar $input->param('frameworkcode') );
Second param is not needed, now the default framework is taken as authoritative
for marc to koha mappings.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Liz Rea changed: What|Removed |Added Attachment #77544|0 |1 is obsolete|| --- Comment #5 from Liz Rea --- Created attachment 88092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88092=edit Bug 21172: Remove warning from addbiblio.pl Argument "01e" isn't numeric in numeric ne (!=) at /home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507. A tagfield can be 01e and so raise a warning is compared with == or != This patch also fixes few inconsistencies: - tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField (to support other marcflavours) - do not use $_ - loop only once on $usedTagsLib Test plan: For devs only, read the code and confirm the changes make sense. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- (In reply to Tomás Cohen Arazi from comment #2) > Isn't 01e a bug on the data? I was curious about this... https://www.loc.gov/marc/bibliographic/bdintro.html "Variable fields - The data in a MARC bibliographic record is organized into variable fields, each identified by a three-character numeric tag that is stored in the Directory entry for the field. Each field ends with a field terminator character. The last variable field in a record ends with both a field terminator and a record terminator (ASCII 1D hex). There are two types of variable fields." It seems that technically 01e is a violation of the MARC standard. Maybe it is time to remove 01e from the frameworks... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 --- Comment #3 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #2) > Isn't 01e a bug on the data? Maybe, maybe not, who really knows? :) "01e" site:http://irc.koha-community.org will return stuffs like: 09:55 magnusenger Is it just me, or does a MARC21 tag called 01e look a little odd? 10:02 drojf oh that 01e coded field error thing in the marc frameworks is actually supposed to be there? i always thought that was a misspelled 019 :D 11:09 gmcharltmagnusenger: it's not standard MARC21; it's a custom field that was once used by the RLIN bibliographic utlity 18:46 tcoheni've just noticed we don't have it, but have '01e' instead 18:46 tcohenis field 019 of any use in MARC21? Then: http://irc.koha-community.org/koha/2013-07-16 http://irc.koha-community.org/koha/2012-11-21 etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- Isn't 01e a bug on the data? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 --- Comment #1 from Jonathan Druart --- Created attachment 77544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77544=edit Bug 21172: Remove warning from addbiblio.pl Argument "01e" isn't numeric in numeric ne (!=) at /home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507. A tagfield can be 01e and so raise a warning is compared with == or != This patch also fixes few inconsistencies: - tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField (to support other marcflavours) - do not use $_ - loop only once on $usedTagsLib Test plan: For devs only, read the code and confirm the changes make sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
