[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #23 from Lucas Gass  ---
Kait, 

Im sorry, I am missing that dependency. I have reverted this patch set. This is
NOT in 19.05.x

Sorry for the confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #22 from Hayley Mapley  ---
Thanks Jonathan :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #21 from Katrin Fischer  ---
(In reply to Lucas Gass from comment #20)
> backported to 19.05.x for 19.05.07

Hi Luke, it looks like the dependency is not in 19.05 - did you test if this
works?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||23677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677
[Bug 23677] Add API route to get a bibliographic record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com

--- Comment #20 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #19 from Jonathan Druart  
---
(In reply to Hayley Mapley from comment #18)
> Is this a candidate to be backported to 18.11.x?
> 
> I am testing this at the moment, and each existing biblionumber I put in the
> Record field I get the 'This bibliographic record does not exist' message
> and and blocked from going to the next page.
> 
> Can anyone think of any reason the API call would be failing for me? I may
> be missing something.

Hi Hayley, the API routes for biblios do not exist in 18.11 (added by bug
23677).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #18 from Hayley Mapley  ---
Is this a candidate to be backported to 18.11.x?

I am testing this at the moment, and each existing biblionumber I put in the
Record field I get the 'This bibliographic record does not exist' message and
and blocked from going to the next page.

Can anyone think of any reason the API call would be failing for me? I may be
missing something.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24358

--- Comment #17 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #16)
> Comment on attachment 96576 [details] [review]
> Bug 21232: Add a client-side check on biblionumber when creating a
> subscription
> 
> Review of attachment 96576 [details] [review]:
> -
> 
> ::: koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
> @@ +60,5 @@
> >  }
> >  
> > +var bib_exists = $("input[name='title']").val().length;
> > +
> > +if (!bib_exists) alert(_("Bibliographic record does not exist!"));
> 
> This won't translate - got missed before. Can we fix it in a follow-up?

Sorry about that, see bug 24358.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358
[Bug 24358] "Bibliographic record does not exist!" is not translatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #16 from Katrin Fischer  ---
Comment on attachment 96576
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96576
Bug 21232: Add a client-side check on biblionumber when creating a subscription

Review of attachment 96576:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21232=96576)
-

::: koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
@@ +60,5 @@
>  }
>  
> +var bib_exists = $("input[name='title']").val().length;
> +
> +if (!bib_exists) alert(_("Bibliographic record does not exist!"));

This won't translate - got missed before. Can we fix it in a follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Joy Nelson  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #15 from Joy Nelson  ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #14 from Joy Nelson  ---
Must have been a cache issue.  A bit of playing with FF and the settings and
few hard cache clears and all's well.  It's working now. :)

joy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2020-01-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #13 from Joy Nelson  ---
I've been attempting to push this to 19.11.x and I can apply the patch, but it
does not perform as expected.  I am not warned that my biblionumber is invalid.
 I'm not stopped from completing the addition of the serial linked to a 'bad'
bibnumber.  Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #12 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #96489|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 96576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96576=edit
Bug 21232: Add a client-side check on biblionumber when creating a subscription

This patch adds an AJAX call to the REST API (/api/v1/biblios/) to
retrieve and display the biblio's title.
On clicking the "next" button a check is done to make sure the title
exists, which means the biblionumber we manually entered is valid (can
we assume a title is mandatory?)

Test plan:
- Create or edit a new subscription
- Enter an invalid biblionumber in the input
=> A friendly note is telling you that the biblio does not exist
- Try to switch to the next screen
=> You get an alert
- Enter a valid biblionumber in the input
=> The title is displayed
=> Try to switch to the next screen
=> It works!

Signed-off-by: hc 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Holly  changed:

   What|Removed |Added

 CC||h...@interleaf.ie
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #96245|0   |1
is obsolete||

--- Comment #10 from ByWater Sandboxes  ---
Created attachment 96489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96489=edit
Bug 21232: Add a client-side check on biblionumber when creating a subscription

This patch adds an AJAX call to the REST API (/api/v1/biblios/) to
retrieve and display the biblio's title.
On clicking the "next" button a check is done to make sure the title
exists, which means the biblionumber we manually entered is valid (can
we assume a title is mandatory?)

Test plan:
- Create or edit a new subscription
- Enter an invalid biblionumber in the input
=> A friendly note is telling you that the biblio does not exist
- Try to switch to the next screen
=> You get an alert
- Enter a valid biblionumber in the input
=> The title is displayed
=> Try to switch to the next screen
=> It works!

Signed-off-by: hc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23677

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #89357|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 96245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96245=edit
Bug 21232: Add a client-side check on biblionumber when creating a subscription

This patch adds an AJAX call to the REST API (/api/v1/biblios/) to
retrieve and display the biblio's title.
On clicking the "next" button a check is done to make sure the title
exists, which means the biblionumber we manually entered is valid (can
we assume a title is mandatory?)

Test plan:
- Create or edit a new subscription
- Enter an invalid biblionumber in the input
=> A friendly note is telling you that the biblio does not exist
- Try to switch to the next screen
=> You get an alert
- Enter a valid biblionumber in the input
=> The title is displayed
=> Try to switch to the next screen
=> It works!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #8 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #7)
> Created attachment 89357 [details] [review]
> Bug  21232: Add a client-side check on biblionumber when creating a
> subscription

Something like that could work, but much more is missing:
- JS code is horrible there
- Biblio's title could be retrieved and displayed
- server-side code is missing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #7 from Jonathan Druart  
---
Created attachment 89357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89357=edit
Bug  21232: Add a client-side check on biblionumber when creating a
subscription

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #6 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #5)
> Now failing with 
> 
> Can't call method "title" on an undefined value at
> /home/vagrant/kohaclone/Koha/Subscription.pm line 165
> Koha::Subscription::get_sharable_info('Koha::Subscription', 1)
> called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 123
> Koha::SharedContent::prepare_entity_data('', 51, 1, 'subscription')
> called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 82
> Koha::SharedContent::send_entity('', 51, 1, 'subscription') called
> at /home/vagrant/kohaclone/serials/subscription-add.pl line 376
>
> CGI::Compile::ROOT::home_vagrant_kohaclone_serials_subscription_2dadd_2epl::
> redirect_add_subscription at
> /home/vagrant/kohaclone/serials/subscription-add.pl line 178
> 
> 
> It's time to add the missing FK

After bug 22849 the subscription will be created without warning/error and
inserted with an invalid biblionumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #5 from Jonathan Druart  
---
Now failing with 

Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/Koha/Subscription.pm line 165
Koha::Subscription::get_sharable_info('Koha::Subscription', 1) called
at /home/vagrant/kohaclone/Koha/SharedContent.pm line 123
Koha::SharedContent::prepare_entity_data('', 51, 1, 'subscription')
called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 82
Koha::SharedContent::send_entity('', 51, 1, 'subscription') called at
/home/vagrant/kohaclone/serials/subscription-add.pl line 376
   
CGI::Compile::ROOT::home_vagrant_kohaclone_serials_subscription_2dadd_2epl::redirect_add_subscription
at /home/vagrant/kohaclone/serials/subscription-add.pl line 178


It's time to add the missing FK

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2019-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Katrin Fischer  changed:

   What|Removed |Added

 CC||ztaj...@gmail.com

--- Comment #4 from Katrin Fischer  ---
*** Bug 12921 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2018-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Katrin Fischer  changed:

   What|Removed |Added

Version|16.11   |master

--- Comment #3 from Katrin Fischer  ---
Updating to master, there is still no check in place for linking subscriptions
to non-existing biblionumbers. I think this should be checked on saving or
maybe even when moving from the first part of the subscription form to the
second

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2018-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #2 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #1)
> Certainly a duplicate of bug 20351.

On first glance, I don't think it is. It's catching invalid subscriptionids,
while this is about an invalid biblionumber?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber

2018-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20351

--- Comment #1 from Jonathan Druart  
---
Certainly a duplicate of bug 20351.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/