[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 77880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77880&action=edit Bug 21233: Unit tests This patch adds tests for the required password-related exceptions. The tests verify the stringified version of the exceptions. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => FAIL: Exceptions not implemented, tests fail! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 77881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77881&action=edit Bug 21233: Add Koha::Exceptions::Password This patch adds some exceptions that we need. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off! :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 [Bug 17006] Add route to change patron's password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178 [Bug 21178] Add Koha::Patron::set_password method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Josef Moravec changed: What|Removed |Added Attachment #77880|0 |1 is obsolete|| Attachment #77881|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 77914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77914&action=edit Bug 21233: Unit tests This patch adds tests for the required password-related exceptions. The tests verify the stringified version of the exceptions. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => FAIL: Exceptions not implemented, tests fail! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #4 from Josef Moravec --- Created attachment 77915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77915&action=edit Bug 21233: Add Koha::Exceptions::Password This patch adds some exceptions that we need. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off! :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Marcel de Rooy changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- FAIL Koha/Exceptions/Password.pm FAIL pod coverage POD is missing for 'description' This might be a qa tools bug? podchecker does not warn on this module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #6 from Marcel de Rooy --- Reversing patch order.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #7 from Marcel de Rooy --- Just a language thing on TrailingWhitespaces I would say we have trailing spaces or trailing whitespace where whitespace is \s* in regex terms (catching all spaces, tabs, newlines etc.). No plural form needed. From https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of-whitespace: The word "whitespace" is usually uncountable. If you need it to be countable, I would suggest saying "whitespace characters". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #8 from Marcel de Rooy --- For some other report: git grep -l [wW]hitespaces :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #11 from Marcel de Rooy --- Created attachment 78118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78118&action=edit Bug 21233: (QA follow-up) We do not like the plural form of whitespace The word "whitespace" is usually uncountable. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Marcel de Rooy changed: What|Removed |Added Attachment #77914|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 78117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78117&action=edit Bug 21233: Unit tests This patch adds tests for the required password-related exceptions. The tests verify the stringified version of the exceptions. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => FAIL: Exceptions not implemented, tests fail! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Marcel de Rooy changed: What|Removed |Added Attachment #77915|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 78116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78116&action=edit Bug 21233: Add Koha::Exceptions::Password This patch adds some exceptions that we need. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off! :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #5) > FAIL Koha/Exceptions/Password.pm >FAIL pod coverage > POD is missing for 'description' > > This might be a qa tools bug? > podchecker does not warn on this module. That's a false positive. Yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #7) > Just a language thing on TrailingWhitespaces > I would say we have trailing spaces or trailing whitespace where whitespace > is \s* in regex terms (catching all spaces, tabs, newlines etc.). No plural > form needed. > > From > https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of- > whitespace: > The word "whitespace" is usually uncountable. If you need it to be > countable, I would suggest saying "whitespace characters". I'd say we should even get rid of 'Trailing', because this is then used in a test for whitespace chars at the begining too, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #14 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #13) > (In reply to Marcel de Rooy from comment #7) > > Just a language thing on TrailingWhitespaces > > I would say we have trailing spaces or trailing whitespace where whitespace > > is \s* in regex terms (catching all spaces, tabs, newlines etc.). No plural > > form needed. > > > > From > > https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of- > > whitespace: > > The word "whitespace" is usually uncountable. If you need it to be > > countable, I would suggest saying "whitespace characters". > > I'd say we should even get rid of 'Trailing', because this is then used in a > test for whitespace chars at the begining too, right? Too late ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 78721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78721&action=edit Bug 21233: (QA follow-up) It is not only trailing whitespace characters Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #14) > (In reply to Tomás Cohen Arazi from comment #13) > > (In reply to Marcel de Rooy from comment #7) > > > Just a language thing on TrailingWhitespaces > > > I would say we have trailing spaces or trailing whitespace where > > > whitespace > > > is \s* in regex terms (catching all spaces, tabs, newlines etc.). No > > > plural > > > form needed. > > > > > > From > > > https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of- > > > whitespace: > > > The word "whitespace" is usually uncountable. If you need it to be > > > countable, I would suggest saying "whitespace characters". > > > > I'd say we should even get rid of 'Trailing', because this is then used in a > > test for whitespace chars at the begining too, right? > > Too late ? :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 78836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78836&action=edit Bug 21233: (follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 --- Comment #19 from Nick Clemens --- (In reply to Tomás Cohen Arazi from comment #18) > Created attachment 78836 [details] [review] > Bug 21233: (follow-up) POD fix > > Signed-off-by: Tomas Cohen Arazi Follow up pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #20 from Martin Renvoize --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
