[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #16 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #7) > Still needs some attention. Coming back soon Mainly added two patches in the middle. Introducing the term "administrative lockout" in order to distinguish from lockout by typing wrong passwords. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #79170|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 80208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80208=edit Bug 21336: Adjust cleanup_database.pl Add the new Patron routines to this cron job. Actions are performed only if preferences are set. Note: No specific command line flags for these actions are added here (and probably not needed too). So no crontab changes too. Test plan: Add a new patron. Enable GDPR_Policy and refuse consent on OPAC for this patron. Set only the first delay to zero (0) for immediate action. Run cleanup_database.pl --logs (or any other flag) for the first time. Check lock and expiration. Set the second delay to zero (0) for immediate action. Run cleanup_database.pl --logs for the second time. Check anonymization. Set the third delay to zero (0) for immediate action. Run cleanup_database.pl --logs for the third time. Check removal. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #79169|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 80207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80207=edit Bug 21336: Search, lock and anonymize methods Add Koha::Patron->lock and anonymize. Add Koha::Patrons methods search_unsubscribed, search_anonymize_candidates and search_anonymized. And wrappers for lock and anonymize. Add unit tests. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #13 from Marcel de Rooy --- Created attachment 80206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80206=edit Bug 21336: Introduce administrative lockout As a preparation for Koha::Patron->lock, we add the concept of administrative lockout. The account is locked just as it would have been by too much failed login attempts. This is handled by a negative value in borrowers.login_attempts. Test plan: Run t/db_dependent/Auth.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #12 from Marcel de Rooy --- Created attachment 80205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80205=edit Bug 21336: Do not increase login_attempts after locking If an account has been locked, there is no use to keep increasing this number. It is not true too; after the pref number has been reached, we can not really speak of login attempts anymore. The credentials are just ignored. Adding a dbrev to put existing values in line. And a simple test in Auth.t to confirm that login_attempts stop increasing. Note: It feels safe to keep the '>=' condition in account_locked. But it could obviously be changed to '=='. (Added a test for that.) Note: Adding a mock_preference in Auth.t too for GDPR_Policy. Since not all tests will pass when the pref is enabled (though disabled by default). Test plan: Run dbrev with updatedatabase.pl. Run t/db_dependent/Koha/Patrons.t Run t/db_dependent/Auth.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #79165|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 80201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80201=edit Bug 21336: Small adjustment in Koha::Token Allow a pattern too in Koha::Token->generate. Only supported length. Does not affect CSRF calls. So tiny change without further impact. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #79167|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 80203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80203=edit Bug 21336: DBIx schema changes Changes for additional column flgAnonymized. No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #79168|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 80204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80204=edit Bug 21336: Dbrev for new prefs This patch adds three new prefs: - UnsubscribeReflectionDelay - PatronAnonymizeDelay - PatronRemovalDelay Test plan: Run upgrade. Check patrons pref page. Look under Privacy. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #79166|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 80202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80202=edit Bug 21336: Database revision for borrowers.flgAnonymized This new flag should speak for itself ;) Test plan: Run installer or updatedatabase. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Summary|GDPR: Process unsubscribe |GDPR: Handle unsubscribe |requests automatically |requests automatically by ||optional lock, anonymize ||and remove -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
