[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #82192|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Blocks||21944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 [Bug 21944] Fix waiting holds at wrong location bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #44 from Christopher Brannon --- (In reply to Josef Moravec from comment #43) > (In reply to Josef Moravec from comment #42) > > > > And could you please separate the fix for rerouting wating hold to its own > > bug report? > > And it would be nice to have regression test here... I don't know what that is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #43 from Josef Moravec --- (In reply to Josef Moravec from comment #42) > > And could you please separate the fix for rerouting wating hold to its own > bug report? And it would be nice to have regression test here... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #42 from Josef Moravec --- Overall it looks good, just one thing - please don't use inline javascript (onclick="...") And could you please separate the fix for rerouting wating hold to its own bug report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Hardware|All |Macintosh QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18117 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #81836|0 |1 is obsolete|| --- Comment #38 from ByWater Sandboxes --- Created attachment 82189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82189&action=edit Bug 21346: Streamline logic in holds and transfers 1) Replaced comparison with string to make testing branch easier. 2) Replaced useless 0 values with undef. Does not change any behavior, only simplifies code. Signed-off-by: Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #82049|0 |1 is obsolete|| --- Comment #41 from ByWater Sandboxes --- Created attachment 82192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82192&action=edit Bug 21346: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #81924|0 |1 is obsolete|| --- Comment #40 from ByWater Sandboxes --- Created attachment 82191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82191&action=edit Bug 21346: Convert dialogs to modals. This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. Signed-off-by: Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #81853|0 |1 is obsolete|| --- Comment #39 from ByWater Sandboxes --- Created attachment 82190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82190&action=edit Bug 21346: Remove double dialog To Test: 1) Place a hold on an item for pickup at another branch. 2) Check in item to trigger hold and transfer. 3) Check in item again without changing location. Note modal AND old dialog behind modal. 4) Apply patch. 5) Check in item again without changing location. Note modal without the old dialog. Signed-off-by: Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #37 from Christopher Brannon --- *** Bug 18490 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #36 from Christopher Brannon --- Finally. I think this was the best approach. Sorry for the number of changes. If someone thinks I need to create a test for the modification to C4/Circulation.pm, I can try to do that to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #35 from Christopher Brannon --- Created attachment 82049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82049&action=edit Bug 21346: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #81921|0 |1 is obsolete|| --- Comment #34 from Christopher Brannon --- Created attachment 81924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81924&action=edit Bug 21346: Convert dialogs to modals. This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #33 from Christopher Brannon --- Okay, patches for cleanup are set. Now addressing the waiting hold at the wrong location. It must: * Bring up a modal. * Only prompt to send the item to the pickup location. * Update current location in item. * Initiate a transfer. * Update the reserve from a W to T in the found field. * Remove the waiting date in the reserves. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #32 from Christopher Brannon --- Created attachment 81921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81921&action=edit Bug 21346: Convert dialogs to modals This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #31 from Christopher Brannon --- Created attachment 81853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81853&action=edit Bug 21346: Remove double dialog To Test: 1) Place a hold on an item for pickup at another branch. 2) Check in item to trigger hold and transfer. 3) Check in item again without changing location. Note modal AND old dialog behind modal. 4) Apply patch. 5) Check in item again without changing location. Note modal without the old dialog. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #79686|0 |1 is obsolete|| Attachment #80879|0 |1 is obsolete|| Attachment #81100|0 |1 is obsolete|| --- Comment #30 from Christopher Brannon --- Created attachment 81836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81836&action=edit Bug 21346: Streamline logic in holds and transfers 1) Replaced comparison with string to make testing branch easier. 2) Replaced useless 0 values with undef. Does not change any behavior, only simplifies code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #29 from Christopher Brannon --- I am going to revamp this bug, once again. There are some other issues at hand that need to be done to handle this more appropriately: * I will be mapping out hold and transfer behaviors * Clean up some logic - some of it is a bit cobbled together: For example, found is used specificly when a hold is found, but has been used for some simple transfers as well. * Clarify some variables - found is too generic * Add a routine for correcting waiting holds - there is no current method for reverting a hold from waiting to in transit in returns. * Finish converting dialogs to modals. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21186 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21664 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #28 from Christopher Brannon --- Created attachment 81100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81100&action=edit Bug 21346: Restore values needed for buttons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #27 from Christopher Brannon --- Found another issue. While I have fixed the routing issue, an item marked waiting and turned in to the wrong branch will re-route the item correctly, but does not set the item back to top priority. Looking into this. Failing for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Severity|enhancement |major --- Comment #26 from Christopher Brannon --- Changing this to a bug fix, as it fixes dialog issues and a known bug. Not really adding anything new in terms of features. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #25 from Christopher Brannon --- I've isolated the flaw. We are good to go again. Test plan remains the same. I will also submit a patch to clean up the tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #24 from Christopher Brannon --- Created attachment 80879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80879&action=edit Bug 21346: Fixes dual modals on waiting hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Christopher Brannon --- Found a logic problem. Hold-found2 modal triggering on top of hold-found1 modal if you check an item that is already waiting at that location. I will go in and update the logic to not show hold-found2 modal if waiting. I will put this back to needs sign-off when complete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #22 from Christopher Brannon --- Fixed typo in plan. We should be good now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #79685|0 |1 is obsolete|| --- Comment #21 from Christopher Brannon --- Created attachment 79686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79686&action=edit Bug 21346: Update/Fix dialogs - Fix hold waiting TEST PLAN 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confifm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Check in the item at Branch B to put it in waiting status. 6) Be human and make another mistake. Login as Branch C and check the item in. Notice it does nothing except a local use. 7) Check out an item at Branch A. 8) Check in the item at Branch B. Notice the classic blue transfer dialog at the top of page. 9) Apply the patch. 10) Check everything in at their branches. 11) Repeat steps 1-8. Now note the classic dialogs are gone and nothing but the modals left. Note that the waiting hold will now reroute back the place it should be waiting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #20 from Christopher Brannon --- Resubmitted patch, removing indent changes per request and combined patches. No new code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #78942|0 |1 is obsolete|| Attachment #78943|0 |1 is obsolete|| --- Comment #19 from Christopher Brannon --- Created attachment 79685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79685&action=edit Bug 21346: Update/Fix dialogs - Fix hold waiting TEST PLAN 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confifm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Check in the item at Branch B to put it in waiting status. 6) Be human and make another mistake. Login as Branch C and check the item in. Notice it does nothing except a local hold. 7) Check out an item at Branch A. 8) Check in the item at Branch B. Notice the classic blue transfer dialog at the top of page. 9) Apply the patch. 10) Check everything in at their branches. 11) Repeat steps 1-8. Now note the classic dialogs are gone and nothing but the modals left. Note that the waiting hold will now reroute back the place it should be waiting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #18 from Christopher Brannon --- (In reply to Christopher Brannon from comment #17) > (In reply to Jonathan Druart from comment #16) > > This is bugfix, not an enhancement, right? > > I would suggest to provide a patch which would not contain the indentation > > changes, that will generate conflicts and make the backport harder. > > It is both. Please explain. I don't understand the issue. Never mind. I think I understand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #17 from Christopher Brannon --- (In reply to Jonathan Druart from comment #16) > This is bugfix, not an enhancement, right? > I would suggest to provide a patch which would not contain the indentation > changes, that will generate conflicts and make the backport harder. It is both. Please explain. I don't understand the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #16 from Jonathan Druart --- This is bugfix, not an enhancement, right? I would suggest to provide a patch which would not contain the indentation changes, that will generate conflicts and make the backport harder. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #15 from Christopher Brannon --- *** Bug 19720 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #14 from Christopher Brannon --- *** Bug 13153 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #78902|0 |1 is obsolete|| --- Comment #12 from ByWater Sandboxes --- Created attachment 78942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78942&action=edit Bug 21346: Update/Fix dialogs - Fix hold waiting TEST PLAN 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confifm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Check in the item at Branch B to put it in waiting status. 6) Be human and make another mistake. Login as Branch C and check the item in. Notice it does nothing except a local hold. 7) Check out an item at Branch A. 8) Check in the item at Branch B. Notice the classic blue transfer dialog at the top of page. 9) Apply the patch. 10) Check everything in at their branches. 11) Repeat steps 1-8. Now note the classic dialogs are gone and nothing but the modals left. Note that the waiting hold will now reroute back the place it should be waiting. Signed-off-by: Fred King -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #78916|0 |1 is obsolete|| --- Comment #13 from ByWater Sandboxes --- Created attachment 78943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78943&action=edit Bug 21346: Update buttons on transfer only Added a confirm only button and updated text on print button for the transfer dialog so you are not forced to print. Signed-off-by: Spencer Signed-off-by: Fred King -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Fred King changed: What|Removed |Added CC||fred.k...@medstar.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Blocks||18490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 [Bug 18490] Transfer message confusing, cancel button missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #11 from Christopher Brannon --- (In reply to ByWater Sandboxes from comment #9) > Created attachment 78916 [details] [review] > Bug 21346: Update buttons on transfer only > > Added a confirm only button and updated text on print button for the > transfer dialog so you are not forced to print. > > Signed-off-by: Spencer Spencer, when signing off, if there is more than one patch involved, you need to sign off on the whole thing, not just a single patch. Have Ed show you how. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Summary|Remove return2 div from |Clean up dialogs in |returns.tt now that modal |returns.pl / Fix waiting |interface exists / Fix |holds at wrong location bug |waiting holds at wrong | |location| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/