[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Katrin Fischer changed: What|Removed |Added Attachment #81338|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 81383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81383=edit Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves The cardnumber can contain strange non-javascript-friendly characters. This patch converts all the internal references to borrowernumber, but displays the cardnumber when showing list of matching users. TEST PLAN - 1) Make sure Course Reserves is being used. Check system preferences. 2) Make sure there is a Course entered. 3) Make sure there is a patron with an cardnumber which breaks the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!) 4) Go into the course list. 5) Click the course name link 6) In the "Instructor Search" box enter the patron name. 7) Select the patron which has the ugly cardnumber. 8) Click Save -- The course listing should have the new teacher listed. 9) Click the course name link again. 10) Click 'Remove' beside the instructor's name. -- nothing happens, and inspecting the error console gives you the ugly error described in comment #0 11) apply this patch 12) restart_all 13) sudo service apache2 restart 14) refresh the page. 15) click 'Remove' beside the instructor's name. -- name is removed. 16) Click Save -- the course listing no longer lists the new teacher. 17) Actually confirm that adding and removing others normally works as expected. 18) run koha qa test tools. Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Charles Farmer changed: What|Removed |Added Attachment #79263|0 |1 is obsolete|| --- Comment #7 from Charles Farmer --- Created attachment 81338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81338=edit Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves The cardnumber can contain strange non-javascript-friendly characters. This patch converts all the internal references to borrowernumber, but displays the cardnumber when showing list of matching users. TEST PLAN - 1) Make sure Course Reserves is being used. Check system preferences. 2) Make sure there is a Course entered. 3) Make sure there is a patron with an cardnumber which breaks the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!) 4) Go into the course list. 5) Click the course name link 6) In the "Instructor Search" box enter the patron name. 7) Select the patron which has the ugly cardnumber. 8) Click Save -- The course listing should have the new teacher listed. 9) Click the course name link again. 10) Click 'Remove' beside the instructor's name. -- nothing happens, and inspecting the error console gives you the ugly error described in comment #0 11) apply this patch 12) restart_all 13) sudo service apache2 restart 14) refresh the page. 15) click 'Remove' beside the instructor's name. -- name is removed. 16) Click Save -- the course listing no longer lists the new teacher. 17) Actually confirm that adding and removing others normally works as expected. 18) run koha qa test tools. Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 M. Tompsett changed: What|Removed |Added Attachment #79057|0 |1 is obsolete|| --- Comment #6 from M. Tompsett --- Created attachment 79263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79263=edit Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves The cardnumber can contain strange non-javascript-friendly characters. This patch converts all the internal references to borrowernumber, but displays the cardnumber when showing list of matching users. TEST PLAN - 1) Make sure Course Reserves is being used. Check system preferences. 2) Make sure there is a Course entered. 3) Make sure there is a patron with an cardnumber which breaks the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!) 4) Go into the course list. 5) Click the course name link 6) In the "Instructor Search" box enter the patron name. 7) Select the patron which has the ugly cardnumber. 8) Click Save -- The course listing should have the new teacher listed. 9) Click the course name link again. 10) Click 'Remove' beside the instructor's name. -- nothing happens, and inspecting the error console gives you the ugly error described in comment #0 11) apply this patch 12) restart_all 13) sudo service apache2 restart 14) refresh the page. 15) click 'Remove' beside the instructor's name. -- name is removed. 16) Click Save -- the course listing no longer lists the new teacher. 17) Actually confirm that adding and removing others normally works as expected. 18) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 pierre-marc.thiba...@inlibro.com changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from pierre-marc.thiba...@inlibro.com --- An error occured when I tried to apply the patch. Can you check the patch to fix it please? Thank you. Applying: Bug 21349: Change cardnumber to borrowernumber fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt). error: could not build fake ancestor Patch failed at 0001 Bug 21349: Change cardnumber to borrowernumber The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21349-Change-cardnumber-to-borrowernumber-6lnMN1.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 --- Comment #4 from M. Tompsett --- Created attachment 79057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79057=edit Bug 21349: Change cardnumber to borrowernumber The cardnumber can contain strange non-javascript-friendly characters. This patch converts all the internal references to borrowernumber, but displays the cardnumber when showing list of matching users. TEST PLAN - 1) Make sure Course Reserves is being used. Check system preferences. 2) Make sure there is a Course entered. 3) Make sure there is a patron with an cardnumber which breaks the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!) 4) Go into the course list. 5) Click the course name link 6) In the "Instructor Search" box enter the patron name. 7) Select the patron which has the ugly cardnumber. 8) Click Save -- The course listing should have the new teacher listed. 9) Click the course name link again. 10) Click 'Remove' beside the instructor's name. -- nothing happens, and inspecting the error console gives you the ugly error described in comment #0 11) apply this patch 12) restart_all 13) sudo service apache2 restart 14) refresh the page. 15) click 'Remove' beside the instructor's name. -- name is removed. 16) Click Save -- the course listing no longer lists the new teacher. 17) Actually confirm that adding and removing others normally works as expected. 18) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 M. Tompsett changed: What|Removed |Added Attachment #78835|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Comment on attachment 78835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78835 Fix RemoveInstructor function Counter patch incoming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com |ity.org | --- Comment #2 from M. Tompsett --- The patch submitted by Eric Phetteplace applies, but does not solve the problem. I created a user with the barcode of "Ka-boom:Ka-boom!KABOOM@#$!", and was not able to remove the user. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Eric Phetteplace changed: What|Removed |Added Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu --- Comment #1 from Eric Phetteplace --- Created attachment 78835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78835=edit Fix RemoveInstructor function -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
