[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|RESOLVED Resolution|--- |FIXED --- Comment #34 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #33 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #26) > (In reply to Victor Grousset/tuxayo from comment #24) > > (In reply to Marcel de Rooy from comment #23) > > What do you mean? The patch doesn't use --preload-app. > I did not say that. Please read the comment. It is a quote. That confusion was after reading it several time before writing the message because I wasn't sure what you meant by this quote. And the best I could come up with is that we were using --preload-app So still confused but glad it got sorted out in this end ^o^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #32 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What|Removed |Added Attachment #139565|0 |1 is obsolete|| --- Comment #31 from Marcel de Rooy --- Created attachment 139669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139669=edit Bug 21366: Add --reload option to koha-plack help/manual Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What|Removed |Added Attachment #139015|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 139668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139668=edit Bug 21366: Add koha-plack --reload to gracefully restart Plack/Starman This patch adds a "--reload" option to koha-plack, which allows a sysadmin to gracefully restart Koha. This is very useful when installing Koha plugins or deploying a hot fix where you need to change code but don't want to interrupt anyone's usage of Koha. 0. Apply patch 1. cp /usr/sbin/koha-plack /usr/sbin/koha-plack.bak 2. cp debian/scripts/koha-plack /usr/sbin/koha-plack 3. ps -efww | grep "starman" 4. Now at roughly the same time do the following two actions: 4a. Go to http://localhost:8081/cgi-bin/koha/about.pl 4b. koha-plack --reload kohadev 5. Note that the web request completes successfully 6. ps -efww | grep "starman" 7. Note that the "starman master" process stays alive, but the "starman worker" processes have been restarted Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #29 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #27) > > seconds. Using koha-plack --reload will wait for that long search request to > > complete, and then it will restart that worker. koha-plack does not wait for the request to complete but it does the job as expected: The current request gave me back the old contents, but Starman closed the old worker afterwards since a new request gives me the new contents. Excellent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #28 from David Cook --- (In reply to Marcel de Rooy from comment #27) > > I chose the about.pl test somewhat arbitrarily because koha-testing-docker > > is such a small database. In production, where you really see this being > > useful is in search.pl and opac-search.pl where a search might take 5+ > > seconds. Using koha-plack --reload will wait for that long search request to > > complete, and then it will restart that worker. > I do not use k-t-d, but your point is clear. > > Resuming QA scheduled for this afternoon. I'll be around on and off for the next 5-7 hours, so shoot me any questions you might have. For what it's worth, I have a "reload_koha.sh" script I use in production all the time, especially when updating plugins, and it's wonderful hehe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #27 from Marcel de Rooy --- (In reply to David Cook from comment #25) > We don't use --preload-app, so we don't need to worry about it. I know that. Quoting etc. > Even if we did use --preload-app, I think some of the text is misleading. > While code changes to code that is preloaded wouldn't come through, changes > to code that is lazy loaded after forking the children would still come > through. This explains my testing. Lazy brain :) All workers need to cache the old code first obviously. I just got the wrong worker a few times. Inspired by Victor, I will set the number of workers as low as possible and test again.. > I chose the about.pl test somewhat arbitrarily because koha-testing-docker > is such a small database. In production, where you really see this being > useful is in search.pl and opac-search.pl where a search might take 5+ > seconds. Using koha-plack --reload will wait for that long search request to > complete, and then it will restart that worker. I do not use k-t-d, but your point is clear. Resuming QA scheduled for this afternoon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #26 from Marcel de Rooy --- (In reply to Victor Grousset/tuxayo from comment #24) > (In reply to Marcel de Rooy from comment #23) > What do you mean? The patch doesn't use --preload-app. I did not say that. Please read the comment. It is a quote. > I tested changing something in about.pl: once over the ~10 tries the change > was reflected only by reloading the page. Otherwise I had to run `pkill > starman --signal SIGHUP` to get the change. I had the change reflected all tries. The comment of David explains it, I guess. > Your plack_max_requests isn't 1 is it? That would be an explanation of what > you observed. No it is not :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #25 from David Cook --- (In reply to Marcel de Rooy from comment #23) > If you enable --preload-app option, however, the code will be only loaded in > the startup process and will not pick up the code changes you made. If you > want to preload the app and do graceful restarts by reloading the code > changes, you're recommended to use Server::Starter, configured to send QUIT > signal when superdaemon received HUP ... > [End of quote] We don't use --preload-app, so we don't need to worry about it. Even if we did use --preload-app, I think some of the text is misleading. While code changes to code that is preloaded wouldn't come through, changes to code that is lazy loaded after forking the children would still come through. I use mod_perl for a different Perl app where I preload the core Catalyst application into the httpd master process so that slow setup like the ORM just takes place 1 time, and then all the lazy loads for function specific things happen within the child processes. > While testing with about and inserting a small code change, I notice that > while I started the about web request before the plack reload, the code > change already is visible in the web request. > I think that this is not what we want here ? If you want to test a small code change, you'd need to first make sure that all Starman workers have already cached the about.pl page in their CGI to PSGI cache. Once they're cached, then you can make your code change, confirm that the change isn't visible, do the reload, and then note that the change is visible. I chose the about.pl test somewhat arbitrarily because koha-testing-docker is such a small database. In production, where you really see this being useful is in search.pl and opac-search.pl where a search might take 5+ seconds. Using koha-plack --reload will wait for that long search request to complete, and then it will restart that worker. -- Does that answer your questions? I will be online a bit tonight (ie European morning) so might be able to answer more on IRC :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #24 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #23) > If you enable --preload-app option, however, the code will be only loaded in > the startup process and will not pick up the code changes you made. If you > want to preload the app and do graceful restarts by reloading the code > changes, you're recommended to use Server::Starter, configured to send QUIT > signal when superdaemon received HUP ... > [End of quote] > While testing with about and inserting a small code change, I notice that > while I started the about web request before the plack reload, the code > change already is visible in the web request. > I think that this is not what we want here ? What do you mean? The patch doesn't use --preload-app. I tested changing something in about.pl: once over the ~10 tries the change was reflected only by reloading the page. Otherwise I had to run `pkill starman --signal SIGHUP` to get the change. Your plack_max_requests isn't 1 is it? That would be an explanation of what you observed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #23 from Marcel de Rooy --- Reading this on CPAN: Sending HUP signal to the master process will restart all the workers gracefully (meaning the currently running requests will shut down once the request is complete), and by default, the workers will pick up the code changes you make by reloading the application. If you enable --preload-app option, however, the code will be only loaded in the startup process and will not pick up the code changes you made. If you want to preload the app and do graceful restarts by reloading the code changes, you're recommended to use Server::Starter, configured to send QUIT signal when superdaemon received HUP ... [End of quote] While testing with about and inserting a small code change, I notice that while I started the about web request before the plack reload, the code change already is visible in the web request. I think that this is not what we want here ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #22 from Victor Grousset/tuxayo --- Last patch amended to explain what reloading means. Reload the Plack daemon for the desired Koha instances. ↓↓↓ Reload the Plack daemon for the desired Koha instances, letting the busy workers finish processing their requests before restarting them. Tell me if the phrasing can be improved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #139035|0 |1 is obsolete|| --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 139565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139565=edit Bug 21366: Add --reload option to koha-plack help/manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #20 from David Cook --- (Side note, I've opened bug 31348 to handle graceful stopping of Starman/Plack as well.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31348 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #19 from David Cook --- Created attachment 139035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139035=edit Bug 21366: Add --reload option to koha-plack help/manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #18 from David Cook --- (In reply to Jonathan Druart from comment #17) > Note that the help is missing the new option. Believe it or not, that thought crossed my mind as I was falling asleep last night haha. I'll look at that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #17 from Jonathan Druart --- Note that the help is missing the new option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Jonathan Druart changed: What|Removed |Added Attachment #139011|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 139015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139015=edit Bug 21366: Add koha-plack --reload to gracefully restart Plack/Starman This patch adds a "--reload" option to koha-plack, which allows a sysadmin to gracefully restart Koha. This is very useful when installing Koha plugins or deploying a hot fix where you need to change code but don't want to interrupt anyone's usage of Koha. 0. Apply patch 1. cp /usr/sbin/koha-plack /usr/sbin/koha-plack.bak 2. cp debian/scripts/koha-plack /usr/sbin/koha-plack 3. ps -efww | grep "starman" 4. Now at roughly the same time do the following two actions: 4a. Go to http://localhost:8081/cgi-bin/koha/about.pl 4b. koha-plack --reload kohadev 5. Note that the web request completes successfully 6. ps -efww | grep "starman" 7. Note that the "starman master" process stays alive, but the "starman worker" processes have been restarted Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #15 from David Cook --- Ok patch prepared. Looking at Fridolin and Joonas for sign off and QA! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #14 from David Cook --- Created attachment 139011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139011=edit Bug 21366: Add koha-plack --reload to gracefully restart Plack/Starman This patch adds a "--reload" option to koha-plack, which allows a sysadmin to gracefully restart Koha. This is very useful when installing Koha plugins or deploying a hot fix where you need to change code but don't want to interrupt anyone's usage of Koha. 0. Apply patch 1. cp /usr/sbin/koha-plack /usr/sbin/koha-plack.bak 2. cp debian/scripts/koha-plack /usr/sbin/koha-plack 3. ps -efww | grep "starman" 4. Now at roughly the same time do the following two actions: 4a. Go to http://localhost:8081/cgi-bin/koha/about.pl 4b. koha-plack --reload kohadev 5. Note that the web request completes successfully 6. ps -efww | grep "starman" 7. Note that the "starman master" process stays alive, but the "starman worker" processes have been restarted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Jonathan Druart changed: What|Removed |Added Assignee|tomasco...@gmail.com|koha-b...@lists.koha-commun ||ity.org Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Katrin Fischer changed: What|Removed |Added Summary|add plack reload|Add Plack reload -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #13 from David Cook --- (In reply to Jonathan Druart from comment #11) > This bug report is assigned, can we expect a patch soon? It should be a simple patch. I feel like I'd probably be more useful in test/QA for this one, but I could write it if no one else is going to... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #12 from David Cook ---
(In reply to Joonas Kylmälä from comment #2)
> In koha-suomi fork we use start-stop-daemon to send the HUP signal, that's
> probably the preferable way since koha-plack uses start-stop-daemon already
> to send the process kill signal.
Would that look like the following?
start-stop-daemon --pidfile ${PIDFILE} --user="${instancename}-koha" --stop
--signal HUP;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #11 from Jonathan Druart --- This bug report is assigned, can we expect a patch soon? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #10 from David Cook --- (In reply to Andreas Jonsson from comment #8) > Would it be too risky to send a HUP-signal to the plack process > automatically when a plugin is reuploaded? > > I think that this would be very nice, as it would make plugins upgradable > without command line access. I've opened bug 30897 for this one but it's easier said than done... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30897 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 David Cook changed: What|Removed |Added Depends on|30684 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 [Bug 30684] koha-* scripts --restart should start even when not running -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #9 from David Cook --- (In reply to Andreas Jonsson from comment #8) > Would it be too risky to send a HUP-signal to the plack process > automatically when a plugin is reuploaded? > > I think that this would be very nice, as it would make plugins upgradable > without command line access. You know... I've been thinking about that idea for years but I never actually tried it. I just tried it now and it worked well! With the Debian packages, each instance is run using a specific Linux user, and it looks like that Linux user can HUP processes it owns, so yeah... it works. -- In terms of risk, I suppose allowing a web user to affect background Linux processes is not ideal. I have noticed that the REST API can be slow to startup and can consume a lot of CPU, so I suppose the risk would be that an accident or an attack could lead to a denial of service. But I think that's a fairly low risk. After all, you can already do a DDOS by attacking the OPAC search function. So I think the risk is worth the reward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se --- Comment #8 from Andreas Jonsson --- Would it be too risky to send a HUP-signal to the plack process automatically when a plugin is reuploaded? I think that this would be very nice, as it would make plugins upgradable without command line access. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 David Cook changed: What|Removed |Added Depends on||30684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 [Bug 30684] koha-* scripts --restart should start even when not running -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #7 from David Cook --- Question: - Do we want "koha-plack --reload" or do we want "koha-plack --graceful" or both? I think Apache treats reload/graceful/force-reload as the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #6 from David Cook --- I don't know if we could use it with Koha package installs, as I think the koha-common service is stopped and started, although I'm not 100% sure of that mechanism at this point... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #5 from David Cook --- (In reply to Fridolin Somers from comment #1) > To trigger this reload, juste run : > > /bin/kill -HUP $MASTER_PID > > MASTER_PID beeing the pid of the starman master process, can be fetched in > pid file. > > Source : > https://metacpan.org/pod/distribution/Starman/script/starman#SIGNALS I'd forgotten about this comment, but I just used the following today in prod: kill -SIGHUP $(cat /var/run/koha//plack.pid) I wanted to enable plugins and then reload after installing the plugin, and it was so elegant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #4 from David Cook --- (In reply to Joonas Kylmälä from comment #2) > In koha-suomi fork we use start-stop-daemon to send the HUP signal, that's > probably the preferable way since koha-plack uses start-stop-daemon already > to send the process kill signal. I'm only seeing "start-stop-daemon" for koha-plack --stop for some reason... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- This would be great -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #2 from Joonas Kylmälä --- In koha-suomi fork we use start-stop-daemon to send the HUP signal, that's probably the preferable way since koha-plack uses start-stop-daemon already to send the process kill signal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #1 from Fridolin SOMERS --- To trigger this reload, juste run : /bin/kill -HUP $MASTER_PID MASTER_PID beeing the pid of the starman master process, can be fetched in pid file. Source : https://metacpan.org/pod/distribution/Starman/script/starman#SIGNALS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
