[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin SOMERS --- Very nice and useful. Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Works as expected, no regressions found. Code is good and moves us towards a more unified experience. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize changed: What|Removed |Added Attachment #80177|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 80254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80254=edit Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Michal Denar changed: What|Removed |Added Attachment #80176|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 80177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80177=edit Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos changed: What|Removed |Added Priority|P5 - low|P3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 --- Comment #1 from Andreas Roussos --- Created attachment 80176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80176=edit Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21513] Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos changed: What|Removed |Added Assignee|oleon...@myacpl.org |arouss1...@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
