[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 M. Tompsett changed: What|Removed |Added Attachment #82701|0 |1 is obsolete|| Attachment #82702|0 |1 is obsolete|| Attachment #82703|0 |1 is obsolete|| --- Comment #13 from M. Tompsett --- Created attachment 82720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82720&action=edit Bug 21896: Add unit tests for Koha::Account::normalize_balance Signed-off-by: Christopher Brannon Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #14 from M. Tompsett --- Created attachment 82721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82721&action=edit Bug 21896: Add Koha::Account::normalize_balance This patch adds the normalize_balance() method to Koha::Account. Its purpose is to apply outstanding credits (i.e. manual ones ore remaining amounts like in the case of refunds) to outstanding debts. To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Christopher Brannon Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #15 from M. Tompsett --- Created attachment 82722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82722&action=edit Bug 21896: (QA follow-up) normalize_balance -> reconcile_balance rename This was requested on the QA review and I agree. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 82703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82703&action=edit Bug 21896: (QA follow-up) normalize_balance -> reconcile_balance rename This was requested on the QA review and I agree. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82691|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 82702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82702&action=edit Bug 21896: Add Koha::Account::normalize_balance This patch adds the normalize_balance() method to Koha::Account. Its purpose is to apply outstanding credits (i.e. manual ones ore remaining amounts like in the case of refunds) to outstanding debts. To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82690|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 82701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82701&action=edit Bug 21896: Add unit tests for Koha::Account::normalize_balance Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #9 from Martin Renvoize --- First comment is that I think I prefer the term 'reconcile' to the term 'normalize'.. To me reconcile means to apply one action against each other to tend towards a 'happy place', i.e. apply credits against debits to work towards balance zero, in the accounting sense... whereas normalize means to 'make the same for comparison' so you can continue with calculations, so the accounting example here would be to convert all accounts in various currencies into one 'normalized' currency before doing calculations upon them. Hope that makes sense.. maybe it's just my scientific background speaking out. Second comment is a question.. do we need to do anything logical in terms of the order of application of credits against debits.. i.e. should it be oldest debts first, smallest debts first, blocking debts first for example? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #8 from Christopher Brannon --- Sorry, I am struggling with the sign off process still. :/ I hope I didn't screw anything up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82692|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #7 from Christopher Brannon --- Created attachment 82692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82692&action=edit Bug 21896: Add unit tests for Koha::Account::normalize_balance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82691|Bug 21896: Add |[SIGNED OFF]Bug 21896: Add description|Koha::Account::normalize_ba |Koha::Account::normalize_ba |lance |lance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82685|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #6 from Christopher Brannon --- Created attachment 82691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82691&action=edit Bug 21896: Add Koha::Account::normalize_balance This patch adds the normalize_balance() method to Koha::Account. Its purpose is to apply outstanding credits (i.e. manual ones ore remaining amounts like in the case of refunds) to outstanding debts. To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82685|Bug 21896: Add |[SIGNED OFF]Bug 21896: Add description|Koha::Account::normalize_ba |Koha::Account::normalize_ba |lance |lance Attachment #82685|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82688|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82689|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82688|Bug 21896: Add unit tests |[SIGNED OFF]Bug 21896: Add description|for |unit tests for |Koha::Account::normalize_ba |Koha::Account::normalize_ba |lance |lance Attachment #82688|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82690|Bug 21896: Add unit tests |[SIGNED OFF]Bug 21896: Add description|for |unit tests for |Koha::Account::normalize_ba |Koha::Account::normalize_ba |lance |lance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82688|0 |1 is obsolete|| --- Comment #5 from Christopher Brannon --- Created attachment 82690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82690&action=edit Bug 21896: Add unit tests for Koha::Account::normalize_balance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org Attachment #82688|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82685|0 |1 is obsolete|| Attachment #82688|0 |1 is obsolete|| --- Comment #4 from Christopher Brannon --- Created attachment 82689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82689&action=edit [SIGNED OFF]Bug 21896: Add unit tests for Koha::Account::normalize_balance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Christopher Brannon changed: What|Removed |Added Attachment #82684|0 |1 is obsolete|| --- Comment #3 from Christopher Brannon --- Created attachment 82688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82688&action=edit Bug 21896: Add unit tests for Koha::Account::normalize_balance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added Blocks||18805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 [Bug 18805] Add ability to use up account credits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 82685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82685&action=edit Bug 21896: Add Koha::Account::normalize_balance This patch adds the normalize_balance() method to Koha::Account. Its purpose is to apply outstanding credits (i.e. manual ones ore remaining amounts like in the case of refunds) to outstanding debts. To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 82684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82684&action=edit Bug 21896: Add unit tests for Koha::Account::normalize_balance -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::normalize_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added Summary|Add |Add |Koha::Account::normalize_ac |Koha::Account::normalize_ba |count |lance CC||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
