[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 --- Comment #1 from Nick Clemens --- Created attachment 82741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82741&action=edit Bug 21910: Koha::Library::Groups->get_search_groups should return the groups To test: 1 - Add a library group (Admin->Library groups) 2 - Enable use as an opac and staff search limit 3 - Add some libraries to the group 4 - Visit advanced search on staff and opac 5 - Note the dropdown has as many empty rows as there are libraries in the group 6 - Apply patch, restart all the things 7 - Visit staff and opac advanced search 8 - Confirm the group dropdowns are correct 9 - Enable OpacMastheadLibraryPulldown 10 - Ensure the dropdown on opac shows groups correctly 11 - Confirm earchign groups works from all three locations 12 - prove -v t/db_dependent/LibraryGroups.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Nick Clemens changed: What|Removed |Added Blocks||21911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 [Bug 21911] Scoping OPACs by branch does not work with new library groups -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Martin Renvoize changed: What|Removed |Added Attachment #82741|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 82755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82755&action=edit Bug 21910: Koha::Library::Groups->get_search_groups should return the groups To test: 1 - Add a library group (Admin->Library groups) 2 - Enable use as an opac and staff search limit 3 - Add some libraries to the group 4 - Visit advanced search on staff and opac 5 - Note the dropdown has as many empty rows as there are libraries in the group 6 - Apply patch, restart all the things 7 - Visit staff and opac advanced search 8 - Confirm the group dropdowns are correct 9 - Enable OpacMastheadLibraryPulldown 10 - Ensure the dropdown on opac shows groups correctly 11 - Confirm earchign groups works from all three locations 12 - prove -v t/db_dependent/LibraryGroups.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Works as expected and has tests.. Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Josef Moravec changed: What|Removed |Added Attachment #82755|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 82766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82766&action=edit Bug 21910: Koha::Library::Groups->get_search_groups should return the groups To test: 1 - Add a library group (Admin->Library groups) 2 - Enable use as an opac and staff search limit 3 - Add some libraries to the group 4 - Visit advanced search on staff and opac 5 - Note the dropdown has as many empty rows as there are libraries in the group 6 - Apply patch, restart all the things 7 - Visit staff and opac advanced search 8 - Confirm the group dropdowns are correct 9 - Enable OpacMastheadLibraryPulldown 10 - Ensure the dropdown on opac shows groups correctly 11 - Confirm earchign groups works from all three locations 12 - prove -v t/db_dependent/LibraryGroups.t Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Jonathan Druart changed: What|Removed |Added Depends on||20157 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Jonathan Druart changed: What|Removed |Added Attachment #82766|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 82915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82915&action=edit Bug 21910: Koha::Library::Groups->get_search_groups should return the groups To test: 1 - Add a library group (Admin->Library groups) 2 - Enable use as an opac and staff search limit 3 - Add some libraries to the group 4 - Visit advanced search on staff and opac 5 - Note the dropdown has as many empty rows as there are libraries in the group 6 - Apply patch, restart all the things 7 - Visit staff and opac advanced search 8 - Confirm the group dropdowns are correct 9 - Enable OpacMastheadLibraryPulldown 10 - Ensure the dropdown on opac shows groups correctly 11 - Confirm earchign groups works from all three locations 12 - prove -v t/db_dependent/LibraryGroups.t Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 --- Comment #7 from Jonathan Druart --- Created attachment 82917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82917&action=edit Bug 21910: Does not deal with call context, ->search does already Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 --- Comment #6 from Jonathan Druart --- Created attachment 82916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82916&action=edit Bug 21910: Remove duplicated lines in tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #10 from Jesse Maseto --- Pushed to 18.05.x for 18.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #11 from Fridolin SOMERS --- Depends on Bug 20157 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
