[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 --- Comment #12 from Martin Renvoize --- *** Bug 17683 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS --- Depends on Bug 21910 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Bug 21911 depends on bug 21910, which changed state. Bug 21910 Summary: Koha::Library::Groups->get_search_groups should return the groups, not the children https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #10 from Jesse Maseto --- Pushed to 18.05.x for 18.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Marcel de Rooy changed: What|Removed |Added Attachment #82767|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 82950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82950=edit Bug 21911: Regression test This tests usuall cases, but note, that administrator could make a branch with code "%%%" or so, which this test does not cover, and some functionalities will not work in that case: opac limit override, holdinbranch facet Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Marcel de Rooy changed: What|Removed |Added Attachment #82754|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 82949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82949=edit Bug 21911: Fix OPAC scoping to work with new group system To test: 0 - Apply patch 1 - Create a library group enabled for opac search limits and add some libraries 2 - Check the DB (or advanced search dropdown) to get the id of the group (using 7 as example below) 3 - Add to apache configuration (OPAC virtualhost) SetEnv OPAC_SEARCH_LIMIT branch:multibranchlimit-7 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-7" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 4 - Ensure OpacAddMastheadLibraryPulldown is disabled 5 - Restart all the things 6 - Visit the opac 7 - Perform a search, confirm it is scoped to the branches in the group Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #5 from Josef Moravec --- The problem is a bit wider a think: It is possible ta create a library with code "%%%" for example - it is weird, but you can do it. Then this will not work again... even facets does not work with these kind of library codes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 --- Comment #4 from Josef Moravec --- Created attachment 82767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82767=edit Bug 21911: Regression test This tests usuall cases, but note, that administrator could make a branch with code "%%%" or so, which this test does not cover, and some functionalities will not work in that case: opac limit override, holdinbranch facet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Works as expected, Signing off.. With my QA hat on, it would be lovely to have a regression test for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Martin Renvoize changed: What|Removed |Added Attachment #82743|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 82754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82754=edit Bug 21911: Fix OPAC scoping to work with new group system To test: 0 - Apply patch 1 - Create a library group enabled for opac search limits and add some libraries 2 - Check the DB (or advanced search dropdown) to get the id of the group (using 7 as example below) 3 - Add to apache configuration (OPAC virtualhost) SetEnv OPAC_SEARCH_LIMIT branch:multibranchlimit-7 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-7" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 4 - Ensure OpacAddMastheadLibraryPulldown is disabled 5 - Restart all the things 6 - Visit the opac 7 - Perform a search, confirm it is scoped to the branches in the group Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Nick Clemens changed: What|Removed |Added Depends on||21910 Assignee|oleon...@myacpl.org |n...@bywatersolutions.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||kyle.m.h...@gmail.com, ||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 --- Comment #1 from Nick Clemens --- Created attachment 82743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82743=edit Bug 21911: Fix OPAC scoping to work with new group system To test: 0 - Apply patch 1 - Create a library group enabled for opac search limits and add some libraries 2 - Check the DB (or advanced search dropdown) to get the id of the group (using 7 as example below) 3 - Add to apache configuration (OPAC virtualhost) SetEnv OPAC_SEARCH_LIMIT branch:multibranchlimit-7 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-7" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 4 - Ensure OpacAddMastheadLibraryPulldown is disabled 5 - Restart all the things 6 - Visit the opac 7 - Perform a search, confirm it is scoped to the branches in the group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/