[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer changed: What|Removed |Added Summary|Permissions for Holds |Permission for holds |History Tab |history tab is too strict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #3 from Katrin Fischer --- I've tried fixing it as suggested, can you please test? Should work fine on sandboxes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Séverine Queune changed: What|Removed |Added Attachment #94972|0 |1 is obsolete|| --- Comment #4 from Séverine Queune --- Created attachment 94991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94991&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 ByWater Sandboxes changed: What|Removed |Added Attachment #94991|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 95128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95128&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE Signed-off-by: Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jonathan Druart changed: What|Removed |Added Attachment #95128|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 95147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95147&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE Signed-off-by: Bob Bennhoff Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #8 from Liz Rea --- Hi, May we have this for 19.05 as well? It applies cleanly and works nicely there. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Hayley Mapley changed: What|Removed |Added Version(s)|19.11.00|19.11.00, 18.11.12 released in|| CC||hayleymap...@catalyst.net.n ||z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Hayley Mapley changed: What|Removed |Added Version(s)|19.11.00, 18.11.12 |19.11.00, 19.05.06, released in||18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/