[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Didier Gautheron changed: What|Removed |Added Blocks||28259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259 [Bug 28259] Checking at branch B an item in waiting hold state at branch A kill koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 koha-US bug tracker changed: What|Removed |Added CC|bugzi...@koha-us.org| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What|Removed |Added Blocks||26386 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26386 [Bug 26386] Fixing of waiting holds at wrong location crashes in certain situations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Stefan Berndtsson changed: What|Removed |Added CC||stefan.berndts...@ub.gu.se --- Comment #46 from Stefan Berndtsson --- (In reply to Lisette Scheer from comment #33) > With the patches appled, at step 4 in the test plan when I confirm the > transfer, I get this: > > Can't call method "biblio" on an undefined value at > /kohadevbox/koha/circ/returns.pl line 158 > > > It does seem to set the item back to a record level hold but the expiration > date persists and it doesn't set it into transit, just sets the current > location to be the branch it was scanned into most recently. > > Lisette I have created a new Bug 26386 detailing how to recreate this issue, and what I assume is the sequence causing it to crash. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #45 from Lucas Gass --- this patchset does not cleanly apply to 19.05.x, no backport if this is wanted/needed please rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.04 released in|| --- Comment #44 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #43 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What|Removed |Added Blocks||23070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #42 from Jonathan Druart --- Created attachment 99167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99167=edit Bug 21944: Improve efficiency of code Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #41 from Jonathan Druart --- Created attachment 99166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99166=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What|Removed |Added Attachment #98528|0 |1 is obsolete|| Attachment #98529|0 |1 is obsolete|| Attachment #98530|0 |1 is obsolete|| --- Comment #40 from Jonathan Druart --- Created attachment 99165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99165=edit Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What|Removed |Added Attachment #95951|0 |1 is obsolete|| --- Comment #37 from Martin Renvoize --- Created attachment 98529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98529=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #39 from Martin Renvoize --- Back to signed off.. I can't replicate the issues either.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What|Removed |Added Attachment #95952|0 |1 is obsolete|| --- Comment #38 from Martin Renvoize --- Created attachment 98530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98530=edit Bug 21944: Improve efficiency of code Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What|Removed |Added Attachment #95950|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 98528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98528=edit Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #35 from Nick Clemens --- The problem still exists on master in my testing, these patches fix the problem I cannot recreate the error encountered by Ben or Lisette, these patches do not touch returns.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com --- Comment #34 from Benjamin Daeuber --- (In reply to Christopher Brannon from comment #31) > (In reply to Jonathan Druart from comment #30) > > Christopher, could you add your stamp on Kyle's follow-up? > > I tested master without the patch, and the hold is routed properly. > Something has changed. I don't know if it is Owen's work on the modal, but > it seems to be working properly without the patch. Can anyone confirm? The problem is still occurring on master for me. However, I am getting the same error as Lisette when testing the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #33 from Lisette Scheer --- With the patches appled, at step 4 in the test plan when I confirm the transfer, I get this: Can't call method "biblio" on an undefined value at /kohadevbox/koha/circ/returns.pl line 158 It does seem to set the item back to a record level hold but the expiration date persists and it doesn't set it into transit, just sets the current location to be the branch it was scanned into most recently. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #32 from Nick Clemens --- The unit tests still fail without the patches, possibly we are handling something in the templates to work around this, but we should still correct the underlying issues. Would you be willing to test with the patches Christopher to ensure they do not break anything? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #31 from Christopher Brannon --- (In reply to Jonathan Druart from comment #30) > Christopher, could you add your stamp on Kyle's follow-up? I tested master without the patch, and the hold is routed properly. Something has changed. I don't know if it is Owen's work on the modal, but it seems to be working properly without the patch. Can anyone confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #30 from Jonathan Druart --- Christopher, could you add your stamp on Kyle's follow-up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #28 from Kyle M Hall --- Created attachment 95951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95951=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #29 from Kyle M Hall --- Created attachment 95952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95952=edit Bug 21944: Improve efficiency of code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Kyle M Hall changed: What|Removed |Added Attachment #94220|0 |1 is obsolete|| Attachment #94221|0 |1 is obsolete|| --- Comment #27 from Kyle M Hall --- Created attachment 95950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95950=edit Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #26 from Marcel de Rooy ---
($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
# if a hold is found and is waiting at another branch, change the priority
back to 1 and trigger the hold (this will trigger a transfer and update the
hold status properly)
if ( $resfound eq "Waiting" and $branch ne $resrec->{branchcode} ) {
C4::Reserves::RevertWaitingStatus( { itemnumber => $item->itemnumber }
);
#If the hold is reverted we need to refetch for the return values
($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
}
($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
In short what do we see here:
call CheckReserves
if( )
call CheckReserves
endif
call CheckReserves
Three times in a row ? Please explain why you also add the last call. Rebase
problem?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944
--- Comment #25 from Marcel de Rooy ---
not ok 19 - AddReturn must have debarred the patron
# Failed test 'AddReturn must have debarred the patron'
# at t/db_dependent/Circulation.t line 86.
# got: ''
# expected: '1'
# AddReturn returned message $VAR1 = {
# 'WasReturned' => 1
# };
not ok 20 - Test at line 1922
# Failed test 'Test at line 1922'
# at t/db_dependent/Circulation.t line 90.
# got: '0'
# expected: '1'
not ok 21 - Test at line 1922
# Failed test 'Test at line 1922'
# at t/db_dependent/Circulation.t line 93.
# got: undef
# expected: '2019-11-15'
# Looks like you failed 3 tests of 21.
not ok 29 - AddReturn + suspension_chargeperiod
# Failed test 'AddReturn + suspension_chargeperiod'
# at t/db_dependent/Circulation.t line 1931.
# Looks like you failed 1 test of 45.
First time I ran Circulation.t, I got this. But I do not manage to reproduce it
another time ;) And it seems unrelated. No holds stuff there.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl --- Comment #24 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #23 from Jonathan Druart --- (In reply to Magnus Enger from comment #19) > ...and it looks like I get the same errors from running this: > $ sudo koha-shell -c "prove t/db_dependent/Circulation.t" kohadev > on current master (without the patches on this bug) as I get from running it > *with* the patches. So those failures are probably not related to these > patches. Yes, see bug 23234. I get those ones as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #22 from Martin Renvoize --- Seems to work as described, Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What|Removed |Added Attachment #92610|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 94221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94221=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Martin Renvoize changed: What|Removed |Added Attachment #92609|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 94220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94220=edit Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #19 from Magnus Enger --- ...and it looks like I get the same errors from running this: $ sudo koha-shell -c "prove t/db_dependent/Circulation.t" kohadev on current master (without the patches on this bug) as I get from running it *with* the patches. So those failures are probably not related to these patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #18 from Magnus Enger --- The first set of failures looks weird: # got: '2019-09-08T00:00:00' # expected: '2019-09-08T00:00:00' Are they not identical? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #17 from Nick Clemens --- (In reply to Magnus Enger from comment #16) > The patch works as advertised for me, but I get a bunch of errors when I try > to run the tests: I cannot recreate these failures, I do note that I get some failures if I have a timezone set in koha-conf.xml - if I remove that all pass, but that is true without my patch as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #16 from Magnus Enger --- The patch works as advertised for me, but I get a bunch of errors when I try to run the tests: $ sudo koha-shell -c "prove t/db_dependent/Circulation.t" kohadev t/db_dependent/Circulation.t .. 1/45 # Failed test 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before' # at t/db_dependent/Circulation.t line 862. # got: '2019-09-01T11:32:00' # expected: '2019-09-01T11:32:00' # Failed test 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before' # at t/db_dependent/Circulation.t line 869. # got: '2019-09-11T11:32:00' # expected: '2019-09-11T11:32:00' # Failed test 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after' # at t/db_dependent/Circulation.t line 876. # got: '2019-09-08T00:00:00' # expected: '2019-09-08T00:00:00' # Failed test 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after' # at t/db_dependent/Circulation.t line 882. # got: '2019-09-08T00:00:00' # expected: '2019-09-08T00:00:00' # Looks like you failed 4 tests of 5. # Failed test 'GetLatestAutoRenewDate' # at t/db_dependent/Circulation.t line 887. # Looks like you failed 1 test of 71. t/db_dependent/Circulation.t .. 15/45 # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 998. t/db_dependent/Circulation.t .. 18/45 # Failed test 'There should not be any errors or alerts (impossible) (error: EXPIRED) (question: ISSUED_TO_ANOTHER issued_firstname issued_borrowernumber issued_surname issued_cardnumber)' # at t/db_dependent/Circulation.t line 1326. # got: '1' # expected: '0' # Failed test 'There should not be any errors or alerts (impossible) (error: EXPIRED) (question: issued_surname issued_borrowernumber issued_cardnumber issued_firstname ISSUED_TO_ANOTHER)' # at t/db_dependent/Circulation.t line 1331. # got: '1' # expected: '0' # Failed test 'There should not be any errors or alerts (impossible) (error: EXPIRED) (question: issued_firstname ISSUED_TO_ANOTHER issued_cardnumber issued_borrowernumber issued_surname)' # at t/db_dependent/Circulation.t line 1335. # got: '1' # expected: '0' # Failed test 'There should not be any errors or alerts (impossible) (error: EXPIRED) (question: ISSUED_TO_ANOTHER issued_firstname issued_borrowernumber issued_surname issued_cardnumber)' # at t/db_dependent/Circulation.t line 1349. # got: '1' # expected: '0' # Failed test 'There should not be any errors or alerts (impossible) (error: EXPIRED) (question: issued_firstname ISSUED_TO_ANOTHER issued_cardnumber issued_surname issued_borrowernumber)' # at t/db_dependent/Circulation.t line 1363. # got: '1' # expected: '0' # Looks like you failed 5 tests of 24. t/db_dependent/Circulation.t .. 22/45 # Failed test 'CanBookBeIssued & AllowReturnToBranch' # at t/db_dependent/Circulation.t line 1379. t/db_dependent/Circulation.t .. 23/45 # Failed test 'No key for error and alert (error: EXPIRED) (question: USERBLOCKEDOVERDUE)' # at t/db_dependent/Circulation.t line 1489. # got: '1' # expected: '0' # Looks like you failed 1 test of 8. t/db_dependent/Circulation.t .. 24/45 # Failed test 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' # at t/db_dependent/Circulation.t line 1508. t/db_dependent/Circulation.t .. 25/45 # Failed test 'No error or alert should be raised (error: EXPIRED) (question: BIBLIO_ALREADY_ISSUED)' # at t/db_dependent/Circulation.t line 1674. # got: '1' # expected: '0' # Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1 (error: EXPIRED)' # at t/db_dependent/Circulation.t line 1679. # got: '1' # expected: '0' # Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription (error: EXPIRED)' # at t/db_dependent/Circulation.t line 1686. # got: '1' # expected: '0' # Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription (error: EXPIRED)' # at t/db_dependent/Circulation.t line 1690. # got: '1' # expected: '0' # Looks like you failed 4 tests of 5. t/db_dependent/Circulation.t .. 27/45 # Failed test 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' # at t/db_dependent/Circulation.t line 1691. t/db_dependent/Circulation.t .. 38/45 #
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #15 from Nick Clemens --- Patches rebased and retested, they work for me, can you test and explain the problem Christopher? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What|Removed |Added Attachment #84753|0 |1 is obsolete|| Attachment #84754|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 92609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92609=edit Bug 21944: Test for Circulation.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #14 from Nick Clemens --- Created attachment 92610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92610=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #12 from Christopher Brannon --- (In reply to Magnus Enger from comment #11) > Any chance we could get this moving again? I tried. My patch worked, but I couldn't figure out how to write the test. It's been a while, so correct me if I am wrong, but Nick's test may work, but his patch doesn't, when I look at the actual results. I gave up because the testing was too complicated, and I couldn't wrap my head around it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added Assignee|cbran...@cdalibrary.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #11 from Magnus Enger --- Any chance we could get this moving again? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #10 from Nick Clemens --- (In reply to Christopher Brannon from comment #6) > > Nick, > The question is, how do I test the branch destination? Essentially the test > needs to check in an item that is waiting at a branch other than the branch > it is waiting at, and see if the item is put back into transit and the > destination is set for the pickup branch. I am not sure how to do this. Your tests need to cover the change you make. They should illustrate the expected behavior of the subroutine. In this case: When AddReturn is called from branch B on an item that is a waiting hold at branch A then the hold should now be marked as 'not waiting' and the message returned should reflect the hold's new status You should (ideally) write your tests first to show how the current code is problematic, then change the subroutine to match the expectation of the tests. In this case you need to check that the hold is not waiting and the priority is set - also that the message returned indicates these values I added new tests and also switched the code to use 'RevertWaitingStatus' since that method does exactly what we want Check these out and let me know if they make sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #9 from Nick Clemens --- Created attachment 84754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84754=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What|Removed |Added Attachment #84752|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 84753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84753=edit Bug 21944: Test for Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What|Removed |Added Attachment #82848|0 |1 is obsolete|| Attachment #83144|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 84752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84752=edit Bug 21944: Test for Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #6 from Christopher Brannon --- (In reply to Christopher Brannon from comment #5) > Comment on attachment 83144 [details] [review] > Bug 21944: Test for Circulation.pm > > [11:01] your tests look lright - except that you call > ModReserveAffect > [11:02] the test shoudl be to do AddReturn on the waiting hold as > if it is at another branch > [11:02] the tests are thenjust checks to verify the situation is > as you expect it Nick, The question is, how do I test the branch destination? Essentially the test needs to check in an item that is waiting at a branch other than the branch it is waiting at, and see if the item is put back into transit and the destination is set for the pickup branch. I am not sure how to do this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #5 from Christopher Brannon --- Comment on attachment 83144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83144 Bug 21944: Test for Circulation.pm [11:01] your tests look lright - except that you call ModReserveAffect [11:02] the test shoudl be to do AddReturn on the waiting hold as if it is at another branch [11:02] the tests are thenjust checks to verify the situation is as you expect it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added Attachment #83144|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added Attachment #83144|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added Attachment #82852|0 |1 is obsolete|| --- Comment #4 from Christopher Brannon --- Created attachment 83144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83144=edit Bug 21944: Test for Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #3 from Christopher Brannon --- Created attachment 82852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82852=edit Bug 21944: Test for Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added Depends on||21346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added Depends on|21346 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #2 from Christopher Brannon --- Working on a unit test update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #1 from Christopher Brannon --- Created attachment 82848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82848=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |cbran...@cdalibrary.org |ity.org | Depends on||21346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
