[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2020-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Nick Clemens  changed:

   What|Removed |Added

 Blocks||24658


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658
[Bug 24658] Deleting items with fines does not update itemnumber in
accountlines to NULL causing ISE
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2020-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||26506


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506
[Bug 26506] Koha::Account::pay will fail if $userenv is not set
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||26332


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332
[Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Nick Clemens  changed:

   What|Removed |Added

   Keywords|Academy,|
   |additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #43 from Martin Renvoize  ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|22600   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600
[Bug 22600] We should add an 'interface' field to accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600
[Bug 22600] We should add an 'interface' field to accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|22421   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421
[Bug 22421] accountlines.issue_id is missing a foreign key constraint
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #42 from Martin Renvoize  ---
Created attachment 87072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87072=edit
Bug 22008: (follow-up) Additional fix for bad test

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #41 from Nick Clemens  ---
Created attachment 87066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87066=edit
Bug 22008: (follow-up) Additional test fix and fix typo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #40 from Nick Clemens  ---
(In reply to Nick Clemens from comment #39)
> Created attachment 86995 [details] [review]
> Bug 22008: Fix failing tests

Followup pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22593


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593
[Bug 22593] Scripts dealing with accountlines need updating for bug 22008
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|22577   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577
[Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Nick Clemens  changed:

   What|Removed |Added

  Attachment #86994|0   |1
is obsolete||

--- Comment #39 from Nick Clemens  ---
Created attachment 86995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86995=edit
Bug 22008: Fix failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #38 from Nick Clemens  ---
Created attachment 86994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86994=edit
Bug 22008: Fix failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22577


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577
[Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22577

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Nick Clemens  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #37 from Nick Clemens  ---
There is an issue here.  Currently we use 0 to indicate an action performed by
command line scripts (userenv is undef, default to 0)

With this patch we must have a real borrowernumber.

If we simply default to 'NULL' we will no longer be able to differentiate fines
from command line from those of deleted users

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #36 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86162|0   |1
is obsolete||
  Attachment #86163|0   |1
is obsolete||
  Attachment #86164|0   |1
is obsolete||

--- Comment #33 from Josef Moravec  ---
Created attachment 86659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86659=edit
Bug 22008: Add tests for new constraints

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #34 from Josef Moravec  ---
Created attachment 86660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86660=edit
Bug 22008: Add missing constraints

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #35 from Josef Moravec  ---
Created attachment 86661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86661=edit
Bug 22008: Fixes to make unit tests pass

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #85767|0   |1
is obsolete||
  Attachment #85768|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall  ---
Created attachment 86162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86162=edit
Bug 22008: Add tests for new constraints

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #32 from Kyle M Hall  ---
Created attachment 86164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86164=edit
Bug 22008: Fixes to make unit tests pass

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #31 from Kyle M Hall  ---
Created attachment 86163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86163=edit
Bug 22008: Add missing constraints

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #29 from Martin Renvoize  ---
The test plan is basically to run the included unit tests.

They test for adding a non-existant user as the manager for an accountline, and
they then try deleting a user whose attached to an accountline as a manager and
test that the accountline isn't deleted.

You could replicate all that manually if you wanted to take the belt and braces
approach.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #28 from Hayley Mapley  ---
Is there a test plan for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #27 from Katrin Fischer  ---
Argh, sory, I misread the diff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #26 from Martin Renvoize  ---
Erm, the item constraint isn't added here, it's one of the few that was already
in place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|14825   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #25 from Katrin Fischer  ---
There is still a bit more to this:
CONSTRAINT `accountlines_ibfk_items` FOREIGN KEY (`itemnumber`) REFERENCES
`items` (`itemnumber`) ON DELETE SET NULL ON UPDATE CASCADE,

I wonder if the same applies here as for issues. (items > deleteditems).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #24 from Martin Renvoize  ---
Reduced the scope here to just add the constraint for manager_id.  Also
converted from NOT IN to LEFT JOIN query.

New bug created for the more complex case involving issue_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #23 from Martin Renvoize  ---
Created attachment 85768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85768=edit
Bug 22008: Add missing constraints

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #85613|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 85767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85767=edit
Bug 22008: Add tests for new constraints

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421
[Bug 22421] accountlines.issue_id is missing a foreign key constraint
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #85614|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2019-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

Summary|Missing constraints on  |accountlines.manager_id is
   |accountlines|missing a foreign key
   ||constraint

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/