[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #31 from Katrin Fischer  ---
Thx, I was a little too fast here as I had to also take care of the dependency
bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #30 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #29)
> CONFLICT (content): Merge conflict in
> koha-tmpl/intranet-tmpl/prog/css/staff-global.css

I obsoleted the patch containing compiled CSS. Instead a "yarn build" step
should be added to the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Owen Leonard  changed:

   What|Removed |Added

 Attachment #102507|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #29 from Katrin Fischer  ---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/css/staff-global.css

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Roberts  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #28 from David Roberts  ---
Looks great. Happy to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #27 from Jonathan Druart  
---
(In reply to David Roberts from comment #23)
> Looks much better, although I quite liked the bullets!

I wanted to keep the view as compact as before. We could see later how to
improve the display.

> However, the email address is out of alignment now:

Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #102485|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  
---
Created attachment 102507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102507&action=edit
Bug 22087: DO NOT PUSH - CSS changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #24 from Jonathan Druart  
---
Created attachment 102505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102505&action=edit
Bug 22087: Remove padding on li's

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #25 from Jonathan Druart  
---
Created attachment 102506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102506&action=edit
Bug 22087: Move the email into the list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #23 from David Roberts  ---
Looks much better, although I quite liked the bullets! However, the email
address is out of alignment now:

https://snipboard.io/pX2kli.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #22 from Jonathan Druart  
---
(In reply to David Roberts from comment #19)
> I've re-tested, and the address format looks much better now. There are
> still problems with the username. I've added a 3rd user to my system now,
> and it seems like each user in the list displays the name of the previous
> user. See screenshot.

Right, good catch! That was a very unexpected behaviour, it is fixed now.

The address parts do not look correct on your screenshot, you should not see
the bullets.
Refresh correctly your browser cache to get the latest css version.

https://snipboard.io/sALU86.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #21 from Jonathan Druart  
---
Created attachment 102492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102492&action=edit
Bug 22087: Prevent variable names colision

We should not use PROCESS:
http://www.template-toolkit.org/docs/manual/Directives.html

" The PROCESS directive is slightly faster than INCLUDE because it
avoids the need to localise (i.e. copy) the variable stash before
processing the template. "

The 'patron' variable is reused by patron-title.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #20 from David Roberts  ---
Created attachment 102486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102486&action=edit
Screenshot

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #19 from David Roberts  ---
I've re-tested, and the address format looks much better now. There are still
problems with the username. I've added a 3rd user to my system now, and it
seems like each user in the list displays the name of the previous user. See
screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #18 from David Roberts  ---
In my example, there are two users. David Roberts (dir) and Glyn Roberts (gdr).
If you look at my screenshot, both users display the name David Roberts, and
the second user is showing the cardnumber dir in brackets whereas it should be
gdr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #17 from Jonathan Druart  
---
(In reply to David Roberts from comment #12)
> Hi, I've tested but the search results screen is mangled. Firstly, there are
> no spaces between the address elements. This is also true when you display a
> single patron. Secondly, my search returns two users, but the usernames of
> each have got confused (see screenshot). Also, when I go to edit one of the
> users, I get an error:
> 
> Software error:
> Template process failed: file error - member-alt-contact-style-us: not found
> at /home/david/kohaclone/C4/Templates.pm line 122.
> For help, please send mail to the webmaster (webmas...@ptfs-europe.co.uk),
> giving this error message and the time and date of the error.

I fixed the software error (on bug 25070), and the space problems. I got
confused by the sample data: the street number is in the address field.

However I do not understand your second point, what is confusing with the
usernames (ie. what are you expecting to be displayed instead)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #16 from Jonathan Druart  
---
Created attachment 102485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102485&action=edit
Bug 22087: DO NOT PUSH - CSS changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #14 from Jonathan Druart  
---
Created attachment 102483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102483&action=edit
Bug 22087: Add space between zipcode and country

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #15 from Jonathan Druart  
---
Created attachment 102484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102484&action=edit
Bug 22087: Add a no_line_break parameter to prevent new lines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #102448|0   |1
is obsolete||
 Attachment #102449|0   |1
is obsolete||
 Attachment #102450|0   |1
is obsolete||
 Attachment #102451|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 102482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102482&action=edit
Bug 22087: Use include file to display patrons address in search result

In order to display the city and country in the patron search result, we
need to use the member-display-address-style include file, to satisfy
AddressFormat.

Test plan:
Modify some patrons and fill the different address info
Search for them and notice that the city, zipcode and country are now
displayed.
Modify the value of AddressFormat and confirm that the display is
modified according to its value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Roberts  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #12 from David Roberts  ---
Hi, I've tested but the search results screen is mangled. Firstly, there are no
spaces between the address elements. This is also true when you display a
single patron. Secondly, my search returns two users, but the usernames of each
have got confused (see screenshot). Also, when I go to edit one of the users, I
get an error:

Software error:
Template process failed: file error - member-alt-contact-style-us: not found at
/home/david/kohaclone/C4/Templates.pm line 122.
For help, please send mail to the webmaster (webmas...@ptfs-europe.co.uk),
giving this error message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #11 from David Roberts  ---
Created attachment 102466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102466&action=edit
Mangled display of patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||25070
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
   Keywords|Academy |

--- Comment #10 from Jonathan Druart  
---
Hello David, could you test these patches?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070
[Bug 25070] Include files to display address and contact must be refactored
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #9 from Jonathan Druart  
---
Created attachment 102451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102451&action=edit
Bug 22087: DO NOT PUSH - CSS changes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #8 from Jonathan Druart  
---
Created attachment 102450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102450&action=edit
Bug 22087: Add a no_line_break parameter to prevent new lines

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #7 from Jonathan Druart  
---
Created attachment 102449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102449&action=edit
Bug 22087: Add space between zipcode and country

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #102064|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 102448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102448&action=edit
Bug 22087: Use include file to display patrons address in search result

In order to display the city and country in the patron search result, we
need to use the member-display-address-style include file, to satisfy
AddressFormat.

Test plan:
Modify some patrons and fill the different address info
Search for them and notice that the city, zipcode and country are now
displayed.
Modify the value of AddressFormat and confirm that the display is
modified according to its value

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Roberts  changed:

   What|Removed |Added

   Assignee|david.roberts@ptfs-europe.c |koha-b...@lists.koha-commun
   |om  |ity.org

--- Comment #5 from David Roberts  ---
I think I'm going to have to unassign this one. I'm competent to extend the
functionality that is already in use, but not to change it completely,
especially on the basis of a rather cryptic suggestion. :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-03-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I think we should follow the same pattern we have already (in circ-menu.inc)
and use the member-display-address-style-* include files instead, to match the
AddressFormat syspref's value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-03-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Nind  changed:

   What|Removed |Added

 Attachment #102043|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 102064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102064&action=edit
Bug 22087: It would be helpful to have City and State visible in member.pl

This patch adds City, State and Zipcode to the display of a patron
search

To test:

1) Do a patron search that retrieves more than one user so you see the
results table
2) In the Names column, see that the patron address display without
city, state and zipcode.
3) Install the patch
4) Repeat the search. City, state and zipcode will now display in the
table.
5) Check that this is working from both member.pl and members-home.pl

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Roberts  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from David Roberts  ---
I've also added zipcode to this display, as there seemed little point in not
displaying it if we are displaying all of the other address fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

--- Comment #1 from David Roberts  ---
Created attachment 102043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102043&action=edit
Bug 22087: It would be helpful to have City and State visible in member.pl

This patch adds City, State and Zipcode to the display of a patron
search

To test:

1) Do a patron search that retrieves more than one user so you see the
results table
2) In the Names column, see that the patron address display without
city, state and zipcode.
3) Install the patch
4) Repeat the search. City, state and zipcode will now display in the
table.
5) Check that this is working from both member.pl and members-home.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2020-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

David Roberts  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |david.roberts@ptfs-europe.c
   |ity.org |om
 CC||david.roberts@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl

2019-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/