[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard changed: What|Removed |Added Summary|It would be helpful to have |Show city and state in |City and State visible in |patron search results |member.pl | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #32 from Katrin Fischer --- 1) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style.inc FAIL filters missing_filter at line 48 ([%~ IF ( patron.zipcode ) ~%][%~ patron.zipcode | html %] [% END ~%][%~ patron.city | html ~%][%~ IF ( patron.state ) ~%][% line_break %][%~ patron.state | html ~%][%~ END ~%]) missing_filter at line 49 ([%~ IF ( patron.country ) ~%][% line_break %][%~ patron.country | html ~%][%~ END ~%]) missing_filter at line 72 ([%~ IF ( patron.zipcode ) ~%][%~ patron.zipcode | html %] [% END ~%][%~ patron.city | html ~%][%~ IF ( patron.state ) ~%][% line_break %][%~ patron.state | html ~%][%~ END ~%]) missing_filter at line 73 ([%~ IF ( patron.country ) ~%][% line_break %][%~ patron.country | html ~%][%~ END ~%]) 2) I'd also like to suggest a visual change. At the moment the information is shown as a list, but I think as this is address information just a line break would work better. It will allow to just easily copy the addresses for use in a letter head or similar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Attachment #102483|0 |1 is obsolete|| --- Comment #34 from Jonathan Druart --- Created attachment 107421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107421&action=edit Bug 22087: Add space between zipcode and country -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Attachment #102482|0 |1 is obsolete|| --- Comment #33 from Jonathan Druart --- Created attachment 107420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107420&action=edit Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Attachment #102484|0 |1 is obsolete|| --- Comment #35 from Jonathan Druart --- Created attachment 107422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107422&action=edit Bug 22087: Add a no_line_break parameter to prevent new lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Attachment #102506|0 |1 is obsolete|| --- Comment #38 from Jonathan Druart --- Created attachment 107425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107425&action=edit Bug 22087: Move the email into the list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Attachment #102492|0 |1 is obsolete|| --- Comment #36 from Jonathan Druart --- Created attachment 107423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107423&action=edit Bug 22087: Prevent variable names colision We should not use PROCESS: http://www.template-toolkit.org/docs/manual/Directives.html " The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template. " The 'patron' variable is reused by patron-title.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Attachment #102505|0 |1 is obsolete|| --- Comment #37 from Jonathan Druart --- Created attachment 107424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107424&action=edit Bug 22087: Remove padding on li's -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #42 from Jonathan Druart --- Display is now: https://snipboard.io/MBu8cI.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #40 from Jonathan Druart --- Created attachment 107428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107428&action=edit Bug 22087: Display address on different line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #41 from Jonathan Druart --- (In reply to Katrin Fischer from comment #32) > 1) > FAIL > koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style.inc >FAIL filters > missing_filter at line 48 ([%~ IF ( patron.zipcode > ) ~%][%~ > patron.zipcode | html %] [% END ~%][%~ patron.city | html ~%][%~ IF ( > patron.state ) ~%][% line_break %][%~ patron.state | html ~%][%~ END ~%]) > missing_filter at line 49 ([%~ IF ( patron.country > ) ~%][% > line_break %][%~ patron.country | html ~%][%~ END ~%]) > missing_filter at line 72 ([%~ IF ( patron.zipcode > ) ~%][%~ > patron.zipcode | html %] [% END ~%][%~ patron.city | html ~%][%~ IF ( > patron.state ) ~%][% line_break %][%~ patron.state | html ~%][%~ END ~%]) > missing_filter at line 73 ([%~ IF ( patron.country > ) ~%][% > line_break %][%~ patron.country | html ~%][%~ END ~%]) Done. > 2) > I'd also like to suggest a visual change. At the moment the information is > shown as a list, but I think as this is address information just a line > break would work better. It will allow to just easily copy the addresses for > use in a letter head or similar. As I said in comment 27, "I wanted to keep the view as compact as before" I added a follow-up but I don't think it's the way to go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #39 from Jonathan Druart --- Created attachment 107427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107427&action=edit Bug 22087: Add missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #43 from Jonathan Druart --- vs without the last patch: https://snipboard.io/qEsVt4.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107420|0 |1 is obsolete|| Attachment #107428|0 |1 is obsolete|| --- Comment #44 from Katrin Fischer --- Created attachment 107543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107543&action=edit Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107423|0 |1 is obsolete|| --- Comment #47 from Katrin Fischer --- Created attachment 107546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107546&action=edit Bug 22087: Prevent variable names colision We should not use PROCESS: http://www.template-toolkit.org/docs/manual/Directives.html " The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template. " The 'patron' variable is reused by patron-title.inc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107422|0 |1 is obsolete|| --- Comment #46 from Katrin Fischer --- Created attachment 107545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107545&action=edit Bug 22087: Add a no_line_break parameter to prevent new lines Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107421|0 |1 is obsolete|| --- Comment #45 from Katrin Fischer --- Created attachment 107544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107544&action=edit Bug 22087: Add space between zipcode and country Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107424|0 |1 is obsolete|| --- Comment #48 from Katrin Fischer --- Created attachment 107547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107547&action=edit Bug 22087: Remove padding on li's Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107425|0 |1 is obsolete|| --- Comment #49 from Katrin Fischer --- Created attachment 107548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107548&action=edit Bug 22087: Move the email into the list Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107427|0 |1 is obsolete|| --- Comment #50 from Katrin Fischer --- Created attachment 107549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107549&action=edit Bug 22087: Add missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #51 from Katrin Fischer --- Hi Jonathan, you were right - the last patch was not needed. I had forgotten to do a yarn build before when testing :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #52 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #53 from Lucas Gass --- skipping enhancement for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
