[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Koha collecto changed: What|Removed |Added CC||k...@collecto.ca --- Comment #45 from Koha collecto --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #44 from Nick Clemens --- Hi all, I didn't see this and ended up working on 35646 - I think it meets the same basic need, but with a slightly different implementation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35646 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #43 from Alex Buckley --- Created attachment 158659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158659=edit Bug 22188: Add Koha::DateUtils for dt_from_string function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #42 from Alex Buckley --- Created attachment 158638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158638=edit Bug 22188: Bad rebase conflict fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #41 from Aleisha Amohia --- Created attachment 157179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157179=edit Bug 22188: Atomic update for pubdatepatternformat (cherry picked from commit 2277d729b9266c0f084b6489d52f0c4e230fe121) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #40 from Aleisha Amohia --- Created attachment 157015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157015=edit Bug 22188: Additional fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #156891|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #39 from Aleisha Amohia --- Just updated to pull the schema updates into their own patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #38 from Aleisha Amohia --- Created attachment 157014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157014=edit Bug 22188: Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #156890|0 |1 is obsolete|| --- Comment #37 from Aleisha Amohia --- Created attachment 157013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157013=edit Bug 22188: updating kohastructure.sql to include creation of pubdatepatternformat field Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #156889|0 |1 is obsolete|| --- Comment #36 from Aleisha Amohia --- Created attachment 157012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157012=edit Bug 22188: (follow-up) Ensuring publication date numbering patterns shows when receiving serials This follow-up addresses the issue in Comment 21. To test: 1) Save a subscription with a regular number pattern and receive a few issues 2) Edit the subscription to use publication date and save 3) Receive an issue 4) Notice the issue number under the 'Numbered' column has not updated to reflect the publication date number pattern 5) Apply patch and refresh page 6) The issue number in the 'Numbered' column should now use the publication date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #156888|0 |1 is obsolete|| --- Comment #35 from Aleisha Amohia --- Created attachment 157011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157011=edit Bug 22188: Tests This patch fixes the t/db_dependent/Serials.t test which fails with this feature (without this fix). Ensure all other tests that use NewSubscription, ModSubscription, GetNextSeq, GetSeq still pass. db_dependent/Acquisition/OrderFromSubscription.t db_dependent/Bookseller.t db_dependent/Koha/Acquisition/Booksellers.t db_dependent/Letters.t db_dependent/Serials.t db_dependent/Serials/Claims.t db_dependent/Serials/ReNewSubscription.t db_dependent/Serials_2.t db_dependent/Serials/Frequency.t db_dependent/Serials/Numberpattern.t db_dependent/Serials/GetNextSeq.t Serials/GetNextSeq.t This patch also adds tests to db_dependent/Serials_2.t so check these tests pass prove -v t/db_dependent/Serials_2.t Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #156887|0 |1 is obsolete|| --- Comment #34 from Aleisha Amohia --- Created attachment 157010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157010=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #156886|0 |1 is obsolete|| --- Comment #33 from Aleisha Amohia --- Created attachment 157009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157009=edit Bug 22188: Use publication date as numbering pattern Brimbank were trying to make a numbering pattern that displays the publication date, but numbering patterns are calculated mathematically, and dates are not always consistent and don't work that way. I've written a feature that hardcodes an option to use the publication date instead of a numbering pattern, in a 'Y M D' format. To test: 1) Go to Serials 2) Click New subscription 3) Fill in the necessary details for the first page and click Next 4) Fill in the necessary details for the second page. Under numbering pattern, select Number. 5) Notice the advanced pattern table shows. Put some random data in these fields 6) Change numbering pattern to Use publication date. Confirm that selecting this option hides the advanced pattern table and clears its fields. 7) Click Test prediction pattern and confirm the prediction pattern shows as expected 8) Save subscription 9) You should now be on the subscription detail page for your new subscription. Go to the Planning tab and confirm that it says 'uses publication date' under Number pattern and that there is now table saying 'Starting with' and 'Rollover' 10) Go to the Issues tab and confirm the first serial is there with the correct issue number (publication date). 11) Click the Receive button 12) Confirm the publication date shows under the Numbered column, in the Issue text field and click Save 13) Click the Generate next button and confirm the alert box 14) Confirm the publication date shows under 'Number' 15) Find/make a subscription that uses a normal numbering pattern 16) Edit this subscription to now use the publication date as numbering pattern 17) Upon saving, confirm that previously received serials keep their old issue numbers 18) Click Receive and Generate next again and confirm that the next serial now has the publication date 19) Confirm that making a subscription with a normal numbering pattern works as expected. Upon saving, the table should show under the Planning tab with 'Starting with' and 'Rollover' and all other fields should be filled correctly. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Danyon Sewell changed: What|Removed |Added CC||danyonsew...@catalyst.net.n ||z --- Comment #32 from Danyon Sewell --- Have updated a few files attempting to rebase this for most recent version. I haven't finished just yet but thought I should share what I have done so far. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #31 from Danyon Sewell --- Created attachment 156891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156891=edit Bug 22188: updated Subscription.pm for database update Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #30 from Danyon Sewell --- Created attachment 156890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156890=edit Bug 22188: updating kohastructure.sql to include creation of pubdatepatternformat field Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Danyon Sewell changed: What|Removed |Added Attachment #92364|0 |1 is obsolete|| --- Comment #29 from Danyon Sewell --- Created attachment 156889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156889=edit Bug 22188: (follow-up) Ensuring publication date numbering patterns shows when receiving serials This follow-up addresses the issue in Comment 21. To test: 1) Save a subscription with a regular number pattern and receive a few issues 2) Edit the subscription to use publication date and save 3) Receive an issue 4) Notice the issue number under the 'Numbered' column has not updated to reflect the publication date number pattern 5) Apply patch and refresh page 6) The issue number in the 'Numbered' column should now use the publication date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Danyon Sewell changed: What|Removed |Added Attachment #92345|0 |1 is obsolete|| --- Comment #28 from Danyon Sewell --- Created attachment 156888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156888=edit Bug 22188: Tests This patch fixes the t/db_dependent/Serials.t test which fails with this feature (without this fix). Ensure all other tests that use NewSubscription, ModSubscription, GetNextSeq, GetSeq still pass. db_dependent/Acquisition/OrderFromSubscription.t db_dependent/Bookseller.t db_dependent/Koha/Acquisition/Booksellers.t db_dependent/Letters.t db_dependent/Serials.t db_dependent/Serials/Claims.t db_dependent/Serials/ReNewSubscription.t db_dependent/Serials_2.t db_dependent/Serials/Frequency.t db_dependent/Serials/Numberpattern.t db_dependent/Serials/GetNextSeq.t Serials/GetNextSeq.t This patch also adds tests to db_dependent/Serials_2.t so check these tests pass prove -v t/db_dependent/Serials_2.t Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Danyon Sewell changed: What|Removed |Added Attachment #92185|0 |1 is obsolete|| --- Comment #27 from Danyon Sewell --- Created attachment 156887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156887=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Danyon Sewell changed: What|Removed |Added Attachment #91761|0 |1 is obsolete|| --- Comment #26 from Danyon Sewell --- Created attachment 156886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156886=edit Bug 22188: Use publication date as numbering pattern Brimbank were trying to make a numbering pattern that displays the publication date, but numbering patterns are calculated mathematically, and dates are not always consistent and don't work that way. I've written a feature that hardcodes an option to use the publication date instead of a numbering pattern, in a 'Y M D' format. To test: 1) Go to Serials 2) Click New subscription 3) Fill in the necessary details for the first page and click Next 4) Fill in the necessary details for the second page. Under numbering pattern, select Number. 5) Notice the advanced pattern table shows. Put some random data in these fields 6) Change numbering pattern to Use publication date. Confirm that selecting this option hides the advanced pattern table and clears its fields. 7) Click Test prediction pattern and confirm the prediction pattern shows as expected 8) Save subscription 9) You should now be on the subscription detail page for your new subscription. Go to the Planning tab and confirm that it says 'uses publication date' under Number pattern and that there is now table saying 'Starting with' and 'Rollover' 10) Go to the Issues tab and confirm the first serial is there with the correct issue number (publication date). 11) Click the Receive button 12) Confirm the publication date shows under the Numbered column, in the Issue text field and click Save 13) Click the Generate next button and confirm the alert box 14) Confirm the publication date shows under 'Number' 15) Find/make a subscription that uses a normal numbering pattern 16) Edit this subscription to now use the publication date as numbering pattern 17) Upon saving, confirm that previously received serials keep their old issue numbers 18) Click Receive and Generate next again and confirm that the next serial now has the publication date 19) Confirm that making a subscription with a normal numbering pattern works as expected. Upon saving, the table should show under the Planning tab with 'Starting with' and 'Rollover' and all other fields should be filled correctly. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Sue changed: What|Removed |Added CC||martino...@morainevalley.ed ||u, y...@morainevalley.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 94291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94291=edit error when generating next issue I receive the attached error when trying to generate the next issue of a subscription using date as numbering pattern. I do not receive this error when trying to generate next on a subscription using the Number numbering pattern. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #24 from Andrew Fuerste-Henry --- Created attachment 94290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94290=edit display error on subscription See attached for display errors on the subscription page. Data is displayed twice, along with what looks like some comments from the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #23 from Aleisha Amohia --- Created attachment 92364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92364=edit Bug 22188: (follow-up) Ensuring publication date numbering patterns shows when receiving serials This follow-up addresses the issue in Comment 21. To test: 1) Save a subscription with a regular number pattern and receive a few issues 2) Edit the subscription to use publication date and save 3) Receive an issue 4) Notice the issue number under the 'Numbered' column has not updated to reflect the publication date number pattern 5) Apply patch and refresh page 6) The issue number in the 'Numbered' column should now use the publication date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #92186|0 |1 is obsolete|| --- Comment #22 from Aleisha Amohia --- Created attachment 92345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92345=edit Bug 22188: Tests This patch fixes the t/db_dependent/Serials.t test which fails with this feature (without this fix). Ensure all other tests that use NewSubscription, ModSubscription, GetNextSeq, GetSeq still pass. db_dependent/Acquisition/OrderFromSubscription.t db_dependent/Bookseller.t db_dependent/Koha/Acquisition/Booksellers.t db_dependent/Letters.t db_dependent/Serials.t db_dependent/Serials/Claims.t db_dependent/Serials/ReNewSubscription.t db_dependent/Serials_2.t db_dependent/Serials/Frequency.t db_dependent/Serials/Numberpattern.t db_dependent/Serials/GetNextSeq.t Serials/GetNextSeq.t This patch also adds tests to db_dependent/Serials_2.t so check these tests pass prove -v t/db_dependent/Serials_2.t Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Andrew changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #21 from Andrew --- I'm failing on step 18 of the test plan. I created a new subscription using a Number pattern, received several issues, edited the subscription to use Pub Date instead, saved it. But when I either Generate Next Issue or receive the issue that's already expected the subscription reverts to Number pattern. That said, this is a really great feature! Thanks for writing it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #20 from Aleisha Amohia --- Created attachment 92186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92186=edit Bug 22188: Tests This patch fixes the t/db_dependent/Serials.t test which fails with this feature (without this fix). Ensure all other tests that use NewSubscription, ModSubscription, GetNextSeq, GetSeq still pass. db_dependent/Acquisition/OrderFromSubscription.t db_dependent/Bookseller.t db_dependent/Koha/Acquisition/Booksellers.t db_dependent/Letters.t db_dependent/Serials.t db_dependent/Serials/Claims.t db_dependent/Serials/ReNewSubscription.t db_dependent/Serials_2.t db_dependent/Serials/Frequency.t db_dependent/Serials/Numberpattern.t db_dependent/Serials/GetNextSeq.t Serials/GetNextSeq.t Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #91762|0 |1 is obsolete|| --- Comment #19 from Aleisha Amohia --- Created attachment 92185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92185=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #18 from Michal Denar --- Hi Aleisha, I'm not able to set any dates in form for subscription.From caledar I get error about format, manually I can't add "/" delimiter. Video maybe help: https://recordit.co/0IrAibfJUJ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #17 from Aleisha Amohia --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #88830|0 |1 is obsolete|| --- Comment #16 from Aleisha Amohia --- Created attachment 91762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91762=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #85415|0 |1 is obsolete|| --- Comment #15 from Aleisha Amohia --- Created attachment 91761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91761=edit Bug 22188: Use publication date as numbering pattern Brimbank were trying to make a numbering pattern that displays the publication date, but numbering patterns are calculated mathematically, and dates are not always consistent and don't work that way. I've written a feature that hardcodes an option to use the publication date instead of a numbering pattern, in a 'Y M D' format. To test: 1) Go to Serials 2) Click New subscription 3) Fill in the necessary details for the first page and click Next 4) Fill in the necessary details for the second page. Under numbering pattern, select Number. 5) Notice the advanced pattern table shows. Put some random data in these fields 6) Change numbering pattern to Use publication date. Confirm that selecting this option hides the advanced pattern table and clears its fields. 7) Click Test prediction pattern and confirm the prediction pattern shows as expected 8) Save subscription 9) You should now be on the subscription detail page for your new subscription. Go to the Planning tab and confirm that it says 'uses publication date' under Number pattern and that there is now table saying 'Starting with' and 'Rollover' 10) Go to the Issues tab and confirm the first serial is there with the correct issue number (publication date). 11) Click the Receive button 12) Confirm the publication date shows under the Numbered column, in the Issue text field and click Save 13) Click the Generate next button and confirm the alert box 14) Confirm the publication date shows under 'Number' 15) Find/make a subscription that uses a normal numbering pattern 16) Edit this subscription to now use the publication date as numbering pattern 17) Upon saving, confirm that previously received serials keep their old issue numbers 18) Click Receive and Generate next again and confirm that the next serial now has the publication date 19) Confirm that making a subscription with a normal numbering pattern works as expected. Upon saving, the table should show under the Planning tab with 'Starting with' and 'Rollover' and all other fields should be filled correctly. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Maryse Simard --- Patch doesn't apply Applying: Bug 22188: Use publication date as numbering pattern Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt M koha-tmpl/intranet-tmpl/prog/js/subscription-add.js M serials/serials-collection.pl M serials/showpredictionpattern.pl M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl Auto-merging serials/showpredictionpattern.pl Auto-merging serials/serials-collection.pl Auto-merging koha-tmpl/intranet-tmpl/prog/js/subscription-add.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging C4/Serials.pm Applying: Bug 22188: (follow-up) Introducing dateformat field and other fixes fatal: sha1 information is lacking or useless (C4/Serials.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22188: (follow-up) Introducing dateformat field and other fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #87433|0 |1 is obsolete|| --- Comment #13 from Aleisha Amohia --- Created attachment 88830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88830=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Séverine Queune --- Sorry Aleisha... The sandbox you've requested is not ready. Some problems occurred applying patches from bug 22188: Something went wrong !Applying: Bug 22188: Use publication date as numbering pattern Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt M koha-tmpl/intranet-tmpl/prog/js/subscription-add.js M serials/showpredictionpattern.pl M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl Auto-merging serials/showpredictionpattern.pl Auto-merging koha-tmpl/intranet-tmpl/prog/js/subscription-add.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging C4/Serials.pm Warning: commit message did not conform to UTF-8. You may want to amend it after fixing the message, or set the config variable i18n.commitencoding to the encoding your project uses. Applying: Bug 22188: (follow-up) Introducing dateformat field and other fixes fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt). Patch failed at 0001 Bug 22188: (follow-up) Introducing dateformat field and other fixes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. error: could not build fake ancestor Bug 22188 - Use publication date as numbering pattern 85415 - Bug 22188: Use publication date as numbering pattern 87433 - Bug 22188: (follow-up) Introducing dateformat field and other fixes Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-22188-follow-up-Introducing-dateformat-field-a-vPc2wv.patch . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #86419|0 |1 is obsolete|| --- Comment #11 from Aleisha Amohia --- Created attachment 87433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87433=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #10 from Aleisha Amohia --- (In reply to Séverine Queune from comment #5) > > 9) You should now be on the subscription detail page for your new > > subscription. Go to the Planning tab and confirm that it says 'uses > > publication date' under Number pattern and that there is now table > > saying 'Starting with' and 'Rollover' > > Ok for 'Number pattern: Uses publication date', but I don't see the table. > Sorry I forgot to fix my test plan - this table does not show if using publication date pattern. It will show for all other number patterns. This should be ready to test again now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #9 from Aleisha Amohia --- Created attachment 86419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86419=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #8 from Séverine Queune --- Created attachment 85542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85542=edit Screenshot 3 - Numbering pattern cleared -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #7 from Séverine Queune --- Created attachment 85541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85541=edit Sceenshot 2 - Problem on step 18 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #6 from Séverine Queune --- Created attachment 85540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85540=edit Sceenshot 1 - Problem on step 13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
Status|Needs Signoff |Failed QA
--- Comment #5 from Séverine Queune ---
Hi Aleisha,
This is a useful enhancement, but I have some questions and issues.
> 7) Click Test prediction pattern and confirm the prediction pattern shows as
> expected
The issue number is formatted as ' Month DD', is there a way to modify it
using the advanced pattern ? I failed trying it.
> 9) You should now be on the subscription detail page for your new
> subscription. Go to the Planning tab and confirm that it says 'uses
> publication date' under Number pattern and that there is now table
> saying 'Starting with' and 'Rollover'
Ok for 'Number pattern: Uses publication date', but I don't see the table.
> 12) Confirm the publication date shows under the Numbered column, in the
> Issue text field and click Save
Ok for display, but each time I tried to save the receive, I get this Software
error :
Can't use string ("1") as a HASH ref while "strict refs" in use at
/home/koha/src/C4/Serials.pm line 2353.
This message also occurs for 1) receipt of serial that uses other numbering
patterns, 2) for multi-receiving and 3) when generating a new issue if the last
one in still 'Expected'.
When I go back to /cgi-bin/koha/serials/serials-collection.pl, in case 1)
serial is corectly received, case 2) only one issue is received (I wanted to
receive 3) and in case 3) issue is correctly set tot 'late' and the next is
'Expected'.
[Sorry if this bug is not due to this patch]
> 13) Click the Generate next button and confirm the alert box
I created several subscriptions and I always have the same problem : when I
generate the next issue, the number format changes from ' Month DD' to
'-MM-DD', and the date of the previous issue is used, which creates a gap
in the number pattern (see screenshot attached)
> 16) Edit this subscription to now use the publication date as numbering
> pattern
ok
> 17) Upon saving, confirm that previously received serials keep their old
> issue numbers
ok
> 18) Click Receive and Generate next again and confirm that the next
> serial now has the publication date
Badaboum... Same problem as step 13 : the date of the previous issue is used as
number (see the second screenshot attached)
I didn't see this step on your plan test, but when I edit a subscription using
'Use publication date', the 'Numbering pattern' is cleared (see the last
screenshot attached).
I hope my comments are clear enough...
Very interested to see this one pushed soon !
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #4 from Aleisha Amohia --- Rebased, please test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #84314|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 85415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85415=edit Bug 22188: Use publication date as numbering pattern Brimbank were trying to make a numbering pattern that displays the publication date, but numbering patterns are calculated mathematically, and dates are not always consistent and don't work that way. I've written a feature that hardcodes an option to use the publication date instead of a numbering pattern, in a 'Y M D' format. To test: 1) Go to Serials 2) Click New subscription 3) Fill in the necessary details for the first page and click Next 4) Fill in the necessary details for the second page. Under numbering pattern, select Number. 5) Notice the advanced pattern table shows. Put some random data in these fields 6) Change numbering pattern to Use publication date. Confirm that selecting this option hides the advanced pattern table and clears its fields. 7) Click Test prediction pattern and confirm the prediction pattern shows as expected 8) Save subscription 9) You should now be on the subscription detail page for your new subscription. Go to the Planning tab and confirm that it says 'uses publication date' under Number pattern and that there is now table saying 'Starting with' and 'Rollover' 10) Go to the Issues tab and confirm the first serial is there with the correct issue number (publication date). 11) Click the Receive button 12) Confirm the publication date shows under the Numbered column, in the Issue text field and click Save 13) Click the Generate next button and confirm the alert box 14) Confirm the publication date shows under 'Number' 15) Find/make a subscription that uses a normal numbering pattern 16) Edit this subscription to now use the publication date as numbering pattern 17) Upon saving, confirm that previously received serials keep their old issue numbers 18) Click Receive and Generate next again and confirm that the next serial now has the publication date 19) Confirm that making a subscription with a normal numbering pattern works as expected. Upon saving, the table should show under the Planning tab with 'Starting with' and 'Rollover' and all other fields should be filled correctly. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||pierre-marc.thibault@inlibr ||o.com --- Comment #2 from Pierre-Marc Thibault --- The patch does not apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #1 from Aleisha Amohia --- Created attachment 84314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84314=edit Bug 22188: Use publication date as numbering pattern Brimbank were trying to make a numbering pattern that displays the publication date, but numbering patterns are calculated mathematically, and dates are not always consistent and don't work that way. I've written a feature that hardcodes an option to use the publication date instead of a numbering pattern, in a 'Y M D' format. To test: 1) Go to Serials 2) Click New subscription 3) Fill in the necessary details for the first page and click Next 4) Fill in the necessary details for the second page. Under numbering pattern, select Number. 5) Notice the advanced pattern table shows. Put some random data in these fields 6) Change numbering pattern to Use publication date. Confirm that selecting this option hides the advanced pattern table and clears its fields. 7) Click Test prediction pattern and confirm the prediction pattern shows as expected 8) Save subscription 9) You should now be on the subscription detail page for your new subscription. Go to the Planning tab and confirm that it says 'uses publication date' under Number pattern and that there is now table saying 'Starting with' and 'Rollover' 10) Go to the Issues tab and confirm the first serial is there with the correct issue number (publication date). 11) Click the Receive button 12) Confirm the publication date shows under the Numbered column, in the Issue text field and click Save 13) Click the Generate next button and confirm the alert box 14) Confirm the publication date shows under 'Number' 15) Find/make a subscription that uses a normal numbering pattern 16) Edit this subscription to now use the publication date as numbering pattern 17) Upon saving, confirm that previously received serials keep their old issue numbers 18) Click Receive and Generate next again and confirm that the next serial now has the publication date 19) Confirm that making a subscription with a normal numbering pattern works as expected. Upon saving, the table should show under the Planning tab with 'Starting with' and 'Rollover' and all other fields should be filled correctly. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
