[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer --- I really like this and always happy to have new contribs, but I am worried about something in the behaviour of this plugin. I've also tried linking it to 050$a. When I import a record with a 050$a set already or open a record that already has it and click into the field or tab through the fields, the plugin is immediately triggered, killing the original value. I think we need this to trigger only 'on demand' or when the field is empty to avoid unintentional data loss. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #18 from David Nind --- I'm not a cataloguer, and don't understand all the nuances here, so it may pay for someone familiar with this to review as well. Testing notes: - Followed the test plan - Added the cutter plugin to 050$a (most likely this isn't technically correct, but it shows the code being generated by cutter.pl) - Used koha-testing-docker and the sample data, tested with a couple of records - Programming Perl / Tom Christiansen, Brian D. Foy & Larry Wall. (Record number 262) . classification code generated: C555p (C = first letter of author; 555 = from table in source code from surname; p = first letter of the title) . changed indicator 2 for 245 to 4: code generated = C555r (next character in the title after 4 characters, that is, the 5th character) - Perl Better Practices (Record number 191): . added corporate author to 110$a (1151 Academia Sinica, Nanking. Inst. of Soil Science) . classification code generated: A168p (A = first letter of author; 168 = from table in source code for aca; p = first letter of the title) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 David Nind changed: What|Removed |Added Attachment #119796|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 119978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119978=edit Bug 22371: Add MARC21 cataloguing plugin to generate Cutter-Sanborn To associate the plugin with the cutter field, you must set the 'cutter.pl' plugin in your MARC framework. this can be done through the following steps: 1. Navigate to More > Administration > MARC bibliographic framework; 2. On the framework which you want to use de plugin, click on Action > MARC Structure; 3. On the field to be associated with the plugin, click on Actions > Subfields; 4. Select the tab corresponding to the cutter subfield; 5. On the "Other options (choose one)" panel, select "cutter.pl" in "Plugin" dropdown menu, and save changes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #16 from David Nind --- (In reply to Katrin Fischer from comment #15) > I've turned this into a patch file, but haven't tested it. Please try it out! Thanks Katrin! The patch applies, and I will have a go at testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #15 from Katrin Fischer --- I've turned this into a patch file, but haven't tested it. Please try it out! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #14 from Katrin Fischer --- Created attachment 119796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119796=edit Bug 22371: Add MARC21 cataloguing plugin to generate Cutter-Sanborn To associate the plugin with the cutter field, you must set the 'cutter.pl' plugin in your MARC framework. this can be done through the following steps: 1. Navigate to More > Administration > MARC bibliographic framework; 2. On the framework which you want to use de plugin, click on Action > MARC Structure; 3. On the field to be associated with the plugin, click on Actions > Subfields; 4. Select the tab corresponding to the cutter subfield; 5. On the "Other options (choose one)" panel, select "cutter.pl" in "Plugin" dropdown menu, and save changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |In Discussion --- Comment #13 from David Nind --- Hi Ítalo. As this patch is not formatted the "normal" way, then the development environments we use don't work - so I'm not able to test and sign off the usual way. See the Developer Handbook, https://wiki.koha-community.org/wiki/Developer_handbook and look for : - the Development workflow (https://wiki.koha-community.org/wiki/Development_workflow) - submitting a patch https://wiki.koha-community.org/wiki/Submitting_A_Patch - commit messages https://wiki.koha-community.org/wiki/Commit_messages There is a bit of a hurdle to get these things in! Feel free to ask for help on how to do this on the bug, Development email list, or IRC (there are times where there are more people around to help - day time European and US time zones are probably better, it is normally very quiet over the weekend). I'm not a developer, so I don't think I will be much help in getting your patch formatted and attached to Bugzilla the right way... I'm also not sure whether the variable names need to be English (as per comment #11 and #12) - something some of the developers will be able to answer. I've changed status to In Discussion in the meantime until it is ready for sign off. David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #12 from Bernardo Gonzalez Kriegel --- (In reply to Devinim from comment #11) > Hi, > > There are many Italian variables in code Not Italian, Portuguese :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Devinim changed: What|Removed |Added CC||kohadevi...@devinim.com.tr --- Comment #11 from Devinim --- Hi, There are many Italian variables in code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|koha-b...@lists.koha-commun |italo.barbosa.brasileiro@gm |ity.org |ail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371
--- Comment #10 from paxed ---
(In reply to Ítalo from comment #9)
> (In reply to paxed from comment #4)
> > Should also perhaps use String.prototype.normalize() if it's available
>
> Paxed, the new attachment ('Updated plugin code, using
> String.prototype.normalize()') was done with normalize().
> Thanks for the suggestion!
You probably shouldn't split the string into character array (and then join it
later), but use the normalize directly on the string and remove the combining
diacritics (eg. with a regular expression).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371
--- Comment #9 from Ítalo ---
(In reply to paxed from comment #4)
> Should also perhaps use String.prototype.normalize() if it's available
Paxed, the new attachment ('Updated plugin code, using
String.prototype.normalize()') was done with normalize().
Thanks for the suggestion!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Ítalo changed: What|Removed |Added Attachment #85466|0 |1 is obsolete|| Attachment #86277|0 |1 is obsolete|| --- Comment #8 from Ítalo --- Created attachment 86304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86304=edit Updated plugin code, using String.prototype.normalize() -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #7 from Ítalo --- (In reply to paxed from comment #3) > Any chance of converting the comments in the plugin to english? Paxed, I inserted a new attachment named 'Plugin with comments in english'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #6 from Ítalo --- Created attachment 86277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86277=edit Plugin with comments in english -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #5 from Ítalo --- (In reply to Cori Lynn Arnold from comment #2) > I'm trying to test this functionality. Can you explain this step in more > detail: > > To use the plugin, it is necessary to associate it with the Cutter field in > the framework. > > Thanks! > -cori lynn Hello Cori! To associate the plugin with the cutter field, you must set the 'cutter.pl' plugin in your MARC framework. this can be done through the following steps: 1. Navigate to More > Administration > MARC bibliographic framework; 2. On the framework which you want to use de plugin, click on Action > MARC Structure; 3. On the field to be associated with the plugin, click on Actions > Subfields; 4. Select the tab corresponding to the cutter subfield; 5. On the "Other options (choose one)" panel, select "cutter.pl" in "Plugin" dropdown menu, and save changes. Hope it works! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #4 from paxed --- Should also perhaps use String.prototype.normalize() if it's available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 paxed changed: What|Removed |Added CC||pasi.kalli...@koha-suomi.fi --- Comment #3 from paxed --- Any chance of converting the comments in the plugin to english? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Cori Lynn Arnold changed: What|Removed |Added CC||carn...@dgiinc.com --- Comment #2 from Cori Lynn Arnold --- I'm trying to test this functionality. Can you explain this step in more detail: To use the plugin, it is necessary to associate it with the Cutter field in the framework. Thanks! -cori lynn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Ítalo changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Ítalo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #1 from Ítalo --- Created attachment 85466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85466=edit First implementation of cutter generator -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Ítalo changed: What|Removed |Added CC||italo.barbosa.brasileiro@gm ||ail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
