[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #9 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Nick Clemens changed: What|Removed |Added Attachment #112259|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 112361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112361&action=edit Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Joonas Kylmälä changed: What|Removed |Added Attachment #111991|0 |1 is obsolete|| --- Comment #6 from Joonas Kylmälä --- Created attachment 112259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112259&action=edit Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Katrin Fischer changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added Attachment #108588|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 111991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111991&action=edit Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind --- Patch no longer applies 8-( Notes for testing: - Find usage of manualinvoice: git grep manualinvoice - Search before applying patch - After apply patch should be no occurrences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 --- Comment #3 from Martin Renvoize --- Created attachment 108588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108588&action=edit Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 --- Comment #2 from Martin Renvoize --- This was a nice example of the use of the deprecated method from Mojo::Utils to give warning of a method being removed prior to it's actual removal.. I wonder.. did people find this helpful and should we adopt the practice more widely? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 --- Comment #1 from Martin Renvoize --- We have been warning via a deprecation warning since the release of 19.05.00.. with the release of 20.11 it will make 18 months of the warning having been fired so I think we're safe to remove it now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added Blocks||22510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Martin Renvoize changed: What|Removed |Added Blocks||14825 Depends on||22393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
