[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Nick Clemens changed: What|Removed |Added Blocks||26086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26086 [Bug 26086] Add a 'cron' interface limit to the log viewer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Nick Clemens changed: What|Removed |Added Blocks||25845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 [Bug 25845] Cannot limit system logs to 'api' interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Nick Clemens changed: What|Removed |Added Blocks||24377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 [Bug 24377] Record branch in statistics for auto-renewal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23193 [Bug 23193] Make set_password.pl use Koha::Script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20256 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17168 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22577 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What|Removed |Added Blocks||22755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 [Bug 22755] Import Koha::Script to patron_emailer cronjob -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00 released in|| Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #29 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Bug 22600 depends on bug 22512, which changed state. Bug 22512 Summary: accountlines.accountype mixes 'state' and 'type' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #28 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #27 from Martin Renvoize --- Thanks for the follow-up, looks good to me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 87614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87614&action=edit Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 87616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87616&action=edit Bug 22600: (QA follow-up) Raise an exception on missing interface param This patch makes add_credit and add_debit raise a Koha::Exceptions::MissingParameter exception if the 'interface' parameter is ommited. The database will fail to generate the line anyways in strict mode, and we better handle it gracefuly. Bonus: fixed the TODOs in the tests. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 87611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87611&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 87615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87615&action=edit Bug 22600: Update Tests adding 'interface' as needed Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 87613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87613&action=edit Bug 22600: Add 'cron' to interface types and set appropriately This patch adds 'cron' as a valid interface and sets it appropriately for existing cron scripts. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 87612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87612&action=edit Bug 22600: Add 'api' to interface types and set appropriately This patch adds 'api' as a valid interface and sets it appropriately for both the new REST api and previous /svc/ api's. Handling to keep the interface of a logged in session is included such that if the OPAC or Intranet use the API's internally via a Cookie we will maintain the interface throughout the session. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tomás Cohen Arazi changed: What|Removed |Added Attachment #87519|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tomás Cohen Arazi changed: What|Removed |Added Attachment #87518|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tomás Cohen Arazi changed: What|Removed |Added Attachment #87517|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tomás Cohen Arazi changed: What|Removed |Added Attachment #87516|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tomás Cohen Arazi changed: What|Removed |Added Attachment #87515|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18205 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #18 from Josef Moravec --- Created attachment 87517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87517&action=edit Bug 22600: Add 'cron' to interface types and set appropriately This patch adds 'cron' as a valid interface and sets it appropriately for existing cron scripts. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #19 from Josef Moravec --- Created attachment 87518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87518&action=edit Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #20 from Josef Moravec --- Created attachment 87519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87519&action=edit Bug 22600: Update Tests adding 'interface' as needed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What|Removed |Added Attachment #87189|0 |1 is obsolete|| Attachment #87190|0 |1 is obsolete|| Attachment #87191|0 |1 is obsolete|| Attachment #87192|0 |1 is obsolete|| Attachment #87193|0 |1 is obsolete|| --- Comment #16 from Josef Moravec --- Created attachment 87515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87515&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #17 from Josef Moravec --- Created attachment 87516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87516&action=edit Bug 22600: Add 'api' to interface types and set appropriately This patch adds 'api' as a valid interface and sets it appropriately for both the new REST api and previous /svc/ api's. Handling to keep the interface of a logged in session is included such that if the OPAC or Intranet use the API's internally via a Cookie we will maintain the interface throughout the session. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Priority|P5 - low|P2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Blocks|22564 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Blocks||22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #15 from Martin Renvoize --- Hopefully that most recent patchset should address the test failure and your other comments.. back to NSO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Attachment #87140|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 87192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87192&action=edit Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Attachment #87137|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 87189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87189&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Attachment #87138|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 87190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87190&action=edit Bug 22600: Add 'api' to interface types and set appropriately This patch adds 'api' as a valid interface and sets it appropriately for both the new REST api and previous /svc/ api's. Handling to keep the interface of a logged in session is included such that if the OPAC or Intranet use the API's internally via a Cookie we will maintain the interface throughout the session. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #14 from Martin Renvoize --- Created attachment 87193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87193&action=edit Bug 22600: Update Tests adding 'interface' as needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Attachment #87139|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 87191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87191&action=edit Bug 22600: Add 'cron' to interface types and set appropriately This patch adds 'cron' as a valid interface and sets it appropriately for existing cron scripts. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Blocks||22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||k...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #9 from Martin Renvoize --- Created attachment 87140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87140&action=edit Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #8 from Josef Moravec --- Just started testing, but found: prove t/db_dependent/Koha/Account.t Field 'interface' doesn't have a default value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Blocks||22603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603 [Bug 22603] Move boilerplate into Koha::Cron class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #7 from Martin Renvoize --- Created attachment 87139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87139&action=edit Bug 22600: Add 'cron' to interface types and set appropriately This patch adds 'cron' as a valid interface and sets it appropriately for existing cron scripts. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Attachment #87133|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 87137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87137&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Attachment #87134|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 87138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87138&action=edit Bug 22600: Add 'api' to interface types and set appropriately This patch adds 'api' as a valid interface and sets it appropriately for both the new REST api and previous /svc/ api's. Handling to keep the interface of a logged in session is included such that if the OPAC or Intranet use the API's internally via a Cookie we will maintain the interface throughout the session. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Attachment #87132|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 87133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87133&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #4 from Martin Renvoize --- Created attachment 87134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87134&action=edit Bug 22600: Add 'api' to interface types and set appropriately This patch adds 'api' as a valid interface and sets it appropriately for both the new REST api and previous /svc/ api's. Handling to keep the interface of a logged in session is included such that if the OPAC or Intranet use the API's internally via a Cookie we will maintain the interface throughout the session. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600
--- Comment #2 from Josef Moravec ---
Comment on attachment 87132
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87132
Bug 22600: Add 'interface' to accountlines
Review of attachment 87132:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22600&attachment=87132)
-
::: C4/Overdues.pm
@@ +599,5 @@
> description => $desc,
> note=> undef,
> user_id => undef,
> +interface => C4::Context->interface,
> +library_id => undef, #FIXME: Should we grab the
> checkout or circ-control branch here perhaps?
On the first view, I think if the Context is set then we should grab it from
context, if not, stay with undef
::: C4/SIP/ILS/Transaction/FeePayment.pm
@@ +28,4 @@
> our $debug = 0;
>
> my %fields = ();
> +C4::Context->interface('opac');
Should be 'SIP' I think
::: installer/data/mysql/atomicupdate/bug_22600.perl
@@ +2,5 @@
> +
> +$DBversion = 'XXX';# will be replaced by the RM
> +if ( CheckVersion($DBversion) ) {
> +
> +if ( !column_exists( 'accountlines', 'status' ) ) {
should be 'interface' instead of 'status'
@@ +7,5 @@
> +$dbh->do(
> +qq{
> +ALTER TABLE `accountlines`
> +ADD
> + `interface` varchar(16) DEFAULT 'script'
'script' default is weird here
@@ +35,5 @@
> + manager_id != borrowernumber;
> +});
> +
> +SetVersion($DBversion);
> +print "Upgrade to $DBversion done (Bug 22518 - Fix accounttype 'O' to
> 'FU')\n";
Not right description I think ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #1 from Martin Renvoize --- Created attachment 87132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87132&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Depends on|22008 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Depends on||22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Depends on||22008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
