[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 David Cook changed: What|Removed |Added Blocks||37466 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37466 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37466 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Jonathan Druart changed: What|Removed |Added Blocks||35785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35785 [Bug 35785] Edit search add quotes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED CC||caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |FIXED --- Comment #56 from Caroline Cyr La Rose --- Already in the manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33376 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #55 from David Cook --- The way this edit search handles limits is confusing in the UI... but maybe good enough... I should've upstreamed my local edit search years ago -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Blocks||32301 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 [Bug 32301] Show correct defaultSortField in staff interface advanced search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||32100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100 [Bug 32100] "edit search" feature quote-wraps search terms if original search had no results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Blocks||31271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 [Bug 31271] "Edit search" always resets search options to keyword -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #54 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Arthur Suzuki changed: What|Removed |Added Version(s)|22.05.00|22.05.00,21.11 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=1091 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Fridolin Somers changed: What|Removed |Added Blocks||31076 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 [Bug 31076] Bug 22605 breaks date of publication range search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Owen Leonard changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #53 from Fridolin Somers --- 2 unit tests are failing because of changes in C4::Search https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/560/ Fixed on master with patch : Bug 22605: (RM follow-up) Fix test suite -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #52 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #51 from Fridolin Somers --- *** Bug 27568 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #50 from Fridolin Somers --- Feature looks great. But I've opened Bug 30357 to improve the display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Fridolin Somers changed: What|Removed |Added Blocks||30357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30357 [Bug 30357] Better display of 'Edit this search' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #49 from Fridolin Somers --- (In reply to Fridolin Somers from comment #48) > QA tools shows : > > FAIL koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc >FAIL spelling >Theses ==> These, thesis >Theses ==> These, thesis > > But this is not caused by this bug. > If valid create another bug report. Ah heu yes it is created by this bug ^^ But this text is already used in actual master : koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt: Theses koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt: Theses So skip -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #48 from Fridolin Somers --- QA tools shows : FAIL koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc FAIL spelling Theses ==> These, thesis Theses ==> These, thesis But this is not caused by this bug. If valid create another bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #47 from Nick Clemens --- Created attachment 131779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131779=edit Bug 22605: (QA follow-up) Make Braille search option stick To test: - Add to records, one with 007 fb and another with 007 tc - Search for Format: Braille from the advanced search - Verify both records are found - Return to advanced search - Verify that Braille is still selected - Rerun search - same results show Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #46 from Nick Clemens --- Created attachment 131778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131778=edit Bug 22605: (follow-up) Add selected to audience attributes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #45 from Nick Clemens --- Created attachment 131777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131777=edit Bug 22605: Preselect subtype limits and don't allow multiple Dropdowns moved to an include, checked and preseleced Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #44 from Nick Clemens --- Created attachment 131776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131776=edit Bug 22605: (follow-up) Fix operators - Don't add an operator on first loop - Only add plus option on last loop - Fix indentation of first search box - Remove spaces from operators in query_cgi and add to query and query_desc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Attachment #126858|0 |1 is obsolete|| Attachment #126859|0 |1 is obsolete|| Attachment #126860|0 |1 is obsolete|| Attachment #126862|0 |1 is obsolete|| Attachment #126864|0 |1 is obsolete|| --- Comment #43 from Nick Clemens --- Created attachment 131775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131775=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives https://bugs.koha-community.org/show_bug.cgi?id=26605 Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Bug 22605 depends on bug 29350, which changed state. Bug 29350 Summary: TT method 'delete' don't need to be escaped https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29350 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_05_candidate --- Comment #42 from Jonathan Druart --- I am sorry, this one missed 21.11 (because of me, last week was crazy). There are too many changes in a controller with fragile code, I am not confident with doing an exception with these patches. Postponed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Jonathan Druart changed: What|Removed |Added Attachment #126863|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Jonathan Druart changed: What|Removed |Added Depends on||29350 CC||jonathan.druart+koha@gmail. ||com --- Comment #41 from Jonathan Druart --- (In reply to Katrin Fischer from comment #40) > (In reply to Nick Clemens from comment #39) > > (In reply to Katrin Fischer from comment #37) > > > Created attachment 126863 [details] [review] [review] [review] > > > Bug 22605: (QA follow-up) Add missing TT filters > > > > > > Signed-off-by: Katrin Fischer > > > > I don't know if this is necessary - I think these are false warnings as the > > data is not displayed > > Hm that could be, not insisting and leaving to Joubu. I only used the > automatic scripts, that probably doesn't know about delete? See bug 29350. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29350 [Bug 29350] TT method 'delete' don't need to be escaped -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #40 from Katrin Fischer --- (In reply to Nick Clemens from comment #39) > (In reply to Katrin Fischer from comment #37) > > Created attachment 126863 [details] [review] [review] > > Bug 22605: (QA follow-up) Add missing TT filters > > > > Signed-off-by: Katrin Fischer > > I don't know if this is necessary - I think these are false warnings as the > data is not displayed Hm that could be, not insisting and leaving to Joubu. I only used the automatic scripts, that probably doesn't know about delete? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #39 from Nick Clemens --- (In reply to Katrin Fischer from comment #37) > Created attachment 126863 [details] [review] > Bug 22605: (QA follow-up) Add missing TT filters > > Signed-off-by: Katrin Fischer I don't know if this is necessary - I think these are false warnings as the data is not displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126857|0 |1 is obsolete|| --- Comment #38 from Katrin Fischer --- Created attachment 126864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126864=edit Bug 22605: (QA follow-up) Make Braille search option stick To test: - Add to records, one with 007 fb and another with 007 tc - Search for Format: Braille from the advanced search - Verify both records are found - Return to advanced search - Verify that Braille is still selected - Rerun search - same results show Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126856|0 |1 is obsolete|| --- Comment #37 from Katrin Fischer --- Created attachment 126863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126863=edit Bug 22605: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126855|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 126862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126862=edit Bug 22605: (follow-up) Add selected to audience attributes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126854|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 126860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126860=edit Bug 22605: Preselect subtype limits and don't allow multiple Dropdowns moved to an include, checked and preseleced Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126853|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 126859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126859=edit Bug 22605: (follow-up) Fix operators - Don't add an operator on first loop - Only add plus option on last loop - Fix indentation of first search box - Remove spaces from operators in query_cgi and add to query and query_desc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126852|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 126858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126858=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives https://bugs.koha-community.org/show_bug.cgi?id=26605 Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #32 from Katrin Fischer --- Created attachment 126857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126857=edit Bug 22605: (QA follow-up) Make Braille search option stick To test: - Add to records, one with 007 fb and another with 007 tc - Search for Format: Braille from the advanced search - Verify both records are found - Return to advanced search - Verify that Braille is still selected - Rerun search - same results show -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126851|0 |1 is obsolete|| --- Comment #31 from Katrin Fischer --- Created attachment 126856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126856=edit Bug 22605: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126838|0 |1 is obsolete|| --- Comment #30 from Katrin Fischer --- Created attachment 126855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126855=edit Bug 22605: (follow-up) Add selected to audience attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126748|0 |1 is obsolete|| --- Comment #29 from Katrin Fischer --- Created attachment 126854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126854=edit Bug 22605: Preselect subtype limits and don't allow multiple Dropdowns moved to an include, checked and preseleced -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126747|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 126853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126853=edit Bug 22605: (follow-up) Fix operators - Don't add an operator on first loop - Only add plus option on last loop - Fix indentation of first search box - Remove spaces from operators in query_cgi and add to query and query_desc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Attachment #126746|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 126852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126852=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives https://bugs.koha-community.org/show_bug.cgi?id=26605 Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #26 from Katrin Fischer --- Sorry, lucky find (or unlucky): From the formats pull down, Braille won't stick. I believe because it's a combined one: l-format:tc or l-format:fb Please keep my follow-up for the TT filters when attaching a follow-up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #25 from Katrin Fischer --- Created attachment 126851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126851=edit Bug 22605: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #24 from Katrin Fischer --- You didn't fix the missing TT filters... I will. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #23 from Nick Clemens --- Created attachment 126838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126838=edit Bug 22605: (follow-up) Add selected to audience attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- I am sorry Nick, but the Audience sub type doesn't stick and I couldn't spot the mistake. Please also fix your missing TT filters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #21 from Nick Clemens --- Created attachment 126748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126748=edit Bug 22605: Preselect subtype limits and don't allow multiple Dropdowns moved to an include, checked and preseleced -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #20 from Nick Clemens --- Created attachment 126747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126747=edit Bug 22605: (follow-up) Fix operators - Don't add an operator on first loop - Only add plus option on last loop - Fix indentation of first search box - Remove spaces from operators in query_cgi and add to query and query_desc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Attachment #123965|0 |1 is obsolete|| --- Comment #19 from Nick Clemens --- Created attachment 126746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126746=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives https://bugs.koha-community.org/show_bug.cgi?id=26605 Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer --- Hi Nick, started retesting this: 1) Boolean opeators are not kept Starting with the advanced search in 'less options' mode. * Search for a simple keyword - OK * Add another keyword on the next input field - OK * When you return to search, it has switched from 'less' to 'more' - OKish * Switch the operator from and to not or or * When you return to serach, the operator has switched back to 'and' - BAD 2) Subtype search The subtype searches behave in a bit of an unexpected way: * Search for a set of the 4 subtypes * Return to serach - checkboxes appear instead of preselected pull-downs It looks like this will allow to search for more than one of each, but I feel like this might be better as a separate feature with a little more work. I see an issue in that you can't search multiple right away (or I didn't figure out how to). You have to add one audience... search... return... add another. That makes it a lot of clicks to add 3 options. For this feature... could we just go with making the right preselections on the pull downs and rethink the multiple option feature a bit more? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Bug 22605 depends on bug 28847, which changed state. Bug 28847 Summary: Branch limits while searching should be expanded in query building and not in CGI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123840|0 |1 is obsolete|| --- Comment #17 from Andrew Fuerste-Henry --- Created attachment 123965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123965=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives https://bugs.koha-community.org/show_bug.cgi?id=26605 Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Attachment #123839|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 123840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123840=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Attachment #123816|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 123839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123839=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Depends on||28847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Attachment #117174|0 |1 is obsolete|| Attachment #119177|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 123816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123816=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #13 from Nick Clemens --- 1) Fixed 2) Fixed, only displays if there are groups of libraries defined 3) These are false positives - they are lines removing the limits from the hash when prepopulating fields 4) Fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #12 from Nick Clemens --- Created attachment 119177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119177=edit Bug 22605: (follow-up) Correct terminology and fix conditionals This patch hides the display of 'Multiple libraries' selection of no groups are defined and correct the use of the term libraries over branches I fix the key used to delete the year limit after filling the form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #11 from Katrin Fischer --- 4) Text should be using library not branch(es) throughout. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #10 from Katrin Fischer ---
I like the idea of this, but it seems to work less nicely than in the OPAC.
Examples:
1) Publication date range search
I used a date range search: 1900-
On returning to the advanced search page the field is correctly prepopulated,
but the search still shows with the other options as well:
yr,st-numeric:1900-
As this is a standard search option of the advanced search, I feel that should
work a little better.
2) Multiple libraries section
Lots of new text added, but I have no option to select anything? I feel like
the GUI there is not working right now? Maybe multi-select of libraries should
be a separate enhancement?
3) Filters missing
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
FAIL filters
missing_filter at line 190 ([% limits.delete(
limit_key ) %])
missing_filter at line 228 ([%
limits.delete($year_limit_key) %])
missing_filter at line 247 ([% limits.delete(
langtype ) %])
missing_filter at line 280 ([% limits.delete(
subtype ) %])
missing_filter at line 371 ([% limits.delete('branch')
%])
missing_filter at line 392 ([%
limits.delete(key) %])
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Summary|Adding the option to|Adding the option to |modify/edit searches on the |modify/edit searches on the |staff client|staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
