[Koha-bugs] [Bug 22632] Add logging of merged patrons

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||lu...@bywatersolutions.com

--- Comment #57 from Lucas Gass  ---
Your tests include a deleted subroutine, C4::Logs::GetLogs. You must now use
Koha::ActionLogs->search instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #56 from Owen Leonard  ---
Created attachment 159558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159558&action=edit
Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #55 from Owen Leonard  ---
Created attachment 159557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159557&action=edit
Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #54 from Owen Leonard  ---
Created attachment 159556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159556&action=edit
Bug 22632: (follow-up) Use PATRON_MERGE as log action

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #53 from Owen Leonard  ---
Created attachment 159555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159555&action=edit
Bug 22632: Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #52 from Owen Leonard  ---
Created attachment 159554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159554&action=edit
Bug 22632: adding of the rescearch of merge in the log viewer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Owen Leonard  changed:

   What|Removed |Added

 Attachment #157266|0   |1
is obsolete||
 Attachment #157267|0   |1
is obsolete||
 Attachment #157268|0   |1
is obsolete||
 Attachment #157269|0   |1
is obsolete||
 Attachment #157270|0   |1
is obsolete||
 Attachment #157271|0   |1
is obsolete||
 Attachment #157286|0   |1
is obsolete||

--- Comment #51 from Owen Leonard  ---
Created attachment 159553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159553&action=edit
Bug 22632: Add logging of merged patrons

without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #50 from Katrin Fischer  ---
Can you please rebase?


Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22632: Add logging of merged patrons
Applying: Bug 22632: adding of the rescearch of merge in the log viewer
Applying: Bug 22632: Unit Testing of patch 22632
Applying: Bug 22632: (follow-up) Use PATRON_MERGE as log action
Applying: Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm
Applying: Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag
to Log.t
Applying: Bug 22632: (follow-up) Tidy and fix tests

error: sha1 information is lacking or useless (Koha/Patron.pm).

error: could not build fake ancestor
Patch failed at 0001 Bug 22632: (follow-up) Tidy and fix tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-22632-follow-up-Tidy-and-fix-tests-o_fvd6hr.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #49 from David Nind  ---
Thanks Nick! Tests now pass, signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Attachment #157281|0   |1
is obsolete||

--- Comment #48 from David Nind  ---
Created attachment 157286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157286&action=edit
Bug 22632: (follow-up) Tidy and fix tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Nick Clemens  changed:

   What|Removed |Added

 Attachment #157278|0   |1
is obsolete||

--- Comment #47 from Nick Clemens  ---
Created attachment 157281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157281&action=edit
Bug 22632: (follow-up) Tidy and fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #46 from David Nind  ---
(In reply to Nick Clemens from comment #45)
> (In reply to David Nind from comment #43)
> > I signed off before seeing comment #36
> > 
> > What should the status be changed to? Failed QA?
> > 
> Tests should pass now, and tidied - can you confirm tests and sign off David?

I'm getting a sha1 fake ancestor error when trying to apply the patches now.


git bz apply 22632

Bug 22632 - Add logging of merged patrons

157266 - Bug 22632: Add logging of merged patrons
157267 - Bug 22632: adding of the rescearch of merge in the log viewer
157268 - Bug 22632: Unit Testing of patch 22632
157269 - Bug 22632: (follow-up) Use PATRON_MERGE as log action
157270 - Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm
157271 - Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag
to Log.t
157278 - Bug 22632: (follow-up) Tidy and fix tests

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22632: Add logging of merged patrons
Applying: Bug 22632: adding of the rescearch of merge in the log viewer
Applying: Bug 22632: Unit Testing of patch 22632
Applying: Bug 22632: (follow-up) Use PATRON_MERGE as log action
Applying: Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm
Applying: Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag
to Log.t
Applying: Bug 22632: (follow-up) Tidy and fix tests
error: sha1 information is lacking or useless (Koha/Patron.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 22632: (follow-up) Tidy and fix tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #45 from Nick Clemens  ---
(In reply to David Nind from comment #43)
> I signed off before seeing comment #36
> 
> What should the status be changed to? Failed QA?
> 
Tests should pass now, and tidied - can you confirm tests and sign off David?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #44 from Nick Clemens  ---
Created attachment 157278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157278&action=edit
Bug 22632: (follow-up) Tidy and fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #43 from David Nind  ---
I signed off before seeing comment #36

What should the status be changed to? Failed QA?


Also now noted that the tests fail:

prove t/db_dependent/Koha/Patron/Log.t
t/db_dependent/Koha/Patron/Log.t .. 1/1 # No tests run!

#   Failed test 'No tests run for subtest "Test Koha::Patrons::merge"'
#   at t/db_dependent/Koha/Patron/Log.t line 97.
Undefined subroutine &main::GetLogs called at t/db_dependent/Koha/Patron/Log.t
line 44.
# Looks like your test exited with 11 just after 1.
t/db_dependent/Koha/Patron/Log.t .. Dubious, test returned 11 (wstat 2816,
0xb00)
Failed 1/1 subtests 

Test Summary Report
---
t/db_dependent/Koha/Patron/Log.t (Wstat: 2816 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 11
Files=1, Tests=1,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.11 cusr  0.26
csys =  1.39 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Attachment #157265|0   |1
is obsolete||

--- Comment #42 from David Nind  ---
Created attachment 157271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157271&action=edit
Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Attachment #157264|0   |1
is obsolete||

--- Comment #41 from David Nind  ---
Created attachment 157270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157270&action=edit
Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Attachment #157263|0   |1
is obsolete||

--- Comment #40 from David Nind  ---
Created attachment 157269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157269&action=edit
Bug 22632: (follow-up) Use PATRON_MERGE as log action

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Attachment #157262|0   |1
is obsolete||

--- Comment #39 from David Nind  ---
Created attachment 157268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157268&action=edit
Bug 22632: Unit Testing of patch 22632

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Attachment #157261|0   |1
is obsolete||

--- Comment #38 from David Nind  ---
Created attachment 157267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157267&action=edit
Bug 22632: adding of the rescearch of merge in the log viewer

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Attachment #157260|0   |1
is obsolete||

--- Comment #37 from David Nind  ---
Created attachment 157266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157266&action=edit
Bug 22632: Add logging of merged patrons

without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #36 from Owen Leonard  ---
I've rebased this and added some cleanup follow-ups, but I think this still
needs work to address all the QA tool issues.

Hopefully someone else can take this to the finish line?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #35 from Owen Leonard  ---
Created attachment 157265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157265&action=edit
Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #34 from Owen Leonard  ---
Created attachment 157264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157264&action=edit
Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #33 from Owen Leonard  ---
Created attachment 157263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157263&action=edit
Bug 22632: (follow-up) Use PATRON_MERGE as log action

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #32 from Owen Leonard  ---
Created attachment 157262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157262&action=edit
Bug 22632: Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #31 from Owen Leonard  ---
Created attachment 157261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157261&action=edit
Bug 22632: adding of the rescearch of merge in the log viewer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Owen Leonard  changed:

   What|Removed |Added

  Attachment #89728|0   |1
is obsolete||
  Attachment #89730|0   |1
is obsolete||
  Attachment #89731|0   |1
is obsolete||

--- Comment #30 from Owen Leonard  ---
Created attachment 157260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157260&action=edit
Bug 22632: Add logging of merged patrons

without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2022-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Sharon Dugdale  changed:

   What|Removed |Added

 CC||sharon.dugd...@cumbria.gov.
   ||uk

--- Comment #29 from Sharon Dugdale  ---
Hi
This has come up as an issue with Cumbria Libraries and the ability to see the
previous information on a merged patron record in the modification logs would
be really useful. I am told that the information is retained in the deleted
borrowers table however that would require a report to access the information
and our frontline staff would find it very useful to be able to see these
deleted personal details from the merged account. We get alot of duplicate
memberships from patrons re-joining online, sometimes with more uptodate
information than their existing record has and it would be useful for staff to
have this information if a patron queries the merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2022-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

mathieu saby  changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2022-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Marie-Luce Laflamme  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||marie-luce.laflamme@inlibro
   ||.com

--- Comment #28 from Marie-Luce Laflamme  ---
Patch doesn't apply.

The 'Merge' is not recorded in the log viewer, only the deleted account is
shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel Amghar  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel Amghar  changed:

   What|Removed |Added

  Attachment #89729|0   |1
is obsolete||

--- Comment #27 from axel Amghar  ---
Created attachment 89731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89731&action=edit
Bug 22632: Unit Testing of patch 22632

Current status: Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #26 from axel Amghar  ---
i have issues with the unit test so i put the status in assigned

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel Amghar  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #25 from axel Amghar  ---
(In reply to Katrin Fischer from comment #21)
> What Andrew suggests makes sense to me!

Hi, thank you for for the explanations :)
I think i get it, tell me if it's better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel Amghar  changed:

   What|Removed |Added

  Attachment #88043|0   |1
is obsolete||

--- Comment #22 from axel Amghar  ---
Created attachment 89728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89728&action=edit
Bug 22632: Add logging of merged patrons

without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel Amghar  changed:

   What|Removed |Added

  Attachment #88044|0   |1
is obsolete||

--- Comment #23 from axel Amghar  ---
Created attachment 89729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89729&action=edit
Bug 22632: Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel Amghar  changed:

   What|Removed |Added

  Attachment #88046|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel Amghar  changed:

   What|Removed |Added

  Attachment #88045|0   |1
is obsolete||

--- Comment #24 from axel Amghar  ---
Created attachment 89730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89730&action=edit
Bug 22632: adding of the rescearch of merge in the log viewer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #21 from Katrin Fischer  ---
What Andrew suggests makes sense to me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #20 from Andrew  ---
Hi folks,

Right, as Katrin says, I'm looking at the Object column. I realize both patrons
are in the Info column, so this works ok. But as it is, if I merge patrons 1 &
2, retaining patron 1, and then click Modification Log from patron 1's record
the merge doesn't appear in the log search Koha generates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #19 from Katrin Fischer  ---
(In reply to axel Amghar from comment #18)
> (In reply to Andrew from comment #17)
> > Would it be possible for this to get entered in the log with the retained
> > patron as the object, rather than the deleted patron? That way it would show
> > up in the modification log for the extant patron, which seems a bit more
> > helpful than having it tie to the deleted patron.
> > 
> > Other than that small nitpick, this is great!
> 
> hi,
> 
> in info we have :
> patron 1 has been been merged into patron 2, so we see both patrons.
> 
> Did you mean to reverse the sentence in:
> patron 2 has been merged with patron 1  ?

Hi Axel, there is an object column in the action_log table - I think he refers
to that. Not to the info part.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #18 from axel Amghar  ---
(In reply to Andrew from comment #17)
> Would it be possible for this to get entered in the log with the retained
> patron as the object, rather than the deleted patron? That way it would show
> up in the modification log for the extant patron, which seems a bit more
> helpful than having it tie to the deleted patron.
> 
> Other than that small nitpick, this is great!

hi,

in info we have :
patron 1 has been been merged into patron 2, so we see both patrons.

Did you mean to reverse the sentence in:
patron 2 has been merged with patron 1  ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #17 from Andrew  ---
Would it be possible for this to get entered in the log with the retained
patron as the object, rather than the deleted patron? That way it would show up
in the modification log for the extant patron, which seems a bit more helpful
than having it tie to the deleted patron.

Other than that small nitpick, this is great!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel Amghar  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||axel.amg...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87998|0   |1
is obsolete||
  Attachment #87999|0   |1
is obsolete||

--- Comment #16 from axel  ---
Created attachment 88046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88046&action=edit
Bug 22632: Change for the research of Modules : Patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87997|0   |1
is obsolete||

--- Comment #15 from axel  ---
Created attachment 88045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88045&action=edit
Bug 22632: adding of the rescearch of merge in the log viewer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87996|0   |1
is obsolete||

--- Comment #14 from axel  ---
Created attachment 88044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88044&action=edit
Bug 22632: Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87995|0   |1
is obsolete||

--- Comment #13 from axel  ---
Created attachment 88043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88043&action=edit
Bug 22632: Add logging of merged patrons

without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87998|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87998|0   |1
is obsolete||

--- Comment #12 from axel  ---
Created attachment 87999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87999&action=edit
Bug 22632: Change for the research of Modules : Patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87923|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87926|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #11 from axel  ---
Created attachment 87998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87998&action=edit
Bug 22632: Change for the research of Modules : Patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87922|0   |1
is obsolete||

--- Comment #8 from axel  ---
Created attachment 87995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87995&action=edit
Bug 22632: Add logging of merged patrons

without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #10 from axel  ---
Created attachment 87997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87997&action=edit
Bug 22632: adding of the rescearch of merge in the log viewer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #9 from axel  ---
Created attachment 87996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87996&action=edit
Bug 22632: Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #7 from axel  ---
Created attachment 87926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87926&action=edit
adding of the rescearch of merge in the log viewer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87778|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #6 from axel  ---
Created attachment 87923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87923&action=edit
Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #5 from axel  ---
Created attachment 87922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87922&action=edit
Bug 22632: Add logging of merged patrons

without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87921|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #4 from axel  ---
Created attachment 87921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87921&action=edit
Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87920|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
I think something went wrong here with the patch attached. Obsoleting the last
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #2 from axel  ---
Created attachment 87920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87920&action=edit
Bug 21003: Made Edit keywords more consistent in add_items-step2.tt

When adding a course reserve with a barcode that already exists, the
title, breadcrumbs, and legend of the form all specify that the user is
editing, and not adding, the book.

Test plan:
Same as comment 1

Signed-off-by: Devinim 
Signed-off-by: Bin Wen 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #1 from axel  ---
Created attachment 87778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87778&action=edit
without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |axel.amg...@gmail.com
   |ity.org |
 CC||axel.amg...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Andrew  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/